From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B97DC433FE for ; Thu, 17 Nov 2022 14:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DY/+yAm2V5tVBkCkcIR0lA1J33dx27wET/BF83v/noQ=; b=RDmW+r95TlkpY+ JoiNA2mPmRd2N8WMehheZaPJAWW5+Ho6hiTbFy1BvoaozVcqDdQchueWEas4WHSzp0fZ54ZKQMrG9 2iHJbQM7jzO/Jw3dyRVZ0FgG1HcdpgqezHMo4u20tF5qA+D/MyRfHaAcgBUxWwuU2qp8TGEa+Wutf M5KlzIy0hQmCdDpzgIbODAm9Rz2NJekQLwQOGbytLpq2jhuqk6zSn36NCEf/CUaI3gXdWpiSeWQ8J 952PODSdBCmYqXXPmVZzKiCRrRhSGlRprFo54gbXmxxtjw9rsE9jUrjaHpJh5PD7rUpSPmzoe+Cak bUnvq+jp8MveN6VDzPww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovfp1-00EnG2-IO; Thu, 17 Nov 2022 14:24:56 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovfoL-00En1A-B0 for linux-arm-kernel@lists.infradead.org; Thu, 17 Nov 2022 14:24:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668695052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nZPY6OJIRrwMZkBLytVOAK+0kIpEYMOqoTEpl19M6ws=; b=hUoTaAGanTb+dFIsYwLLhlfnQMB0aCJFI9TmBYC8BxqKf5kYiKSFMU1gc6yg+LJPykT3QI AQrYDFewqG1MLEo8qoJH249WxuNB2l2pc5tXg0Naq9dxoGM5YDnXWSrqtv7q7eO8D1WDeD +n08eYwOA2FxLtBRxb//jc3lRNwC9S8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-488-rmGHeVJvMHW_KqPuKAgJVg-1; Thu, 17 Nov 2022 09:24:11 -0500 X-MC-Unique: rmGHeVJvMHW_KqPuKAgJVg-1 Received: by mail-wm1-f69.google.com with SMTP id v188-20020a1cacc5000000b003cf76c4ae66so2847041wme.7 for ; Thu, 17 Nov 2022 06:24:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nZPY6OJIRrwMZkBLytVOAK+0kIpEYMOqoTEpl19M6ws=; b=3BR9xeSQekZ/kBbkFfsX5DkoUGXPnl/YVuM9xlsdx0srSTHHY8ygA12BdzkBXI+vqg nFKbTEAX2LaMmXFkFL4oKU4nsynDxePsp+H3xzRduojFKu7shiMWbEffD+W7+Y6bNc7h OFqnHFJkIRia0GCxRMToXkjAW0hggl1je+F5HtrUtt3N6xnNxkt/kub9e9bRfsA6aR+o ddrT4PbP+UyEFNcd/ohXukMgW0uVJgA7T+cEdmD0Cb6TIocO0l7xJJWjq99ZdbJqoRG4 8AeGgQDJEA9x7L+s/azfqkeYGuXT8oCZNlxz/aAi9a6ZkeupsecvCsO+jlo1O1iuvKUh qoGA== X-Gm-Message-State: ANoB5pm7hh+uqv4/Z/gXSpEqeWbwoDvGEwvgQfMHw7HNxX551Mw0r+c5 4hFRrB0gU+1vFCww6qRPfF5bRy6gJ9hXVh1yxSp332Yxj3Fsnekxf2xOOVK1y4Kdl6hY5jNFAbR KuLYJ3+kBuRUS31Tj8KkXvvQWitil+DOLJz4= X-Received: by 2002:a05:600c:24e:b0:3c5:f9f1:f956 with SMTP id 14-20020a05600c024e00b003c5f9f1f956mr5602444wmj.50.1668695050008; Thu, 17 Nov 2022 06:24:10 -0800 (PST) X-Google-Smtp-Source: AA0mqf660kXw1O9nDmBZzBp9eoh92b2B6Bcx05wnz8U6SS8Dy3l/finKWGNWkc/ihpfy4N9vMJHAMQ== X-Received: by 2002:a05:600c:24e:b0:3c5:f9f1:f956 with SMTP id 14-20020a05600c024e00b003c5f9f1f956mr5602401wmj.50.1668695049758; Thu, 17 Nov 2022 06:24:09 -0800 (PST) Received: from vschneid.remote.csb ([154.57.232.159]) by smtp.gmail.com with ESMTPSA id v18-20020a5d6112000000b00236e834f050sm1095385wrt.35.2022.11.17.06.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 06:24:09 -0800 (PST) From: Valentin Schneider To: Peter Zijlstra Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, Guo Ren , "Paul E. McKenney" , Steven Rostedt , Thomas Gleixner , Sebastian Andrzej Siewior , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Frederic Weisbecker , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Marc Zyngier , Mark Rutland , Russell King , Nicholas Piggin , "David S. Miller" Subject: Re: [RFC PATCH v2 6/8] treewide: Trace IPIs sent via smp_send_reschedule() In-Reply-To: References: <20221102182949.3119584-1-vschneid@redhat.com> <20221102183336.3120536-5-vschneid@redhat.com> Date: Thu, 17 Nov 2022 14:24:04 +0000 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_062413_514392_4C39DF95 X-CRM114-Status: GOOD ( 17.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/11/22 10:12, Peter Zijlstra wrote: > On Wed, Nov 02, 2022 at 06:33:34PM +0000, Valentin Schneider wrote: > >> diff --git a/kernel/smp.c b/kernel/smp.c >> index c4d561cf50d45..44fa4b9b1f46b 100644 >> --- a/kernel/smp.c >> +++ b/kernel/smp.c >> @@ -167,6 +167,14 @@ send_call_function_ipi_mask(const struct cpumask *mask) >> arch_send_call_function_ipi_mask(mask); >> } >> >> +void smp_send_reschedule(int cpu) >> +{ >> + /* XXX scheduler_ipi is inline :/ */ >> + trace_ipi_send_cpumask(cpumask_of(cpu), _RET_IP_, NULL); >> + arch_smp_send_reschedule(cpu); >> +} >> +EXPORT_SYMBOL_GPL(smp_send_reschedule); > > Yeah, no.. I see some crazy archs do this, but no we're not exporting > this in generic. So the list is: ia64, powerpc, riscv and they all seem to do it because of KVM: c4cb768f0277 ("[IA64] export smp_send_reschedule") de56a948b918 ("KVM: PPC: Add support for Book3S processors in hypervisor mode") d3d7a0ce020e ("RISC-V: Export kernel symbols for kvm") Other archs get out of it either because their smp_send_reschedule() is inline (e.g. x86), or because they don't allow building KVM as a module (e.g. arm64). If I can cobble the tracepoint+reschedule in an inline helper, then that wouldn't require any new exports - I'm fighting a bit with the header maze ATM, but hopefully I can get somewhere with this. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel