From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9793C433F5 for ; Tue, 11 Oct 2022 16:12:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qQs5V/Orbw7sp3FyRXIQLOLkiYwnUeyhA+5cwG7D/kw=; b=ESfEkuodd6cx4a AxakFUZTFMjW+pbimWsYFXlnL4oK2neNw3QSguPXVDnuhnlDP++86mhEeeWPMT6ZSlxZI1tIoT/Ia EU2BzAs25q7jKpZ3UW3nA8fS+EvkXlWjeb+G4hkFrKylh8EzYUc9ntK+zuaRWn8AoX5TrAS7VwqfQ W3rf6sttIzXy3MR+xfpWD8pZHoMlI/w9xW5LJ18RbXEfDKOxzKPtA7xtxRvSPaaOK4uFZ2B+T2o54 BYlHfBt1DzvTtF2n91WXMTr8F8g48u6yZfu3P+uknlJAnYOWuV3l3mYpol2ePuXvck/EfWeqD365f 9McgAXrqDb1xyG7zm6YQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiHqL-0055O6-Nt; Tue, 11 Oct 2022 16:10:58 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiGlr-004dEY-Ve for linux-arm-kernel@lists.infradead.org; Tue, 11 Oct 2022 15:02:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665500531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ti1NCFCTzr5YPwBHvg45c+mfaiUwrR60uA7ep6lLZuA=; b=OJpsu0oiqO/4x8YO39vX/PdhqG3YhOp5vJJ+FXxmqN7tf3kb05bF1gvNGfXlKQJ9GA1JLh Y5r5lR54sQg2QT4K6YvXMCgkE5uN/kLm0l/qZPoIZq6AQO1AmWlmITZ2rQDJ9gqIW8fuXq zfcQSR39NLvs/0nAtS5EryTWtBrpk/c= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-178-OFPdAeI7NJiB-I8YrVnvmQ-1; Tue, 11 Oct 2022 11:02:10 -0400 X-MC-Unique: OFPdAeI7NJiB-I8YrVnvmQ-1 Received: by mail-wm1-f69.google.com with SMTP id t20-20020a7bc3d4000000b003c6bfea856aso1041795wmj.1 for ; Tue, 11 Oct 2022 08:02:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ti1NCFCTzr5YPwBHvg45c+mfaiUwrR60uA7ep6lLZuA=; b=n+2giweHkKch/Aq+naMg05/FL0aGJxD03IK4eg0VzAH906ONl6RD2ZV7vel4GqF7mC juvkUWA2zNpy7lB0OdNIVKqmeaD4nwgmvUgTGvFSwgIjVM0maNzSaR0YCNaVhsV4EyP5 A95lKkJIfO/VceJLfg/NCa2f0a5qTJPQQMRJPYFTcvHRymNSNQSG8caJZC4vdg0SMqa8 gTatEsnJPhJl02GoFjLP0egp4QxzaEo77ehOf2qHHqxeI7Z906wsqXZSk25RR/9j2fpJ qpPRgW9SIv4JMiBOMA6xs0ERkWQap4QziEzqr5/7bzW/pUMOpg0x7e0Uc39dB/aRtEys TAdQ== X-Gm-Message-State: ACrzQf1x3DX5v2k5QymSevZ6/zsKpqAdCxY23xvYa7Th9IlZc5iLqQ8t WQSMaXTa1mYS/Yc/ZJp6FpjEkFYzhS4aOXOPVa1bwN5fMSRWDF/rAfGDXTt/I/0vjNcyDemP93q MEADxp/FgnSgPRQowhmYgzukjcQ7SLMoLXeA= X-Received: by 2002:a5d:59a3:0:b0:22e:4b62:7ceb with SMTP id p3-20020a5d59a3000000b0022e4b627cebmr15699184wrr.90.1665500528706; Tue, 11 Oct 2022 08:02:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7srUgXRaEVg4Pb59BUs0ShAt8e40s56KQw2lU0G4VdN3sOMR/0VHio2//G+OqnLs1Wx3l7Vw== X-Received: by 2002:a5d:59a3:0:b0:22e:4b62:7ceb with SMTP id p3-20020a5d59a3000000b0022e4b627cebmr15699160wrr.90.1665500528495; Tue, 11 Oct 2022 08:02:08 -0700 (PDT) Received: from vschneid.remote.csb ([104.132.153.106]) by smtp.gmail.com with ESMTPSA id bh11-20020a05600c3d0b00b003b49ab8ff53sm13552403wmb.8.2022.10.11.08.02.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 08:02:07 -0700 (PDT) From: Valentin Schneider To: Steven Rostedt Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, "Paul E. McKenney" , Peter Zijlstra , Thomas Gleixner , Sebastian Andrzej Siewior , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Frederic Weisbecker , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Marc Zyngier , Mark Rutland , Russell King , Nicholas Piggin , Guo Ren , "David S. Miller" Subject: Re: [RFC PATCH 4/5] irq_work: Trace calls to arch_irq_work_raise() In-Reply-To: <20221008153442.159b2f2d@rorschach.local.home> References: <20221007154145.1877054-1-vschneid@redhat.com> <20221007154533.1878285-4-vschneid@redhat.com> <20221008153442.159b2f2d@rorschach.local.home> Date: Tue, 11 Oct 2022 16:02:06 +0100 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221011_080216_124146_50DE4871 X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/10/22 15:34, Steven Rostedt wrote: > On Fri, 7 Oct 2022 16:45:32 +0100 > Valentin Schneider wrote: >> } >> >> +static inline void irq_work_raise(void) >> +{ >> + if (arch_irq_work_has_interrupt()) >> + trace_ipi_send_cpu(_RET_IP_, smp_processor_id()); > > To save on the branch, let's make the above: > > if (trace_ipi_send_cpu_enabled() && arch_irq_work_has_interrupt()) > > As the "trace_*_enabled()" is a static branch that will make it a nop > when the tracepoint is not enabled. > Makes sense, thanks for the suggestion. > -- Steve > > >> + >> + arch_irq_work_raise(); >> +} >> + >> /* Enqueue on current CPU, work must already be claimed and preempt disabled */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel