From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53ABBC2D0A3 for ; Wed, 4 Nov 2020 19:31:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E312E2065D for ; Wed, 4 Nov 2020 19:31:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gcBxkn9J"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="axlsn2DR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E312E2065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GjSwkrzjEiJ5PHiWTB7I7+vVbGQgIPcuuHdPprfVLx4=; b=gcBxkn9JKQjIlic8s5rybGeOH 0cr3HayY8niDQlSIPFN8yvT6Lac4yU80lmKV975KU25LVmYzlxBmKvLw4YzPrltFhl4RbQqn6Wzci MiETY1kfP207xAUknU3wa8X8EpBKRbd58cuzjUSX+QgoiUyR3TfOi3NQVR3+k63nHcykBr+ig00PN bHRq23v0P6Q99kw/4EZFIkYhfa0getACgzw3rBtNOsyNOHWB6evvBVyrNspOIqJUHOTiO5BuaB0P8 5Mae9AiMjxALuUzfCA2oghI/U7NV0IcnSSo4XvT2jk8mPEJMRHNQhERHNcPeAzQ7EaYA10bnHRZq+ CbZhvg9Dg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaOUx-0000OK-94; Wed, 04 Nov 2020 19:31:11 +0000 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaOUr-0000Lc-3a for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 19:31:06 +0000 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A4J38xR010691; Wed, 4 Nov 2020 14:30:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=kqKl/Fy8OlJQj/Gv88agH7/I5WU7KGmVdKg9ghw1xjE=; b=axlsn2DRWHDAS1wDGm5KQ2jnhCI2uU7k639SaPpAjB8Z+DVxulOkpAMQ1G/H5twIxT5e 9PRqMtQtX5M4rqSTIMf4U+Q+6c/JT/NjOBDbavk00Qie57PBy7U1zHmLj4cZpN+Ft2U4 nALH8GWZpYxVp4pFTLOx7zMROTMMUEH18i1y6p7XpS+m8O9SWD0UG0ENIeFoy0oDa0x6 xDuCD5bo1uJjojo5EpBeiCNMFVPdxV29En81C9QKwkGYZkWuqQHycGAGu47txBVnPT57 Qj7WIg5ZLz8mRYWytWSsGErDtthbiBPn5q5xt5zEG2TlbvhScOmiLNOslB/C0MX+8s3Q DQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 34m0qck9gv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Nov 2020 14:30:54 -0500 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0A4J3INU011124; Wed, 4 Nov 2020 14:30:53 -0500 Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 34m0qck9ea-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Nov 2020 14:30:53 -0500 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0A4JRnj4026068; Wed, 4 Nov 2020 19:30:48 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma03fra.de.ibm.com with ESMTP id 34j8rh9jk6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Nov 2020 19:30:47 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0A4JUjQb60424536 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Nov 2020 19:30:45 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 544FF4C04A; Wed, 4 Nov 2020 19:30:45 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4925A4C044; Wed, 4 Nov 2020 19:30:44 +0000 (GMT) Received: from localhost (unknown [9.145.163.252]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 4 Nov 2020 19:30:44 +0000 (GMT) Date: Wed, 4 Nov 2020 20:30:42 +0100 From: Vasily Gorbik To: Andrey Konovalov Subject: Re: [PATCH v7 16/41] kasan: rename KASAN_SHADOW_* to KASAN_GRANULE_* Message-ID: References: <4dee872cf377e011290bbe2e90c7e7fd24e789dd.1604333009.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-04_12:2020-11-04, 2020-11-04 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 mlxscore=0 spamscore=0 clxscore=1015 mlxlogscore=999 impostorscore=0 suspectscore=1 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011040138 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_143105_327550_0D2EA69C X-CRM114-Status: GOOD ( 30.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Marco Elver , Elena Petrova , Catalin Marinas , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev , LKML , Linux Memory Management List , Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 04, 2020 at 08:22:07PM +0100, Andrey Konovalov wrote: > On Wed, Nov 4, 2020 at 8:11 PM Vasily Gorbik wrote: > > > > On Mon, Nov 02, 2020 at 05:03:56PM +0100, Andrey Konovalov wrote: > > > This is a preparatory commit for the upcoming addition of a new hardware > > > tag-based (MTE-based) KASAN mode. > > > > > > The new mode won't be using shadow memory, but will still use the concept > > > of memory granules. Each memory granule maps to a single metadata entry: > > > 8 bytes per one shadow byte for generic mode, 16 bytes per one shadow byte > > > for software tag-based mode, and 16 bytes per one allocation tag for > > > hardware tag-based mode. > > > > > > Rename KASAN_SHADOW_SCALE_SIZE to KASAN_GRANULE_SIZE, and KASAN_SHADOW_MASK > > > to KASAN_GRANULE_MASK. > > > > > > Also use MASK when used as a mask, otherwise use SIZE. > > > > > > No functional changes. > > > > > > Signed-off-by: Andrey Konovalov > > > Signed-off-by: Vincenzo Frascino > > > Reviewed-by: Marco Elver > > > --- > > > Change-Id: Iac733e2248aa9d29f6fc425d8946ba07cca73ecf > > > --- > > > Documentation/dev-tools/kasan.rst | 2 +- > > > lib/test_kasan.c | 2 +- > > > mm/kasan/common.c | 39 ++++++++++++++++--------------- > > > mm/kasan/generic.c | 14 +++++------ > > > mm/kasan/generic_report.c | 8 +++---- > > > mm/kasan/init.c | 8 +++---- > > > mm/kasan/kasan.h | 4 ++-- > > > mm/kasan/report.c | 10 ++++---- > > > mm/kasan/tags_report.c | 2 +- > > > 9 files changed, 45 insertions(+), 44 deletions(-) > > > > hm, this one got escaped somehow > > > > lib/test_kasan_module.c: > > 18 #define OOB_TAG_OFF (IS_ENABLED(CONFIG_KASAN_GENERIC) ? 0 : KASAN_SHADOW_SCALE_SIZE) > > You mean it's not on the patch? It is, almost at the very top. lib/test_kasan_module.c != lib/test_kasan.c I fetched your branch. And I had to fix it up to build old good kasan test module CONFIG_TEST_KASAN_MODULE=m _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel