From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 621C8C43381 for ; Thu, 21 Mar 2019 00:11:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FED4218AE for ; Thu, 21 Mar 2019 00:11:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mjmbbzyv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Ow6X2Oz7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FED4218AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:From:Subject:To:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AVR4FEnW+dPu00MzqLGGBn2TVC/p4NMhkHKozqpFbXg=; b=mjmbbzyvhA5BEj 8OJywP6QCDyYG8Ilrc46PInE6astyxS9zHUdG7eNYolCMDbfRjBSVuM5kteD9/jb7CVLYm/rOpuyH ijePj+0eCUEAsG5QUi8Atk+deafBThxUM2FcegjF4vQn2yJPe7rEVGCzlSMJ5GTMYIyC1y/x6UHkY EaTWyOnFfOV9lkuttl+csVL76AW6JHDnItSH0cccM24bL771UN9yuDOC6J+EZ/9ILjdzJJBSL69X5 aXvVPqRq2AqrLlUwvi/uj1X5XKwS2HE5OyZ3lT12ygjtN+ovtAjFQ5f6U2bZTfb3nX9x5daxuow4Y x6qAm4fvkUgoKbJkNjhg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6lIY-0008TS-EE; Thu, 21 Mar 2019 00:11:06 +0000 Received: from aserp2130.oracle.com ([141.146.126.79]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6lIU-0008SU-6u; Thu, 21 Mar 2019 00:11:03 +0000 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2KNraq9151111; Thu, 21 Mar 2019 00:10:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=MUUUrU9PxP9jY48hBhr+UlpQkYMWTNfEwILAjAppAL0=; b=Ow6X2Oz7Vztjw5jkzzS/KVaDMoPobNsi/UWpwzvxuVloDxHqEO00+DG14S7R15iLKqcy auQya1qm8zJUIUc83KwkIMRVCDru+fkbqGAb16poSoC62CsqekIrSva3AFdeww+KXC8v NJI1qiUJ/Z2H5j7OASlkt0x9Wdwn8j8JM1tgXHtn9jljCHFzzfZgT3V+RP+BvwfLyB3P oKif5dXx13ftw2emB3C6lDlknQwiavlWe1UY9k88nlRPHfY2RPJ9wUFH0OVrdJC/oLHP DIbUwJgxOC6/N5DCeKA+l6Mo8bP5uFDUZNKyZDZAxXuaOW0HC23uTV+O9xDTqDvTFg3B VA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2r8pnex0q5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Mar 2019 00:10:49 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x2L0Ahnp022370 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Mar 2019 00:10:43 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x2L0Af9b004135; Thu, 21 Mar 2019 00:10:41 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 20 Mar 2019 17:10:41 -0700 To: Nathan Chancellor Subject: Re: [PATCH] scsi: ufs-mediatek: Avoid using ret uninitialized in ufs_mtk_setup_clocks From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190320180340.25795-1-natechancellor@gmail.com> Date: Wed, 20 Mar 2019 20:10:38 -0400 In-Reply-To: <20190320180340.25795-1-natechancellor@gmail.com> (Nathan Chancellor's message of "Wed, 20 Mar 2019 11:03:40 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9201 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=745 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903200170 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190320_171102_347372_E0EEA9BB X-CRM114-Status: UNSURE ( 9.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, "Martin K. Petersen" , clang-built-linux@googlegroups.com, "James E.J. Bottomley" , Nick Desaulniers , linux-kernel@vger.kernel.org, Avri Altman , linux-mediatek@lists.infradead.org, Alim Akhtar , Matthias Brugger , Stanley Chu , Pedro Sousa , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Nathan, > Remove the default case and initialize ret to -EINVAL to properly fix > this warning. Applied to 5.2/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel