From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39F54C3DA4A for ; Thu, 22 Aug 2024 04:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qgSqLSDg1zrf4uDhJF/8ngUUgb1bMqqCWRNYLuojDDM=; b=Ni0bthF14JxBBa3tRTL5McZSd1 hBvbhqJBJuPo1/Vasjfl3scoZ+ZVabQ8WAJXc5J05jxfo9/9E7ecPsBvlN1Gini/kt0tJOli+fY3t 1f7WlVkk437h4NCLZXc6SYhwpfvZ4FEhCO73FKyJ0UtpPXvJeWkrqk+7zlrH4BJffLLyhM4aUfJGB AuTS5SUYOcEASjgi8M1wH4gPxcC2WHyiK1Aeehle7A4tMacpIZMLlV9pU26ui/1JO51WPRtQS132M wIDpLF0aWw4Sax/sx+VhiyxMgCF62vG4sw2w6aSZBYkrXF1tMMg11ithTG06e4zi3S8eLr9V2qTVi vGaRuDNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgyzK-0000000BIFW-0fPU; Thu, 22 Aug 2024 03:59:54 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgyyb-0000000BIAY-0sCV for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2024 03:59:10 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8D35FA4210C; Thu, 22 Aug 2024 03:59:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D854C4AF09; Thu, 22 Aug 2024 03:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724299147; bh=MeUaIymMWet32UJr/UCPvNt4T3nq4nqzI61CVdg0XFc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IqaFpXLafjAn3gFHbE3Avza/+ergXjXsURmfn1nc96I21IgbyAp3IFHUfKBJ8IkrM KbPZvIH8QwNb5lI4zjYq40LMvg6oJ2fwPJprnRKLnMlZZZ3+xzRK8DROCHWddfiNe2 02Jhvckthxrri4w888p1nL3A/zNBeK8TVrMnoh1TGoB8lpJKb048k00MlHzC0XAj4h haqjQ8nkxVyayvp8ght5uS4Li/Svb7f9uatYHSOS/zfVZRbqlxJgNBPDD5vxdLNHr9 bc/QCVAWFsSwhqtsDmvOBKu6wv0C2oH9W4MzRfbfp88VLGN7lFyvUIdIoKK7f6kMVs 80fZdHBTViAsw== X-Mailer: emacs 31.0.50 (via feedmail 11-beta-1 I) From: Aneesh Kumar K.V To: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Steven Price , Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun Subject: Re: [PATCH v4 18/43] arm64: RME: Handle realm enter/exit In-Reply-To: <20240821153844.60084-19-steven.price@arm.com> References: <20240821153844.60084-1-steven.price@arm.com> <20240821153844.60084-19-steven.price@arm.com> Date: Thu, 22 Aug 2024 09:28:56 +0530 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_205909_335634_60ED2AF6 X-CRM114-Status: UNSURE ( 8.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Steven Price writes: > + /* Exit to VMM to complete the change */ > + kvm_prepare_memory_fault_exit(vcpu, base, top_ipa - base, false, false, > + ripas == 1); > + s/1/RMI_RAM ? May be we can make it an enum like rsi_ripas modified arch/arm64/include/asm/rmi_smc.h @@ -62,9 +62,11 @@ #define RMI_ERROR_REC 3 #define RMI_ERROR_RTT 4 -#define RMI_EMPTY 0 -#define RMI_RAM 1 -#define RMI_DESTROYED 2 +enum rmi_ripas { + RMI_EMPTY, + RMI_RAM, + RMI_DESTROYED, +}; #define RMI_NO_MEASURE_CONTENT 0 #define RMI_MEASURE_CONTENT 1 modified arch/arm64/kvm/rme-exit.c @@ -112,7 +112,7 @@ static int rec_exit_ripas_change(struct kvm_vcpu *vcpu) /* Exit to VMM to complete the change */ kvm_prepare_memory_fault_exit(vcpu, base, top_ipa - base, false, false, - ripas == 1); + ripas == RMI_RAM); return 0; }