From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AE60C54FC6 for ; Mon, 2 Sep 2024 05:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=POSkBiSvmo9Y8RDKGsIXqGERBbMiWv83F37IyQ/cZGM=; b=tnQN158+IjhYV4U65M5xVVWwUY e5SMUIxYSlf+NJH19BhyLtc7CeS7QxKKsSLCu8Y/uh/0DNGg3NrGI1drzoXMqc0XasckTed5xj2cV r7BGw4fmhzZ2oEFZ38AdK6f93y3R/PGC9JRLfcDAcTe6E27FPSYqMQheiA35VLltyc/8IPWMI3wzP 6kd/qzr9T5qgfcIGPOp78isHSuIModA5r1j6C9VucnSBTf5JQZi5bdEW/Dm5y09t7V5khrZW4+lSk WoA2wIn9T3JTrKo7+aj2ecCScrwAP7SyusZDrW+Hj7rCd7YPAExvlSzCZ1wfffqCD+/gIyfUzy0ZU VCv2Ftqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skzOv-0000000D03o-0QVd; Mon, 02 Sep 2024 05:14:53 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1skzO1-0000000Czxb-1GKm for linux-arm-kernel@lists.infradead.org; Mon, 02 Sep 2024 05:13:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 2C9D9A41678; Mon, 2 Sep 2024 05:13:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27587C4CEC2; Mon, 2 Sep 2024 05:13:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725254035; bh=TPpkqPR8V96Q4pNrawsjjZ2uf1OIDvvR3Rbrdkwd92U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=F+cRk6C+jqe45JXc4w0ECr/xyLVyKeWB5ttckCESjF9gnaHUrOZIp8Cmy+ADMZKhT tvJ/Mj1jcRGsNTD2I3ilGlwKnBJxhytLCKBTOL88ChzM/p4dk4bFnL1IXmikmLOPpg IKe0ZuJqsVLJ4gssWyapKhx+alqZeAa0cJUFNn7R6ydE3J8Y8b6om477nBFwLlQFNF u7856rqq+XyEfM7IHFLpz/kGK3C49BoRt829dJs7gXtEVGT0Fr6Z2lKet8BsO/OX9g Gf8EslHcIoX9C/L3qe+ov4ALSnSN/wERdqmBqy5UEgkJugvvdXRHwRF3SmeLUr59/C Mfrf3Gj2qRKdA== X-Mailer: emacs 31.0.50 (via feedmail 11-beta-1 I) From: Aneesh Kumar K.V To: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Steven Price , Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun Subject: Re: [PATCH v4 43/43] KVM: arm64: Allow activating realms In-Reply-To: <20240821153844.60084-44-steven.price@arm.com> References: <20240821153844.60084-1-steven.price@arm.com> <20240821153844.60084-44-steven.price@arm.com> Date: Mon, 02 Sep 2024 10:43:43 +0530 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240901_221357_431328_25D9929B X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Steven Price writes: > Add the ioctl to activate a realm and set the static branch to enable > access to the realm functionality if the RMM is detected. > > Signed-off-by: Steven Price > --- > arch/arm64/kvm/rme.c | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/rme.c b/arch/arm64/kvm/rme.c > index 9f415411d3b5..1eeef9e15d1c 100644 > --- a/arch/arm64/kvm/rme.c > +++ b/arch/arm64/kvm/rme.c > @@ -1194,6 +1194,20 @@ static int kvm_init_ipa_range_realm(struct kvm *kvm, > return realm_init_ipa_state(realm, addr, end); > } > > +static int kvm_activate_realm(struct kvm *kvm) > +{ > + struct realm *realm = &kvm->arch.realm; > + > + if (kvm_realm_state(kvm) != REALM_STATE_NEW) > + return -EINVAL; > + > + if (rmi_realm_activate(virt_to_phys(realm->rd))) > + return -ENXIO; > + > + WRITE_ONCE(realm->state, REALM_STATE_ACTIVE); > + return 0; > +} > + > /* Protects access to rme_vmid_bitmap */ > static DEFINE_SPINLOCK(rme_vmid_lock); > static unsigned long *rme_vmid_bitmap; > @@ -1343,6 +1357,9 @@ int kvm_realm_enable_cap(struct kvm *kvm, struct kvm_enable_cap *cap) > r = kvm_populate_realm(kvm, &args); > break; > } > + case KVM_CAP_ARM_RME_ACTIVATE_REALM: > + r = kvm_activate_realm(kvm); > + break; > default: > r = -EINVAL; > break; > @@ -1599,5 +1616,5 @@ void kvm_init_rme(void) > if (rme_vmid_init()) > return; > > - /* Future patch will enable static branch kvm_rme_is_available */ > + static_branch_enable(&kvm_rme_is_available); > like rsi_present, we might want to use this outside kvm, ex: for TIO. Can we move this outside module init so that we can have a helper like is_rme_supported() -aneesh