From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B626DC3DA4A for ; Thu, 22 Aug 2024 07:01:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZusXVhkjT3NOztIzjQfBdNBiuXgpR4ColvqOQ2CI1kc=; b=24BUXL6aTqCv4syvKTA1ccIpSv in6UMbhknbDJyUW4OKOKOEGgirb7yOzTlXU8Y3vNZvEkgTcarIF6Vm0hB3Az76+3rtd0UXHHlgaBW F68Ljnlisjrt0zE/GtMfwYXV4rA+s1LvvLjXn5tS74sybV86Z/2h5Y6XCBNLnH9dCBqI7wy26oDPw AiHD9lIK/mJcYeJbgfd5kCzCCV3F1qRr5gaLHQkFe/7hEPuewkt9dkOLcrVY53o8ftpPBR6OD01e5 8d6i9LtGDbu4Wjt6pOE+7PchzTLVgyumVISfl2lqMe45VZYdPipRKf0ZP70l/Yt9e5NnAtlgehg2Y x37M2bFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh1oU-0000000BkJQ-3qjf; Thu, 22 Aug 2024 07:00:54 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgyYY-0000000BDIO-1Z04 for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2024 03:32:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EFA04611D2; Thu, 22 Aug 2024 03:32:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 562F9C4AF09; Thu, 22 Aug 2024 03:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724297532; bh=EUR9oo2bOuT8CZglnOhT9XwulidBfPQJemFZwLJ8lIQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=DTUKwrigV+YgcDIMbKDEm9Ty3d/Fn5MQIDnW5D1v/J41f4yPWrk4t3DNP+bDZ/4M4 8OV9BJmuKmNRNMvDxOiRKWc1ZgsY8QagxXr6t6kn+iJUsFrrE55Fm6vzdMpHNh1uqY lZohaPsRYfRFZzX8povg3J8rg7N366nF99+4XTBDBMSOmZzY/v2mGvZbaab9Pr0syS uiwYWTVrlGZrChyUnzAKXb8p4rPNxc1NS9TCzi4u8kkow8wzfkz3OLUhOtbKZOf0n2 Et355enqRwY1Cz3wtgTWxOTVHeVbS72vjBv0auJkEGt3RRrPpavkcnf83hBDGZPqH2 ZtOV+cnMyxOiA== X-Mailer: emacs 31.0.50 (via feedmail 11-beta-1 I) From: Aneesh Kumar K.V To: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Steven Price , Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun Subject: Re: [PATCH v4 21/43] arm64: RME: Runtime faulting of memory In-Reply-To: <20240821153844.60084-22-steven.price@arm.com> References: <20240821153844.60084-1-steven.price@arm.com> <20240821153844.60084-22-steven.price@arm.com> Date: Thu, 22 Aug 2024 09:02:00 +0530 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_203214_493271_DBE29066 X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Steven Price writes: > At runtime if the realm guest accesses memory which hasn't yet been > mapped then KVM needs to either populate the region or fault the guest. > > For memory in the lower (protected) region of IPA a fresh page is > provided to the RMM which will zero the contents. For memory in the > upper (shared) region of IPA, the memory from the memslot is mapped > into the realm VM non secure. > > Signed-off-by: Steven Price > --- > Changes since v2: > * Avoid leaking memory if failing to map it in the realm. > * Correctly mask RTT based on LPA2 flag (see rtt_get_phys()). > * Adapt to changes in previous patches. > .... > - gfn = ipa >> PAGE_SHIFT; > + gfn = (ipa & ~gpa_stolen_mask) >> PAGE_SHIFT; > memslot = gfn_to_memslot(vcpu->kvm, gfn); > + > + if (kvm_slot_can_be_private(memslot)) { > + ret = private_memslot_fault(vcpu, fault_ipa, memslot); > + if (ret != -EAGAIN) > + goto out; > + } > Shouldn't this be s/fault_ipa/ipa ? ret = private_memslot_fault(vcpu, ipa, memslot); -aneesh