From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F5CDC10F01 for ; Wed, 20 Feb 2019 10:17:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E60EC21773 for ; Wed, 20 Feb 2019 10:17:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qE7vK+wt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E60EC21773 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mansr.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RdLDap6uOoFJvPDWYVBdb4gTi/s+RLfbJ7+UY3hdt1I=; b=qE7vK+wt0aIk6w HHxNQSVX1Hivj93rs3/yrzjZlSYGewm9N0Fxp9fIdpnxSE4upyw8nIRs/W/QwdxEZe4NAzCbEnH8t bcvSoMv4nboCHrGUFmcP9peJ4lzlXwv1HsKwHYE8P/IKdiE5BTCiZWk9FrFuztIABCAy+U47V7EuK amU9FrtKQMKhKWijGegVCU0j1mC/Djqbo5CTr/2RNiuHLgNVj6i0j/Pqs/ozS21N8nDlMRdEoxULm X/jY9I37B9gPo+30F1Hf9IoZFsAeX9mkDOy/YjxzrVzKsq6Ri8NtkmX+eVEwbxuKauqCOeM1LEQGw EO9J6Pcu7RuAxqXflI7A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwOwO-0007Pv-PU; Wed, 20 Feb 2019 10:17:24 +0000 Received: from unicorn.mansr.com ([81.2.72.234]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwOwL-0007P3-CY for linux-arm-kernel@lists.infradead.org; Wed, 20 Feb 2019 10:17:23 +0000 Received: by unicorn.mansr.com (Postfix, from userid 51770) id 8F1BA15632; Wed, 20 Feb 2019 10:17:04 +0000 (GMT) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Maxime Ripard Subject: Re: [PATCH] ARM: dts: sun7i: add pinctrl for missing uart mux options References: <20190216182132.12895-1-mans@mansr.com> <20190220090617.aprfndnidcamwcvy@flea> Date: Wed, 20 Feb 2019 10:17:04 +0000 In-Reply-To: <20190220090617.aprfndnidcamwcvy@flea> (Maxime Ripard's message of "Wed, 20 Feb 2019 10:06:17 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190220_021721_590166_A41CDFB8 X-CRM114-Status: GOOD ( 21.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , linux-kernel , Chen-Yu Tsai , Rob Herring , linux-arm-kernel Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Maxime Ripard writes: > On Wed, Feb 20, 2019 at 04:58:49PM +0800, Chen-Yu Tsai wrote: >> On Sun, Feb 17, 2019 at 2:21 AM Mans Rullgard wrote: >> > >> > This adds pinctrl settings for various missing uart options. >> > >> > Signed-off-by: Mans Rullgard >> > --- >> > arch/arm/boot/dts/sun7i-a20.dtsi | 45 ++++++++++++++++++++++++++++++++ >> > 1 file changed, 45 insertions(+) >> > >> > diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7= i-a20.dtsi >> > index af5b067a5f83..2295ff5adf48 100644 >> > --- a/arch/arm/boot/dts/sun7i-a20.dtsi >> > +++ b/arch/arm/boot/dts/sun7i-a20.dtsi >> > @@ -944,6 +944,31 @@ >> > function =3D "uart0"; >> > }; >> > >> > + uart0_pf_pins: uart0-pf-pins { >> > + pins =3D "PF2", "PF4"; >> > + function =3D "uart0"; >> > + }; >> = >> We've had the policy of not adding pinctrl nodes that aren't used in-tre= e, >> to avoid bloating up the blob size. However DTC 1.4.7 introduced the new >> /omit-if-no-ref/ directive, which would make the compiler discard marked >> nodes if they aren't referenced. >> = >> So please add this to all the new nodes. It seems to work regardless whe= ther >> you add it before or after the label, though having it after the label s= eems >> to make vim syntax highlighting happier. > > It also works (both for dtc and vim) if we put it on the previous > line, so something like: > > /omit-if-no-ref/ > uart0_pf_pins: uart0-pf-pins { > }; > > And it does have the advantage of keeping the same line width, which > could get pretty long on some nodes. Thanks, I'd missed that directive. It always seems needlessly annoying to make everybody working on a new board to add those nodes separately. -- = M=E5ns Rullg=E5rd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel