From: mans@mansr.com (Måns Rullgård)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: alignment: setup alignment handler earlier
Date: Wed, 07 Sep 2011 14:54:30 +0100 [thread overview]
Message-ID: <yw1xy5y0cvah.fsf@unicorn.mansr.com> (raw)
In-Reply-To: 87ehzstr07.fsf@vostro.fn.ogness.net
John Ogness <john.ogness@linutronix.de> writes:
> From 6f3f381800367127dc6430d9b9fa9bd6fc6d8ed0 Mon Sep 17 00:00:00 2001
> From: John Ogness <john.ogness@linutronix.de>
>
> The alignment exception handler is setup fairly late in
> the boot process (fs_initcall). However, with newer gcc
> versions and the compiler option -fconserve-stack, code
> accessing unaligned data is generated in functions that
> are called earlier, for example pcpu_dump_alloc_info().
This is a gcc bug and should not be worked around like this. There was
another patch[1] to disable -fconserve-stack on ARM due to this broken
behaviour. This patch was the outcome of a rather lengthy discussion[2].
[1] http://article.gmane.org/gmane.linux.kernel/1148272
[2] http://thread.gmane.org/gmane.linux.ports.arm.kernel/117863
> This results in unhandled alignment exceptions during
> boot. By setting up the exception handler sooner, we
> reduce the window where a compiler may generate code
> accessing unaligned data.
I will also restate my opinion that enabling strict alignment checking
on ARMv6 and later is *wrong* in the first place.
--
M?ns Rullg?rd
mans at mansr.com
next prev parent reply other threads:[~2011-09-07 13:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 13:35 [PATCH] ARM: alignment: setup alignment handler earlier John Ogness
2011-09-07 13:54 ` Måns Rullgård [this message]
2011-09-07 14:28 ` Catalin Marinas
2011-09-07 14:40 ` Catalin Marinas
2011-09-07 16:28 ` Russell King - ARM Linux
2011-09-07 16:42 ` Måns Rullgård
2011-09-07 17:04 ` Russell King - ARM Linux
2011-09-07 17:24 ` Catalin Marinas
2011-09-07 17:40 ` Måns Rullgård
2011-09-07 16:43 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xy5y0cvah.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox