From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sricharan" Subject: RE: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Date: Thu, 18 Feb 2016 14:15:42 +0530 Message-ID: <000101d16a28$c7867950$56936bf0$@codeaurora.org> References: <20160206003245.GA1329@deathstar> <20160208102459.GC2220@tetsubishi> <20160208163632.GA3630@deathstar> <01fd01d162a4$8e28c450$aa7a4cf0$@codeaurora.org> <20160208191658.GA23145@deathstar> <001b01d163fd$bfb15280$3f13f780$@codeaurora.org> <003201d16415$0eb1a8f0$2c14fad0$@codeaurora.org> <20160210163622.GA1390@deathstar> <20160217235314.GA13145@deathstar> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:56980 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424633AbcBRIp6 convert rfc822-to-8bit (ORCPT ); Thu, 18 Feb 2016 03:45:58 -0500 In-Reply-To: <20160217235314.GA13145@deathstar> Content-Language: en-us Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: 'Michael Welling' Cc: 'Daniel Baluta' , 'Wolfram Sang' , 'Jonathan Cameron' , 'Hartmut Knaack' , 'Lars-Peter Clausen' , 'Peter Meerwald-Stadler' , 'Linux Kernel Mailing List' , linux-iio@vger.kernel.org, 'Lucas De Marchi' , 'Andy Gross' , 'Pramod Gurav' , 'Bjorn Andersson' , 'Guenter Roeck' , eibach@gdsys.de, linux-arm-msm@vger.kernel.org Hi, > On Wed, Feb 10, 2016 at 10:36:22AM -0600, Michael Welling wrote: > > On Wed, Feb 10, 2016 at 08:39:04PM +0530, Sricharan wrote: > > > > Hi Sricharan, > > > > > > > > Are you looking at pca9685_pwm_probe in drivers/pwm/pwm- > pca9685.c > > > > right? > > > > > > > Yes. > > > > > > > I'm asking this because this driver doesn't seem to support > > > > runtime pm and there is no check for regmap_write/regmap_write > > > > return code in the probe function. > > > Hmm to be clear, so it=E2=80=99s the pm_runtime_getsync from i= 2c-qup which > fails right ? > > > I was tracking that when there are i2c_xfers from pwm. I did n= ot see > any failures there. > > > So wanted to know the correct sequence to reproduce. > > > > > > > The problem was discovered using the patch that this thread is on. = The > > PWM driver does not have the problem. > > > > When the driver in this patch called pm_runtime_get_sync you got -E= INVAL > back. >=20 > I noticed some patches for the QUP I2C driver in linux-next so I buil= t against > it. >=20 > The ADC driver now appears to work as desired. >=20 Ok, I suppose those were changes merged last week to add qup V2 tags= support, but not sure how that is helping to solve the pm_runtime issue here.=20 Regards, Sricharan