From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tanya Brokhman" Subject: RE: [PATCH 1/5 v8] usb: Adding SuperSpeed support to dummy_hcd Date: Sun, 27 Mar 2011 14:19:25 +0200 Message-ID: <000201cbec79$3a7dc4f0$af794ed0$@org> References: <1300867372-20811-1-git-send-email-tlinder@codeaurora.org> <20110325134730.GO2609@legolas.emea.dhcp.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:34126 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753410Ab1C0MSq (ORCPT ); Sun, 27 Mar 2011 08:18:46 -0400 In-Reply-To: <20110325134730.GO2609@legolas.emea.dhcp.ti.com> Content-Language: en-us Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: balbi@ti.com Cc: gregkh@suse.de, linux-arm-msm@vger.kernel.org, ablay@codeaurora.org, "'open list:USB GADGET/PERIPH...'" , 'open list' Hi > > > > MODULE_DESCRIPTION (DRIVER_DESC); > > MODULE_AUTHOR ("David Brownell"); > > @@ -220,6 +223,7 @@ static inline struct dummy *gadget_dev_to_dummy > (struct device *dev) > > } > > > > static struct dummy *the_controller; > > +static struct dummy *the_ss_controller; > > the only thing I don't like, is why you splitted the ss controller to a > separate controller. Why don't you use the same ? From SW perspective, > we can treat SS and HS/FS/LS controllers as one unit. > Actually I'm not sure about that... Because SS controller handles things a bit differently than HS/FS/LS. For example look at set_ss_link_state(), the port status is reported differently than for HS/FS/LS devices. It could be done, I mean spare the the_ss_controller variable and use the_controller, and we did that at first, but later on we decided to go back to this implementation since the code got too complex. Since dummy_hcd.c is used for debugging purposes we decided that simplicity is the better approach here. Best regards, Tanya Brokhman Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum