From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Yaniv Gardi" <ygardi@codeaurora.org>
Subject: RE: [PATCH v3 2/2] mmc: card: Adding support for Sanitize in eMMC v4.5
Date: Sun, 26 Feb 2012 11:35:11 +0200
Message-ID: <000a01ccf469$f18d6260$d4a82720$@org>
References: <1329832825-8844-1-git-send-email-ygardi@codeaurora.org> <1329832825-8844-3-git-send-email-ygardi@codeaurora.org> <4F43DCBA.5070605@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <4F43DCBA.5070605@codeaurora.org>
Content-Language: en-us
Sender: linux-kernel-owner@vger.kernel.org
To: 'Stephen Boyd' <sboyd@codeaurora.org>
Cc: linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, axboe@kernel.dk, 'open list' <linux-kernel@vger.kernel.org>
List-Id: linux-arm-msm@vger.kernel.org



= > -----Original Message-----
= > From: Stephen Boyd [mailto:sboyd@codeaurora.org]
= > Sent: Tuesday, February 21, 2012 8:05 PM
= > To: Yaniv Gardi
= > Cc: linux-mmc@vger.kernel.org; linux-arm-msm@vger.kernel.org;
= > axboe@kernel.dk; open list
= > Subject: Re: [PATCH v3 2/2] mmc: card: Adding support for Sanitize in
= > eMMC v4.5
= > 
= > On 02/21/12 06:00, Yaniv Gardi wrote:
= > > @@ -922,6 +918,44 @@ out:
= > >  	return err ? 0 : 1;
= > >  }
= > >
= > > +int mmc_blk_issue_sanitize_rq(struct mmc_queue *mq,
= > > +			       struct request *req)
= > > +{
= > > +	struct mmc_blk_data *md = mq->data;
= > > +	struct mmc_card *card = md->queue.card;
= > > +	int err = 0;
= > > +
= > > +	if (!(mmc_can_sanitize(card) && (mq->card->host->caps2 &
= > MMC_CAP2_SANITIZE))) {
= > > +		pr_err("%s: SANITIZE is not supported", __func__);
= > > +		err = -EOPNOTSUPP;
= > > +		goto out;
= > > +	}
= > > +
= > > +	pr_info("%s: SANITIZE is supported", __func__);
= > 
= > These look like debug printks. Please remove them.

Printout Removed.


= > 
= > > +
= > > +	mmc_sd_card_set_sanitize_in_progress(card);
= > > +
= > > +	pr_info("%s: issueing SANITIZE command...", __func__);
= > > +
= > > +	err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
= > > +					 EXT_CSD_SANITIZE_START, 1, 0);
= > > +
= > > +	pr_info("%s: SANITIZE command returned...", __func__);
= > > +
= > > +	if (err)
= > > +		pr_err("%s: mmcblk: mmc_switch() failed. err=%d\n",
= > > +		       __func__, err);
= > > +
= > > +	mmc_sd_card_set_sanitize_completed(card);
= > > +
= > > +out:
= > > +	spin_lock_irq(&md->lock);
= > > +	__blk_end_request(req, err, blk_rq_bytes(req));
= > > +	spin_unlock_irq(&md->lock);
= > > +
= > > +	return err ? 0 : 1;
= > > +}
= > > +
= > >  static int mmc_blk_issue_flush(struct mmc_queue *mq, struct
= > request *req)
= > >  {
= > >  	struct mmc_blk_data *md = mq->data;
= > > @@ -181,6 +186,11 @@ int mmc_init_queue(struct mmc_queue *mq,
= > struct mmc_card *card,
= > >  	if (mmc_can_erase(card))
= > >  		mmc_queue_setup_discard(mq->queue, card);
= > >
= > > +	if ((mmc_can_sanitize(card) && (host->caps2 &
= > MMC_CAP2_SANITIZE)))
= > > +		mmc_queue_setup_sanitize(mq->queue);
= > > +	else
= > > +		pr_info("%s - card doesn't support sanitize", __func__);
= > 
= > debug printk again?

Printout removed.


= > 
= > Sent by an employee of the Qualcomm Innovation Center, Inc.
= > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
= > Forum.