From: "Sricharan" <sricharan@codeaurora.org>
To: 'Rob Clark' <robdclark@gmail.com>, iommu@lists.linux-foundation.org
Cc: linux-arm-msm@vger.kernel.org
Subject: RE: [PATCH 1/2] iommu/msm: resume device after fault
Date: Fri, 12 Aug 2016 21:20:47 +0530 [thread overview]
Message-ID: <000f01d1f4b1$4da988c0$e8fc9a40$@codeaurora.org> (raw)
In-Reply-To: <1471015747-569-1-git-send-email-robdclark@gmail.com>
Hi,
>We need to disable stall on memory access after a fault, otherwise the
>device using the iommu will be perma-wedged with no access to memory.
>This was causing drm/msm to be unable to recover the gpu after an iommu
>fault.
>
>Signed-off-by: Rob Clark <robdclark@gmail.com>
>---
> drivers/iommu/msm_iommu.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c
>index b09692b..f6f596f 100644
>--- a/drivers/iommu/msm_iommu.c
>+++ b/drivers/iommu/msm_iommu.c
>@@ -628,6 +628,7 @@ irqreturn_t msm_iommu_fault_handler(int irq, void *dev_id)
> pr_err("Interesting registers:\n");
> print_ctx_regs(iommu->base, i);
> SET_FSR(iommu->base, i, 0x4000000F);
>+ SET_RESUME(iommu->base, i, 1);
Acked-by: sricharan@codeaurora.org
Regards,
Sricharan
prev parent reply other threads:[~2016-08-12 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 15:29 [PATCH 1/2] iommu/msm: resume device after fault Rob Clark
[not found] ` <1471015747-569-1-git-send-email-robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-12 15:29 ` [PATCH 2/2] iommu/msm: wire up fault handling Rob Clark
[not found] ` <1471015747-569-2-git-send-email-robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-12 16:17 ` Sricharan
2016-08-12 16:39 ` Rob Clark
2016-08-12 15:50 ` Sricharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000f01d1f4b1$4da988c0$e8fc9a40$@codeaurora.org' \
--to=sricharan@codeaurora.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).