[PATCH v6 0/5] usb gadget: Add SuperSpeed support to the Gadget Framework

[PATCH v6 0/5] usb gadget: Add SuperSpeed support to the Gadget Framework

[Tatyana Brokhman]

It was tested in the following ways:
1. Dummy_hcd and g_zero gadget with our internally developed unittest. 
   (See bellow)
2. Our DCD (that is not ready for upstreaming yet but we're working on
   it) and g_mass_storage gadget. With this setup we passed USBCV 2.0 and 3.0.
3. We developed a UAS gadget driver that is also working with this
   implementation over our DCD and the UAS Linux host driver. Its operational
   both in SS and in HS mode. Was released to the community in another patch series.
4. All of the other existing gadget drivers were minimally testes on
   the dummy_hcd setup as well (successful enumeration).

The unittest framework that was used for testing can be downloaded from 
git://codeaurora.org/quic/usb3/ut/.git
Please use the upstream branch.
See https://www.codeaurora.org/gitweb/quic/usb3/?p=ut/.git;a=summary for more 
details.

Tatyana Brokhman (5):
  usb: Adding SuperSpeed support to dummy_hcd
  usb: Add usb_endpoint_descriptor to be part of the struct usb_ep
  usb: Configure endpoint according to gadget speed.
  usb: Modify existing gadget drivers to use config_ep_by_speed()
    instead of     ep_choose.
  usb:gadget: Add SuperSpeed support to the Gadget Framework

 drivers/usb/gadget/Kconfig          |   12 +
 drivers/usb/gadget/composite.c      |  458 +++++++++++++++++++++++++++++--
 drivers/usb/gadget/config.c         |   25 --
 drivers/usb/gadget/dbgp.c           |    8 +-
 drivers/usb/gadget/dummy_hcd.c      |  519 ++++++++++++++++++++++++++++++++++-
 drivers/usb/gadget/epautoconf.c     |    7 +-
 drivers/usb/gadget/f_acm.c          |   50 +---
 drivers/usb/gadget/f_audio.c        |    5 +-
 drivers/usb/gadget/f_ecm.c          |   54 ++---
 drivers/usb/gadget/f_eem.c          |   36 +--
 drivers/usb/gadget/f_fs.c           |    3 +-
 drivers/usb/gadget/f_hid.c          |   22 +-
 drivers/usb/gadget/f_loopback.c     |   17 +-
 drivers/usb/gadget/f_mass_storage.c |   33 +--
 drivers/usb/gadget/f_ncm.c          |   58 ++---
 drivers/usb/gadget/f_obex.c         |   32 +--
 drivers/usb/gadget/f_phonet.c       |   17 +-
 drivers/usb/gadget/f_rndis.c        |   52 +---
 drivers/usb/gadget/f_serial.c       |   32 +--
 drivers/usb/gadget/f_sourcesink.c   |   14 +-
 drivers/usb/gadget/f_subset.c       |   33 +--
 drivers/usb/gadget/f_uvc.c          |    6 +-
 drivers/usb/gadget/file_storage.c   |    3 +-
 drivers/usb/gadget/gmidi.c          |    6 +-
 drivers/usb/gadget/inode.c          |    6 +-
 drivers/usb/gadget/printer.c        |   26 +-
 drivers/usb/gadget/u_ether.c        |   12 +-
 drivers/usb/gadget/u_ether.h        |    4 -
 drivers/usb/gadget/u_serial.c       |    4 +-
 drivers/usb/gadget/u_serial.h       |    2 -
 include/linux/usb/composite.h       |   55 +++-
 include/linux/usb/gadget.h          |   59 +++-
 32 files changed, 1245 insertions(+), 425 deletions(-)

-- 
1.7.3.3
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

RE: [PATCH v6 0/5] usb gadget: Add SuperSpeed support to the Gadget Framework

[Tanya Brokhman]

Hi Greg

As you know we've posted our implementation of SuperSpeed support for the
Gadget Framework. It's been released some time ago and we addressed most of
the comments we got with new versions. We're holding the latest  fixes for
Felipe Balbi comments since we're waiting for more inputs. We were wondering
if there anything else we can do to help this code be mainlined into the
kernel. 
We know it's being used since several developers addressed us (in private)
with questions on the setup. Also, our implementation of the UAS Gadget
driver relies on this code.

Please Advise.

Best regards,
Tanya Brokhman
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 0/5] usb gadget: Add SuperSpeed support to the Gadget Framework

[Greg KH]

On Thu, Mar 31, 2011 at 03:51:16PM +0200, Tanya Brokhman wrote:
> Hi Greg
> 
> As you know we've posted our implementation of SuperSpeed support for the
> Gadget Framework. It's been released some time ago and we addressed most of
> the comments we got with new versions. We're holding the latest  fixes for
> Felipe Balbi comments since we're waiting for more inputs. We were wondering
> if there anything else we can do to help this code be mainlined into the
> kernel. 

Keep releasing the patches, after splitting them up and addressing the
comments that people have made about them.

> We know it's being used since several developers addressed us (in private)
> with questions on the setup. Also, our implementation of the UAS Gadget
> driver relies on this code.

Note, you and Felipe are going to have to work together to agree on what
is the best solution here, we can't have two different implementations,
so I am going to rely on the both of you working to resolve the
differences.  When that happens, please let us know, and feel free to
hash out these details on the mailing list so that everyone can help
out.

thanks,

greg k-h

Re: [PATCH v6 0/5] usb gadget: Add SuperSpeed support to the Gadget Framework

[Felipe Balbi]

On Wed, Apr 13, 2011 at 02:49:58PM -0700, Greg KH wrote:
> On Thu, Mar 31, 2011 at 03:51:16PM +0200, Tanya Brokhman wrote:
> > Hi Greg
> > 
> > As you know we've posted our implementation of SuperSpeed support for the
> > Gadget Framework. It's been released some time ago and we addressed most of
> > the comments we got with new versions. We're holding the latest  fixes for
> > Felipe Balbi comments since we're waiting for more inputs. We were wondering
> > if there anything else we can do to help this code be mainlined into the
> > kernel. 
> 
> Keep releasing the patches, after splitting them up and addressing the
> comments that people have made about them.
> 
> > We know it's being used since several developers addressed us (in private)
> > with questions on the setup. Also, our implementation of the UAS Gadget
> > driver relies on this code.
> 
> Note, you and Felipe are going to have to work together to agree on what
> is the best solution here, we can't have two different implementations,
> so I am going to rely on the both of you working to resolve the
> differences.  When that happens, please let us know, and feel free to
> hash out these details on the mailing list so that everyone can help
> out.

True. I kept my patches for my own reference only but we can start with
Tanya's approach given she fixes our comments to her patches. Sebastian
is also helping hashing out the problems so we can get this in mainline
on next merge window.

Still, Tanya, it would be nice if you could already drop the UAS gadget
driver for us to start reviewing that one too :-) We can start with
your code but if anyone comes up with a comment to your patchset, we
need to get that fixed :-)

I only send my version because I didn't see yours previously, sorry
about that. Don't worry, we will take your version as soon as you clean
it up and fix up the comments from community members, good ?

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v6 0/5] usb gadget: Add SuperSpeed support to the Gadget Framework

[Tanya Brokhman]

> Still, Tanya, it would be nice if you could already drop the UAS gadget
> driver for us to start reviewing that one too :-) We can start with
> your code but if anyone comes up with a comment to your patchset, we
> need to get that fixed :-)

But I already did some time ago. I think you missed that one too. I'm now
working on version #3 of the UAS Gadget code. Actually I'm running some
final test at the moment and will release both another version of "SS
support in the Gadget FW" and the "UAS gadget driver" today.

> 
> I only send my version because I didn't see yours previously, sorry
> about that. Don't worry, we will take your version as soon as you clean
> it up and fix up the comments from community members, good ?

Sounds perfect :) Working on that....
Thanks for all your and Sebastians help!


Best regards,
Tanya Brokhman
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum





--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 0/5] usb gadget: Add SuperSpeed support to the Gadget Framework

[Felipe Balbi]

On Thu, Apr 14, 2011 at 03:03:18PM +0300, Tanya Brokhman wrote:
> 
> > Still, Tanya, it would be nice if you could already drop the UAS gadget
> > driver for us to start reviewing that one too :-) We can start with
> > your code but if anyone comes up with a comment to your patchset, we
> > need to get that fixed :-)
> 
> But I already did some time ago. I think you missed that one too. I'm now
> working on version #3 of the UAS Gadget code. Actually I'm running some
> final test at the moment and will release both another version of "SS
> support in the Gadget FW" and the "UAS gadget driver" today.

That's really great news Tanya :-) If I can ask, please put me in Cc to
those :-)

> > I only send my version because I didn't see yours previously, sorry
> > about that. Don't worry, we will take your version as soon as you clean
> > it up and fix up the comments from community members, good ?
> 
> Sounds perfect :) Working on that....
> Thanks for all your and Sebastians help!

no problem at all :-)

-- 
balbi