From: "Subhash Jadavani" <subhashj@codeaurora.org>
To: 'Daniel Walker' <dwalker@fifo99.com>
Cc: cjb@laptop.org, linux-mmc@vger.kernel.org,
linux-arm-msm@vger.kernel.org, davidb@codeaurora.org,
bryanh@codeaurora.org, linux-kernel@vger.kernel.org
Subject: RE: [RFC] mmc: msm_sdcc: Use SPS BAM as DMA engine
Date: Thu, 24 Mar 2011 13:02:31 +0530 [thread overview]
Message-ID: <005601cbe9f5$a5088750$ef1995f0$@org> (raw)
In-Reply-To: <1300885535.6117.15.camel@m0nster>
> -----Original Message-----
> From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-
> owner@vger.kernel.org] On Behalf Of Daniel Walker
> Sent: Wednesday, March 23, 2011 6:36 PM
> To: Subhash Jadavani
> Cc: cjb@laptop.org; linux-mmc@vger.kernel.org; linux-arm-
> msm@vger.kernel.org; davidb@codeaurora.org; bryanh@codeaurora.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [RFC] mmc: msm_sdcc: Use SPS BAM as DMA engine
>
> On Fri, 2011-03-18 at 18:54 +0530, Subhash Jadavani wrote:
> > On recent MSMs, ADM (Data Mover) HW is not present
> > which means existing SDCC driver can perform data
> > transfer in PIO (peripheral IO) mode only.
> > But PIO mode requires lot of CPU attention which
> > would mean consuming extra CPU MIPS.
> >
> > As a replacement on these recent MSMs, there is
> > a new DMA HW engine named SPS-BAM (as part of
> > Smart Peripheral System of MSM) is added for
> > data movement between SDCC core and system memory.
> >
> > This patch has done changes in existing MSM SDCC
> > driver for using SPS-BAM as DMA engine.
>
> 1300+ lines of code might warrant more of a description .. In the
> subject you say "DMA engine" but does this use drivers/dma/dmaengine.c
> ?
Here "DMA engine" means we are using SPS BAM as DMA HW.
No, we are not using the "drivers/dma/dmaengine.c" because MSM SPS driver is not exporting the dma compliant APIs to client. We are using the MSM SPS driver's exported APIs directly from our driver. Not sure what extra description we can put it in commit text. Any suggestion?
This is where MSM SPS driver patch is available: https://patchwork.kernel.org/patch/586271/
>
> > Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
> > ---
> > drivers/mmc/host/Kconfig | 10 +
> > drivers/mmc/host/Makefile | 1 +
> > drivers/mmc/host/msm_sdcc.c | 929
> +++++++++++++++++++++++++++++++++++++--
> > drivers/mmc/host/msm_sdcc.h | 47 ++
> > drivers/mmc/host/msm_sdcc_dml.c | 303 +++++++++++++
> > drivers/mmc/host/msm_sdcc_dml.h | 120 +++++
> > 6 files changed, 1374 insertions(+), 36 deletions(-)
> > create mode 100644 drivers/mmc/host/msm_sdcc_dml.c
> > create mode 100644 drivers/mmc/host/msm_sdcc_dml.h
>
> I'd do at least two patches. One that adds msm_sdcc_dml.[ch] and one
> that modifies msm_sdcc.[ch] and the Kconfig and Makefile.
>
> Daniel
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-24 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 13:24 [RFC] mmc: msm_sdcc: Use SPS BAM as DMA engine Subhash Jadavani
2011-03-18 13:24 ` Subhash Jadavani
2011-03-23 13:05 ` Daniel Walker
2011-03-24 7:32 ` Subhash Jadavani [this message]
2011-03-24 22:45 ` David Brown
2011-03-29 4:30 ` Koul, Vinod
2011-03-24 7:37 ` Subhash Jadavani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005601cbe9f5$a5088750$ef1995f0$@org' \
--to=subhashj@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=cjb@laptop.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).