From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B09BC6FD1C for ; Thu, 23 Mar 2023 13:13:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231320AbjCWNNI (ORCPT ); Thu, 23 Mar 2023 09:13:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbjCWNNH (ORCPT ); Thu, 23 Mar 2023 09:13:07 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34FE12101 for ; Thu, 23 Mar 2023 06:13:05 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id o40-20020a05600c512800b003eddedc47aeso1151606wms.3 for ; Thu, 23 Mar 2023 06:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679577183; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=juhp9OBUsPann54i4wUeJoNbrt/MgaPH7KWeZa71+xE=; b=jNzxhh+kAMOJUnJAJiZlm8CqqNjJB84FeneV/bsFBFNkwsv5ewzKW99RwM/+yo+dWD O5M7PoVQ+HmSm0Fp7TUSM4WUmaCD/M9RquYD/SYCw+xZ3DF85LQBhq6DffN9QsAzPSiz +SXGeH8zvrCymDFBZtcQHoWfSF5M0GCyh2Yk8xunJZ3oUEoj5sOSwvola6tWm9KPAExx wppVx0YrDi/ArfaymWwbqT75kwaGW9d3Z9Vn8zQPyMtL5GoGAHwYOoySoOmjx3hdS1VP UJk4RORne+G8ZcUQqELIerD3KaGhrzSzjw76MslFrWinmJXZ+hINTJ/vsGD5S7LbjbfF VXWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679577183; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=juhp9OBUsPann54i4wUeJoNbrt/MgaPH7KWeZa71+xE=; b=cxOVPMoCqhxu7YqXx29PKXoYns0Hq3QucS934D7EHWY651nQKyno3b8OMb6XslzWd0 9q83ctf2nVSX/Mil10DGFYBpdQqB3Ykj9Vl+QqaU5xADhdjAmd45z0fLzhrnPRhYoQbz /JGLU6t1o8bDp4DnAVYYRUVofZiDSR86j5Jtq4MCu5zdXzovOeGR6Uy+iXxzcyP8wey1 mjBGDMppUvKrdFOQC3k/QfSUYEGiTXcl8eKxTVf41GnwKNgqyQUMex3tn4+IXXL36frP 8OGXOJyqkR6T83poKT5Bdy6/dorIZCk9nWiZ+LEYh7wyjgzGdDbNVIeoAVUOH5Zs35EP 0c5w== X-Gm-Message-State: AO0yUKXW2k2ZK+BujaCxyG7bDSFI0pz+aF/0wOYQZwnmfOEciEamlAk9 iUZEjFIFcCmApvaBKvIs4xnlrw== X-Google-Smtp-Source: AK7set9AOlKnA/7JArDu4NZy/tacv+1Jc1By+62lRGQ2qjTDOfxTCEOmbDcLbYSrwaVOaWhWVZPiKA== X-Received: by 2002:a1c:f709:0:b0:3ed:c763:2765 with SMTP id v9-20020a1cf709000000b003edc7632765mr2405501wmh.7.1679577183642; Thu, 23 Mar 2023 06:13:03 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:e25a:65de:379a:3899? ([2a01:e0a:982:cbb0:e25a:65de:379a:3899]) by smtp.gmail.com with ESMTPSA id v4-20020a05600c470400b003ee8ab8d6cfsm1825918wmo.21.2023.03.23.06.13.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Mar 2023 06:13:03 -0700 (PDT) Message-ID: <006bf3bf-ab9a-4a08-3ba5-fa23ff4ea05a@linaro.org> Date: Thu, 23 Mar 2023 14:13:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node Content-Language: en-US To: Krzysztof Kozlowski , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Stephen Boyd , Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , linux-scsi@vger.kernel.org References: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-0-3ead1e418fe4@linaro.org> <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-6-3ead1e418fe4@linaro.org> <35e3aa8b-ccff-25fa-42da-d8934ef366c6@linaro.org> Organization: Linaro Developer Services In-Reply-To: <35e3aa8b-ccff-25fa-42da-d8934ef366c6@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 23/03/2023 11:47, Krzysztof Kozlowski wrote: > On 23/03/2023 11:25, Neil Armstrong wrote: >> Fixes the following DT bindings check error: >> codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long >> codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed: >> ['mclk', 'macro', 'dcodec', 'npl'] is too long >> >> The implementation was checked and this npl clock isn't used for the VA macro. >> > > This does not look correct. DTS looks good, you miss some patches in > your tree. I'm based on today's linux-next, while the other lpass macros uses the npl clock, the lpass vamacro bindings doesn't document the npl clock. And I found no fixes whatsover to add the npl clock to bindings. Neil > > Best regards, > Krzysztof >