From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tanya Brokhman" Subject: RE: [PATCH v12 4/8] usb:gadget: Add SuperSpeed support to the Gadget Framework Date: Tue, 24 May 2011 08:37:43 +0300 Message-ID: <00ec01cc19d4$b6c75660$24560320$@org> References: <1306132882-9668-1-git-send-email-tlinder@codeaurora.org> <1306132882-9668-5-git-send-email-tlinder@codeaurora.org> <20110523123135.GA10785@linutronix.de> <00eb01cc19d0$e526a9b0$af73fd10$@org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:37764 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972Ab1EXFgA (ORCPT ); Tue, 24 May 2011 01:36:00 -0400 In-Reply-To: Content-Language: en-us Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: 'Mike Frysinger' Cc: 'Sebastian Andrzej Siewior' , greg@kroah.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, balbi@ti.com, ablay@codeaurora.org, 'open list' > > > > Mike answered that you're right in your observation. I'm not familiar > with > > blackfin. Could you please elaborate on this? I understand that I > need to > > use put_unaligned_le16(), will do, but I would like to better > understand why > > and if there is a way to test this so that blackfin won't be broken. > > not all arches support unaligned accesses. or they do, but it's done > via (non-trivial) exception processing in software. req->buf is of > type void* and so presumably is not guaranteed to be aligned on a 2 > byte boundary. > -mike Thanks for the explanation, Mike! I'll update the patch. Best regards, Tanya Brokhman Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum