From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 566892F1FEA for ; Mon, 13 Oct 2025 08:19:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760343552; cv=none; b=T8WO6hPEaZSg0IJt7/6nJ+xzgqe91xIM674rxWEOyXLTrhMv5auEdaSunuH347+TeKoA/orsqUBNWalJQP+PDJt1hNDzqh0vGykB11C6UbUSok/7orwPWBhpK7a9QZYzfJUm/OEC5gVPUFf7ro9lmZ6KapqTQ8ugUbjxHJvIXwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760343552; c=relaxed/simple; bh=l71zOi8Iii2rT5j9IBt2SrlxYshazF9y0u6uvVNTzAk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DuNWx28HOkUHf0EzFtjHc9LzA9KcOo7+e2dQhcYc+NfCiwLlj7hIWTPWk1esSk59KJq7FDN/TwAKZR5Kee5CINwlqWl/qpF6hkAfIgjrmy8zJQvGxRNjKXf7AFoRB1nugRSTO0+6xWbHwZP9BHKjAaZr1SpzYQROf/NeB5kfVdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V6L3jrBT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V6L3jrBT" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59D2neA7022411 for ; Mon, 13 Oct 2025 08:19:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CnjUTiX3FGPPzQybFpvUaFsk3SaXgmCmOsQbRYEOBOo=; b=V6L3jrBTbTvHHEKo qD5U4eFHTxnbpsqXc4cOpzkuMCTQ5epNY9DjJjkGLJL1qr6r0S4OFd5EdlW4yKCJ WAgbjSG5zqOQzCbAlZaLfx2fgKrZnyWU+pe1FW+xPMm7zYUVcOgdInhv2VqIb1YE /8spKAq0l2LlOD9R/8xSGLcz+mrsa40WnUDOPuUFFaQf3Ot9tdR7CKRQMlJm9mEn F1LJmDAFnsYKeaU2FFa4xBj5MdtSGdU9dDsVNnLbD8CdNcWqDqVuiSzP0gCs0uuZ bJhuaktE8ndnYcXHi0xu6Klfu6NXf7VeX39SjgEj+cfOzKXJfxzJcj7ggFw+6AUZ TM5Rlg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49qgh63ptb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 13 Oct 2025 08:19:08 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-853f011da26so282664385a.0 for ; Mon, 13 Oct 2025 01:19:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760343547; x=1760948347; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CnjUTiX3FGPPzQybFpvUaFsk3SaXgmCmOsQbRYEOBOo=; b=PadKA4dlu9ajI8mYswgw3rkA2tnGYBWH5zds9og+bLDNOBe6yBNqfLiMVj8Jh7q5+s VI1LpG5BQ20ExtZTRmcUSZctEEk2w9q7GBz1yjIfQvpTfD/4XnpeK683y3HucDjY3L6H kgaQ/cnnu38fUQi/VYYorxysVqRuVoKcRyC2CsU478p0E8f7g2GcOWwbONGJAPCJoLmO SYdCc+hcfUZNUp2Gc5tF9KaFP8h2nIV2lVg8zENvmxeApPiUR3X9xk7kHqQekuc7uZKz zphoDUR3ysJNcQ97xtGRYOMMJL73O2WrqWso/9RDVfQsaRvD6r0uJsFL1TLxJMT5MHTA VPzQ== X-Forwarded-Encrypted: i=1; AJvYcCWEV0larVy+w/LpfZOeSsNfdZMdLLoFJkt0DzI8jy1gV4qBNMYr+sQpLev4lGEDpDlP7MGcvTGUsR0h2Rbt@vger.kernel.org X-Gm-Message-State: AOJu0YyEJbyASRCpnxzlz+yKvOVYlbYggPAqA8Fl4teVbTEkKwBHkh4A aTghyp4C52sJe/TyuPKFpWPIcBFom5tMwjhL4aSCHM5HiAZaR86nmas7pNmEeoQSTSbT4rDo+dY 7ndJSLdgHG+8PQTBTifeQVtH/LL7MuWi62H+wEJrEpntQDB5mH6dItszT0IXkDL6H/3Tv X-Gm-Gg: ASbGncsaoi8jpbbecTCYqehpa6Zcrg+bAz6SqMscwWSNZgwrxHswYALiurS+o7E97ht 6pXPBOJRsBIYemNa19qWDStK2MYh9L/YGV6T/nhYdcHdnT09MVs9DROTg3H1B4XyDu25X7WW/BU msZWpUVcD0fpQQWLNTAvnnDxM7+lQ1lK8V3qF0TozU0TlHFC5z1kkBU1hAw9lK8IQXfqHZnURVv bI+FZYxE0saLcwvXmsoaDlTS35fH1ZwLY2Eei0/lJzQXTEOkhaaZH9w40Zo7coN1UgpF09x64HX 0wAIO9nLb+Tc2NINaS6Yq8jFMQdDmWcOp3vZ4s2xwk+oSQ6/Gyvy7qnHsZO5CmbmnRO/0243DxN idp3uW9NIoW0S0PlbPBn3Sw== X-Received: by 2002:a05:620a:711c:b0:85f:a278:78bf with SMTP id af79cd13be357-8834ff909f1mr2008313785a.3.1760343547284; Mon, 13 Oct 2025 01:19:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4znKrO6qzvVeWk9uZKKfQVBsm8qhDDyjnyj9kOQFewTkZRDPaivS5qv0Ack9eGJHz4piu7Q== X-Received: by 2002:a05:620a:711c:b0:85f:a278:78bf with SMTP id af79cd13be357-8834ff909f1mr2008311885a.3.1760343546780; Mon, 13 Oct 2025 01:19:06 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b55d67d5c2bsm873147966b.37.2025.10.13.01.19.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Oct 2025 01:19:06 -0700 (PDT) Message-ID: <01122bf2-7f8c-4d93-9557-c625b4eac631@oss.qualcomm.com> Date: Mon, 13 Oct 2025 10:19:03 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/9] arm64: dts: qcom: ipq5424: Add QPIC SPI NAND controller support To: Md Sadre Alam , broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, vkoul@kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org Cc: quic_varada@quicinc.com References: <20251008090413.458791-1-quic_mdalam@quicinc.com> <20251008090413.458791-5-quic_mdalam@quicinc.com> <911ee444-25a9-a645-d14f-72fc239e5eb7@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <911ee444-25a9-a645-d14f-72fc239e5eb7@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=H/zWAuYi c=1 sm=1 tr=0 ts=68ecb5fc cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=COk6AnOGAAAA:8 a=OlpJZY4RW8OWQeam8GsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDExMDAyNiBTYWx0ZWRfX7BXx6OlfVzRj WVcTfg56J34ZcsjfKESnuCp37zMbpO8Jn9nM4yeHrGpUEkpnLvvOsZ1+xGbpKffY80jvrm98QCk C2Q4dDaS8/jPpDjuHBVIz+hcZxz53lWaSuvbR1toLy/XAuldqYkRtuoqypGViatA5dYW6tZKv9G kgwZH8FvZT0kn191l9DnbqKq3tYWfWU7BsovErHGp4bmnelmFDq5JePCxb+KblZtAHys7ktX1Hc War6wACKRBaydC6RpfO83FBTDW39ZgTwXz9Ans7q995BUVE1qwvePWuKshX0ah71Qdtu9VhU3Pe 0buCosw7S6kW6WIRfAQPuNNBwVE6+W/enVUvIkdMh+eJcWGDK9fB022ICjWGESItwCua7loc+Rx RIha9SKLBwkenzzaVmIUaTU5qPkHVw== X-Proofpoint-ORIG-GUID: J44k8e6IoHjB99L9KMWRcIuCtqbW454z X-Proofpoint-GUID: J44k8e6IoHjB99L9KMWRcIuCtqbW454z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-13_03,2025-10-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 clxscore=1015 impostorscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510110026 On 10/13/25 8:10 AM, Md Sadre Alam wrote: > > > On 10/8/2025 6:00 PM, Konrad Dybcio wrote: >> On 10/8/25 11:04 AM, Md Sadre Alam wrote: >>> Add device tree nodes for QPIC SPI NAND flash controller support >>> on IPQ5424 SoC. >>> >>> The IPQ5424 SoC includes a QPIC controller that supports SPI NAND flash >>> devices with hardware ECC capabilities and DMA support through BAM >>> (Bus Access Manager). >>> >>> Signed-off-by: Md Sadre Alam >>> --- [...] >> >>> +            dmas = <&qpic_bam 0>, >>> +                   <&qpic_bam 1>, >>> +                   <&qpic_bam 2>; >>> +            dma-names = "tx", "rx", "cmd"; >>> +            status = "disabled"; >> >> Is there anything preventing us from enabling both these nodes by >> default on all boards (maybe secure configuration or required >> regulators)? > We can't enable NAND by default in the common DTSI because the GPIOs are shared between eMMC and NAND.The decision to enable NAND must be made at the board-specific level, depending on the flash type used on that > particular board or RDP.Enabling it globally could lead to conflicts on platforms where eMMC is present. Right, thanks Konrad