From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tanya Brokhman" Subject: RE: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter Date: Tue, 7 Jun 2011 07:55:14 +0300 Message-ID: <014201cc24cf$1b3414d0$519c3e70$@org> References: <1307360469-29120-10-git-send-email-tlinder@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:40020 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988Ab1FGEzW (ORCPT ); Tue, 7 Jun 2011 00:55:22 -0400 In-Reply-To: Content-Language: en-us Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: 'Alan Stern' Cc: greg@kroah.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, balbi@ti.com, ablay@codeaurora.org, 'open list' > > You might want to print out some kind of error message if the user > specifies is_super_speed = True and is_high_speed = False. > I thought about that as well. Even added it but removed at the last minute :) I encountered quite a few places in the code where some error message to the user is really needed but is missing so my impression was that it's best to keep the printks to a minimum. Isn't that the general approach? IMO, in this particular case informing the user isn't a "must". If you feel strongly about it I can add the message. Thanks, Tanya Brokhman --- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.