From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C8E215CD7C for ; Wed, 10 Apr 2024 13:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712755771; cv=none; b=gLFVOkhg0zUZSHej6TjWKW9IRhaQYySKU3ye9Fmp0P3VGRuWdxvdlXniNdnBr3t71Ffu7bPlG6t2H8Ds0R/9yJGftGWzFdcJp/NS37atKPptQc2ZzxbNH0cQ9Ar92Ps0ed+tk9eEzszhNDVng/0ZBSm8vm5+gYVrv9zLt80kuv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712755771; c=relaxed/simple; bh=YVgwftwVY6+BzEoBnedEFymcgC78+dUg2rmNRT1jEhs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R2lzdFs0pM4g8r8YC/FrZ+dCrp6fJ6uD5M2LIaH440KE+7xcPXzXP7g324qPJnqsTFoFnhBWL4OIbCssGIh6zpCw99m1wq5K7UuFE4csKy1rrozoGQv3lANV0gkzQI17m/4pV6th92FIS6oC2oMlMn2hFREFYErzwv1I0hq+lrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Dk+M56r3; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Dk+M56r3" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-417c4bd59b3so1316095e9.2 for ; Wed, 10 Apr 2024 06:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712755768; x=1713360568; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c49iPDK4U7F9bhFe9uHIwDW1cTsFEeQxM7cJjpTwJmo=; b=Dk+M56r395GypZCQ0fB063i6N8kePS4UUx7Hlf8yTjRoQv2OvzHZzTxlEvk0YWKHEq AaB+h0MdFBt8/VrOPiUgFw+PSbZmNInzXq664g7dF40ZzU0mNP5qMFPc4JjXTJf/LTIC aK7HPN2muq7Wnu5e5KROoQPvVeXXalM672alIJI9o+giSSadVtvk2371cBnYmZCXIA80 emptMF9BgqIeQ+riQ9/gGs1zXUaTXkcixL+cYlqQ8ZPbFYVcyC1XlU4tEuGqsW4eVgRL QX2qZ3m9tfjyb6QesjYY/nLHneg37pb/ALhxEi1s2YeaTEaD188pP8Zph9J0Ls2NH6Y/ mIcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712755768; x=1713360568; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c49iPDK4U7F9bhFe9uHIwDW1cTsFEeQxM7cJjpTwJmo=; b=qOYJ9DIIHle6xve13vbSVPmVyGmOsA2yo0ydZNNAO4HRUkFQKP+wTHUzMyKouARV6N mO8syZsP3tuYraeCOQHrEc+DNRSfUt2ixoVjYEdzyiGdXPG37W157DhTHnaAWXPQoSC6 zSflwpXIWhNJWVWODvUWK+0Albua05btRnYkjwth4Q3S0BI78Yp89fAi3tQluLnH7Sg3 rm3fAUdO+Nh8n2rByZqT1KRmejlOEcbQfIbabVIBuGm8l+Z+3roCJitMMiQD03UFdmtv O2SIkI+JjpI3hYKKeNAytPAGds2Jki2FUC7/WLSQmL/BJ63OP5Yz8brKOx+QK93ODf3B Y0uA== X-Forwarded-Encrypted: i=1; AJvYcCXNOG9ImNpiJK1HO5Wh4qc4NzLVtM0rsGzdWwWNmxWw+5/ITjGZV331qC3e/YtgjS/g9jGOIFMLJI1yNiLQNbjGnlN8+XK2BpeJvu1psg== X-Gm-Message-State: AOJu0Yw5irITRuFOINVN8ifmgfV7S3cLfus/koXWM2aXbD9O1Ft8HTCk Jb8wAS0shTk3C/ayev95oKBLaVoEaDmJzEwXBKW68drsBmw30xNv9KKEAgvxXgI= X-Google-Smtp-Source: AGHT+IEBCgd8KCtzGqcKZ/SY7hho9AXrqRJJTRZDuq1uMrfp0XF6kst7APRW+ta1RRPhszH4q6y+jA== X-Received: by 2002:a05:600c:294c:b0:416:4973:4d59 with SMTP id n12-20020a05600c294c00b0041649734d59mr2118786wmd.12.1712755767939; Wed, 10 Apr 2024 06:29:27 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id m18-20020a05600c3b1200b0041668162b45sm2289683wms.26.2024.04.10.06.29.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 06:29:27 -0700 (PDT) Message-ID: <014f64ca-fed4-4a44-bb61-154a2d6cd268@linaro.org> Date: Wed, 10 Apr 2024 14:29:26 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC WIP PATCH] venus: add qcom,no-low-power property To: Marc Gonzalez , Vikash Garodia , Stanimir Varbanov , Dmitry Baryshkov , Konrad Dybcio Cc: linux-media , MSM , Bjorn Andersson , Jeffrey Hugo , Mauro Carvalho Chehab , Pierre-Hugues Husson , Marijn Suijten References: <0843621b-386b-4173-9e3c-9538cdb4641d@freebox.fr> <6342e92d-eed0-45c2-8f04-3779aa2e521d@freebox.fr> <4ab95e87-c912-469b-b8d4-be0cf0e4710b@linaro.org> <33382ecb-8a73-4d2f-96b1-8048df7a6414@freebox.fr> <3914555d-3c89-a5c5-2906-0bd24d0bf735@quicinc.com> <72741d2e-5165-4505-b079-d7b5d1491888@freebox.fr> <21b833cf-61c3-4fb5-8c55-492aac0fd3b6@freebox.fr> <8170522f-b813-19a4-3f85-f2880809d9a5@quicinc.com> <09bc9231-0e59-4cb2-a05f-02e2fcaf3d15@linaro.org> <02a32387-1a30-44cd-b552-6e47023b997d@freebox.fr> <8b9cc46d-4267-43fb-b2be-f5996566a349@linaro.org> <0159169f-8da9-4ca8-a427-8160a9b09a9c@freebox.fr> <651b56f2-1261-43b9-a078-adde5da555e7@freebox.fr> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <651b56f2-1261-43b9-a078-adde5da555e7@freebox.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/04/2024 14:18, Marc Gonzalez wrote: > On 10/04/2024 15:14, Bryan O'Donoghue wrote: > >> On 10/04/2024 13:23, Marc Gonzalez wrote: >> >>> FWIW, I get the same behavior with 854x480 and 2560x1440: >>> >>> 1) If mpv runs with '--length=N' (play only part of the file) >>> then mpv exits cleanly, with no kernel messages. >> >> On -next ? >> >> I think you mentioned before you were doing your work on an older kernel >> and forward porting patches ? > > I work on v6.9-rc1 > Is -next that much different in that area? No, I thought you were on a 4.x kernel for some reason. 6.9.x is fine > >>> 2) If mpv plays the entire file, then mpv hangs at the end >>> (needs CTRL-C to exit) and driver prints to kernel: >>> [68643.935888] qcom-venus cc00000.video-codec: session error: event id:1001 (deadb000), session id:79d42000 >>> [68643.935995] qcom-venus-decoder cc00000.video-codec:video-decoder: dec: event : 1001 >> >> Hmm >> >> #define HFI_ERR_SESSION_FATAL 0x1001 >> >> Something is causing the firmware to return this packet to you. >> >> Probably worth tracing the last five messages sent by the firmware prior >> to that to see if we can root-cause. > > I'm not seeing anything from the FW in dmesg. > I suppose I need to enable DEBUG in various places? --- a/drivers/media/platform/qcom/venus/hfi_venus.c +++ b/drivers/media/platform/qcom/venus/hfi_venus.c @@ -129,7 +129,8 @@ struct venus_hfi_device { u8 dbg_buf[IFACEQ_VAR_HUGE_PKT_SIZE]; }; -static bool venus_pkt_debug; +#define DEBUG +static bool venus_pkt_debug = true; We can add additional flags - it'd be nice if these could be controlled by a module prameter or debugfs trigger - to this venus_fw_debug = 0x2f; But start with the default mask = int venus_fw_debug = HFI_DEBUG_MSG_ERROR | HFI_DEBUG_MSG_FATAL --- bod