From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tanya Brokhman" Subject: RE: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd Date: Wed, 25 May 2011 12:26:08 +0300 Message-ID: <015801cc1abd$ca534e20$5ef9ea60$@org> References: <011d01cc19ff$616055c0$24210140$@org> <013201cc1a96$bdda7910$398f6b30$@org> <20110525092124.GI14556@legolas.emea.dhcp.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110525092124.GI14556-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org> Content-Language: en-us Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: balbi-l0cyMroinI0@public.gmane.org Cc: 'Alan Stern' , 'Sarah Sharp' , greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ablay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, 'open list' List-Id: linux-arm-msm@vger.kernel.org > > As I mentioned, updating all of the gadget drivers will take a long > > time and I don't fill confident enough doing since I'm not familiar > > with all of them and don't have the ability to test each of them > > properly. I can add SS descriptors to f_mass_storage, g_zero if it > > helps and of course f_uasp already has them. > > I'm a bit confused by this actually... We've been discussing this > > patch series for quite a while now and I got the impression that > > except for some minor comments you were all for excepting this. Was I > > wrong or am I misunderstanding the above? > > In any case, I don't feel that adding SS support for the Gadget > > framework should be delayed until all gadget drivers add SS > > descriptors because this patch series will give the developers the > > ability to test these gadget drivers at SS. Also, several developers > > addressed me offline with questions on this series so I know people > > are using it in their work. And of course we do :) > > just remove the hunk which changes composite.c speed field and it > should all be ok :-) > But that's why we added the feature flag. Isn't leaving it FALSE the same as removing the part that updates gadget speed? It is protected with #ifdef. Best regards, Tanya Brokhman Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html