From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tanya Brokhman" Subject: RE: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter Date: Tue, 7 Jun 2011 21:30:46 +0300 Message-ID: <016d01cc2541$0bfa5980$23ef0c80$@org> References: <014201cc24cf$1b3414d0$519c3e70$@org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:7392 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751749Ab1FGSbD (ORCPT ); Tue, 7 Jun 2011 14:31:03 -0400 In-Reply-To: Content-Language: en-us Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: 'Alan Stern' Cc: greg@kroah.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, balbi@ti.com, ablay@codeaurora.org, 'open list' > > I thought about that as well. Even added it but removed at the last > minute > > :) I encountered quite a few places in the code where some error > message to > > the user is really needed but is missing > > What other places? There is very little the user has to do with > dummy-hcd -- really nothing more than setting the module parameters. I'm not talking about dummy_hcd. It was a general comment about the gadget code. I can't give you an example from the top of my head... > > so my impression was that it's best > > to keep the printks to a minimum. Isn't that the general approach? > IMO, in > > this particular case informing the user isn't a "must". If you feel > strongly > > about it I can add the message. > > IMO the driver should print an error message and fail to load if there > are contradictory module parameters. > Well, I can add the error message but I think that as far as dummy_hcd is concerned failing it's loading is a bit harsh, isn't it? I mean, this is a type of user error that can be fixed so why not fix it and just notify the user of what was done? Thanks, Tanya Brokhman --- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.