From: "Cheng Jiang (IOE)" <quic_chejiang@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
"Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
Rocky Liao <quic_rjliao@quicinc.com>
Cc: <linux-bluetooth@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<quic_jiaymao@quicinc.com>, <quic_shuaz@quicinc.com>,
<quic_zijuhu@quicinc.com>, <quic_mohamull@quicinc.com>
Subject: Re: [PATCH v3 2/3] Bluetooth: qca: Expand firmware-name to load specific nvm and rampatch
Date: Fri, 6 Dec 2024 10:42:24 +0800 [thread overview]
Message-ID: <0176828a-56c5-4a26-9014-4e9efd2d5efd@quicinc.com> (raw)
In-Reply-To: <ce3237d3-e281-4534-ae40-f6762d25a690@kernel.org>
Hi Krzysztof,
On 12/5/2024 10:37 PM, Krzysztof Kozlowski wrote:
> On 05/12/2024 11:22, Cheng Jiang wrote:
>> @@ -2309,8 +2322,10 @@ static int qca_serdev_probe(struct serdev_device *serdev)
>> qcadev->serdev_hu.serdev = serdev;
>> data = device_get_match_data(&serdev->dev);
>> serdev_device_set_drvdata(serdev, qcadev);
>> - device_property_read_string(&serdev->dev, "firmware-name",
>> - &qcadev->firmware_name);
>> + of_property_read_string_index(serdev->dev.of_node, "firmware-name",
>> + 0, &qcadev->firmware_name);
>> + of_property_read_string_index(serdev->dev.of_node, "firmware-name",
>> + 1, &qcadev->rampatch_name);
> No, that's entirely different API. You are not supposed to drop here
> device-API and revert to OF. It is not a related change, either.
>
Ack, Will change this in next version.
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2024-12-06 2:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 10:22 [PATCH v3 0/3] Expand firmware-name property to load specific Cheng Jiang
2024-12-05 10:22 ` [PATCH v3 1/3] dt-bindings: net: bluetooth: qca: Expand firmware-name property Cheng Jiang
2024-12-05 11:18 ` Rob Herring (Arm)
2024-12-06 3:06 ` Cheng Jiang (IOE)
2024-12-05 14:36 ` Krzysztof Kozlowski
2024-12-06 3:05 ` Cheng Jiang (IOE)
2024-12-05 10:22 ` [PATCH v3 2/3] Bluetooth: qca: Expand firmware-name to load specific nvm and rampatch Cheng Jiang
2024-12-05 12:00 ` Dmitry Baryshkov
2024-12-06 3:05 ` Cheng Jiang (IOE)
2024-12-06 8:34 ` Dmitry Baryshkov
2024-12-09 9:03 ` Cheng Jiang (IOE)
2024-12-09 10:49 ` Dmitry Baryshkov
2024-12-09 13:59 ` Cheng Jiang (IOE)
2024-12-09 16:04 ` Dmitry Baryshkov
2024-12-10 2:00 ` Cheng Jiang (IOE)
2024-12-10 11:12 ` Dmitry Baryshkov
2024-12-10 15:03 ` Cheng Jiang (IOE)
2024-12-05 14:02 ` kernel test robot
2024-12-05 14:37 ` Krzysztof Kozlowski
2024-12-06 2:42 ` Cheng Jiang (IOE) [this message]
2024-12-05 10:22 ` [PATCH v3 3/3] arm64: dts: qcom: sa8775p-ride: Add firmware-name in BT node Cheng Jiang
2024-12-05 12:13 ` Dmitry Baryshkov
2024-12-06 2:39 ` Cheng Jiang (IOE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0176828a-56c5-4a26-9014-4e9efd2d5efd@quicinc.com \
--to=quic_chejiang@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=quic_bgodavar@quicinc.com \
--cc=quic_jiaymao@quicinc.com \
--cc=quic_mohamull@quicinc.com \
--cc=quic_rjliao@quicinc.com \
--cc=quic_shuaz@quicinc.com \
--cc=quic_zijuhu@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox