From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tanya Brokhman" Subject: RE: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter Date: Tue, 7 Jun 2011 21:47:59 +0300 Message-ID: <018a01cc2543$7273a5c0$575af140$@org> References: <016d01cc2541$0bfa5980$23ef0c80$@org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:41897 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754650Ab1FGSsT (ORCPT ); Tue, 7 Jun 2011 14:48:19 -0400 In-Reply-To: Content-Language: en-us Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: 'Alan Stern' Cc: greg@kroah.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, balbi@ti.com, ablay@codeaurora.org, 'open list' > > I'm not talking about dummy_hcd. It was a general comment about the > gadget > > code. I can't give you an example from the top of my head... > > Oh. Well, if you're writing new code and you come across a place where > an error message really is needed, you should add the error message. Ok, I'll take that into consideration. Since I'm new here I was "afraid" to add any changes that are not really required :) > But if the parameters are contradictory, you don't know _how_ to fix > it. If is_super_speed is True and is_high_speed is False, did the user > want to add SuperSpeed support or to remove high-speed support? > > Besides, the best (i.e., easiest and most likely to be correct) way of > fixing the error is for the user to issue the modprobe command again, > with the correct parameters this time. Therefore the driver should > fail to load, so that the modprobe can be reissued with no need to do > rmmod first. > Ok, agreed. I'll update the patch. Thanks, Tanya Brokhman --- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.