From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Mao Jinlong <quic_jinlmao@quicinc.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/5] coresight: Add remote etm support
Date: Thu, 24 Apr 2025 22:32:44 +0200 [thread overview]
Message-ID: <01bb7183-eb33-4b9b-b73a-e7e3622bf9dd@oss.qualcomm.com> (raw)
In-Reply-To: <20250424115854.2328190-5-quic_jinlmao@quicinc.com>
On 4/24/25 1:58 PM, Mao Jinlong wrote:
> The system on chip (SoC) consists of main APSS(Applications
> processor subsytem) and additional processors like modem, lpass.
> Coresight remote etm(Embedded Trace Macrocell) driver is for
> enabling and disabling the etm trace of remote processors. It
> uses QMI interface to communicate with remote processors' software
> and uses coresight framework to configure the connection from
> remote etm source to TMC sinks.
>
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
[...]
> +/*
> + * Element info to descrbe the coresight_set_etm_req_msg_v01 struct
> + * which is used to encode the request.
> + */
> +static struct qmi_elem_info coresight_set_etm_req_msg_v01_ei[] = {
> + {
> + .data_type = QMI_UNSIGNED_4_BYTE,
There's one tab too many here and in other declarations (make sure your
tab width is set to 8 spaces)
I'll try to read into the actual code a bit later
Konrad
next prev parent reply other threads:[~2025-04-24 20:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 11:58 [PATCH v5 0/5] coresight: Add remote etm support Mao Jinlong
2025-04-24 11:58 ` [PATCH v5 1/5] dt-bindings: arm: Add CoreSight QMI component description Mao Jinlong
2025-04-24 20:30 ` Konrad Dybcio
2025-07-10 11:03 ` Jinlong Mao
2025-07-11 10:11 ` Konrad Dybcio
2025-07-11 11:03 ` Suzuki K Poulose
2025-04-24 11:58 ` [PATCH v5 2/5] coresight: Add coresight QMI driver Mao Jinlong
2025-04-25 19:58 ` Konrad Dybcio
2025-04-26 5:18 ` kernel test robot
2025-04-24 11:58 ` [PATCH v5 3/5] dt-bindings: arm: Add qcom,qmi-id for remote etm Mao Jinlong
2025-06-18 3:16 ` Bjorn Andersson
2025-06-26 8:04 ` Jinlong Mao
2025-04-24 11:58 ` [PATCH v5 4/5] coresight: Add remote etm support Mao Jinlong
2025-04-24 20:32 ` Konrad Dybcio [this message]
2025-05-07 11:24 ` kernel test robot
2025-04-24 11:58 ` [PATCH v5 5/5] arm64: dts: qcom: msm8996: Add coresight qmi node Mao Jinlong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01bb7183-eb33-4b9b-b73a-e7e3622bf9dd@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=quic_jinlmao@quicinc.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox