Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Trilok Soni <quic_tsoni@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Tengfei Fan <quic_tengfan@quicinc.com>, <will@kernel.org>,
	<robin.murphy@arm.com>, <joro@8bytes.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<agross@kernel.org>, <andersson@kernel.org>,
	<konrad.dybcio@linaro.org>, <catalin.marinas@arm.com>
Cc: <geert+renesas@glider.be>, <arnd@arndb.de>,
	<neil.armstrong@linaro.org>, <nfraprado@collabora.com>,
	<rafal@milecki.pl>, <peng.fan@nxp.com>,
	<linux-arm-kernel@lists.infradead.org>, <iommu@lists.linux.dev>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <quic_shashim@quicinc.com>,
	<quic_kaushalk@quicinc.com>, <quic_tdas@quicinc.com>,
	<quic_tingweiz@quicinc.com>, <quic_aiquny@quicinc.com>,
	<kernel@quicinc.com>
Subject: Re: [PATCH v2 8/8] arm64: defconfig: enable interconnect and pinctrl for SM4450
Date: Fri, 15 Sep 2023 19:21:39 -0700	[thread overview]
Message-ID: <01c020ae-a019-e4eb-14cb-64503bde05a6@quicinc.com> (raw)
In-Reply-To: <b7398390-23bc-467c-5b83-411110d60f43@linaro.org>

On 9/15/2023 4:29 AM, Krzysztof Kozlowski wrote:
> On 15/09/2023 13:18, Tengfei Fan wrote:
>>
>>
>> 在 9/15/2023 5:16 PM, Krzysztof Kozlowski 写道:
>>> On 15/09/2023 11:12, Tengfei Fan wrote:
>>>>
>>>>
>>>> 在 9/15/2023 3:21 PM, Krzysztof Kozlowski 写道:
>>>>> On 15/09/2023 04:15, Tengfei Fan wrote:
>>>>>> Add the SM4450 interconnect and pinctrl drivers as built-in for
>>>>>> support the Qualcomm SM4450 platform to boot to uart shell.
>>>>>>
>>>>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>>>>> ---
>>>>>>    arch/arm64/configs/defconfig | 2 ++
>>>>>>    1 file changed, 2 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>>>>> index ec59174b14db..e91993de865e 100644
>>>>>> --- a/arch/arm64/configs/defconfig
>>>>>> +++ b/arch/arm64/configs/defconfig
>>>>>> @@ -598,6 +598,7 @@ CONFIG_PINCTRL_SC8280XP=y
>>>>>>    CONFIG_PINCTRL_SDM660=y
>>>>>>    CONFIG_PINCTRL_SDM670=y
>>>>>>    CONFIG_PINCTRL_SDM845=y
>>>>>> +CONFIG_PINCTRL_SM4450=y
>>>>>>    CONFIG_PINCTRL_SM6115=y
>>>>>>    CONFIG_PINCTRL_SM6125=y
>>>>>>    CONFIG_PINCTRL_SM6350=y
>>>>>> @@ -1500,6 +1501,7 @@ CONFIG_INTERCONNECT_QCOM_SC7280=y
>>>>>>    CONFIG_INTERCONNECT_QCOM_SC8180X=y
>>>>>>    CONFIG_INTERCONNECT_QCOM_SC8280XP=y
>>>>>>    CONFIG_INTERCONNECT_QCOM_SDM845=y
>>>>>> +CONFIG_INTERCONNECT_QCOM_SM4450=y
>>>>>
>>>>> Why it cannot be =m?
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>>
>>>> Hi Krzysztof,
>>>> Because system haven't capacity of loading ko files at this time on
>>>> SM4450 platform, so setting to "Y".
>>>
>>> Hm? System has this capability. All systems have. What is so different
>>> on SM4450 comparing to everything else we have here?
>>>
>>> No, this should be =m and you need to fix your system.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> Hi Krzysztof,
>> Find new way which can load ko files on SM4450 platform, still need use 
>> "Y", because of some other modules have dependence to these two config, 
>> like scm, smmu module drivers, uart shell console cannot be got if set 
>> to "m".
> 
> That's what I am asking, which device exactly needs it.
> 
>>
>> Also do test for setting these two config to "m" on SM8450 platform, get 
>> uart shell consle failed if so setting.
> 
> Yeah, this we know, I did this. I am asking about SM4450.

Why we have =m requirement when other drivers above are =Y?. Can we confirm
w/ Georgi? I am not aware that Interconnect drivers needs to be =m only.

CONFIG_INTERCONNECT_QCOM_SC8180X=y
CONFIG_INTERCONNECT_QCOM_SC8280XP=y
CONFIG_INTERCONNECT_QCOM_SDM845=y

-- 
---Trilok Soni


  reply	other threads:[~2023-09-16  2:23 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15  2:15 [PATCH v2 0/8] soc: qcom: Add uart console support for SM4450 Tengfei Fan
2023-09-15  2:15 ` [PATCH v2 1/8] dt-bindings: firmware: document Qualcomm SM4450 SCM Tengfei Fan
2023-09-15  2:15 ` [PATCH v2 4/8] dt-bindings: arm-smmu: Add compatible for SM4450 SoC Tengfei Fan
2023-09-15  7:11   ` Krzysztof Kozlowski
2023-09-15  7:15     ` Tengfei Fan
2023-09-15  9:10       ` Krzysztof Kozlowski
2023-09-15  8:52     ` Tengfei Fan
2023-09-15  9:10       ` Krzysztof Kozlowski
2023-09-15  2:15 ` [PATCH v2 2/8] dt-bindings: mfd: qcom,tcsr: Add compatible for sm4450 Tengfei Fan
2023-09-15  2:15 ` [PATCH v2 3/8] dt-bindings: interrupt-controller: qcom,pdc: document qcom,sm4450-pdc Tengfei Fan
2023-09-15  2:15 ` [PATCH v2 4/8] dt-bindings: arm-smmu: Add compatible for SM4450 SoC Tengfei Fan
2023-09-15  7:12   ` Krzysztof Kozlowski
2023-09-15  2:15 ` [PATCH v2 5/8] arm64: dts: qcom: sm4450: Add apps_rsc and cmd_db node Tengfei Fan
2023-09-20  3:49   ` Bjorn Andersson
2023-09-22  1:16     ` Tengfei Fan
2023-09-15  2:15 ` [PATCH v2 6/8] arm64: dts: qcom: sm4450: Add RPMH and Global clock controller Tengfei Fan
2023-09-15  7:22   ` Krzysztof Kozlowski
2023-09-18 10:34     ` Tengfei Fan
2023-09-18 11:54       ` Krzysztof Kozlowski
2023-09-15  2:15 ` [PATCH v2 7/8] arm64: dts: qcom: add uart console support for SM4450 Tengfei Fan
2023-09-15  7:14   ` Krzysztof Kozlowski
2023-09-15 12:12   ` Konrad Dybcio
2023-09-18 10:40     ` Tengfei Fan
2023-09-20  3:47   ` Bjorn Andersson
2023-09-20  5:46     ` Tengfei Fan
2023-09-15  2:15 ` [PATCH v2 8/8] arm64: defconfig: enable interconnect and pinctrl " Tengfei Fan
2023-09-15  7:21   ` Krzysztof Kozlowski
2023-09-15  9:12     ` Tengfei Fan
2023-09-15  9:16       ` Krzysztof Kozlowski
2023-09-15 11:18         ` Tengfei Fan
2023-09-15 11:29           ` Krzysztof Kozlowski
2023-09-16  2:21             ` Trilok Soni [this message]
2023-09-16  2:25               ` Trilok Soni
2023-09-16 15:13                 ` Georgi Djakov
2023-09-16 20:32                   ` Krzysztof Kozlowski
2023-09-16 22:55                     ` Georgi Djakov
2023-09-17  7:35                       ` Krzysztof Kozlowski
2023-09-18  0:53                         ` Tengfei Fan
2023-09-16 20:30               ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01c020ae-a019-e4eb-14cb-64503bde05a6@quicinc.com \
    --to=quic_tsoni@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=kernel@quicinc.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=nfraprado@collabora.com \
    --cc=peng.fan@nxp.com \
    --cc=quic_aiquny@quicinc.com \
    --cc=quic_kaushalk@quicinc.com \
    --cc=quic_shashim@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=quic_tengfan@quicinc.com \
    --cc=quic_tingweiz@quicinc.com \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox