From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tanya Brokhman" Subject: RE: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd Date: Wed, 25 May 2011 14:33:18 +0300 Message-ID: <01c601cc1acf$8e28e920$aa7abb60$@org> References: <013201cc1a96$bdda7910$398f6b30$@org> <20110525092124.GI14556@legolas.emea.dhcp.ti.com> <015801cc1abd$ca534e20$5ef9ea60$@org> <20110525092743.GK14556@legolas.emea.dhcp.ti.com> <018e01cc1ac0$2b09b040$811d10c0$@org> <20110525094902.GM14556@legolas.emea.dhcp.ti.com> <01a601cc1ac2$f0041a00$d00c4e00$@org> <20110525102945.GN14556@legolas.emea.dhcp.ti.com> <01b401cc1ac9$d1c57870$75506950$@org> <20110525112350.GP14556@legolas.emea.dhcp.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:31658 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751892Ab1EYLbi (ORCPT ); Wed, 25 May 2011 07:31:38 -0400 In-Reply-To: <20110525112350.GP14556@legolas.emea.dhcp.ti.com> Content-Language: en-us Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: balbi@ti.com Cc: 'Alan Stern' , 'Sarah Sharp' , greg@kroah.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, ablay@codeaurora.org, 'open list' Hi Felipe > > > --- > > > -*/ > > > > > > static struct usb_gadget_driver composite_driver = { > > > +#ifdef CONFIG_USB_GADGET_SUPERSPEED > > > + .speed = USB_SPEE_SUPER, > > > +#else > > > .speed = USB_SPEED_HIGH, > > > +#endif > > > > > > .unbind = composite_unbind, > > > > > > > I have no problem updating static struct usb_gadget_driver > > composite_driver as you suggested but it seems the same as updating > it > > @ usb_composite_probe()... > > still, you will have two places poking at the same field. It's better > to keep it at once, update only that and we will take your approach. > Ok so just to make sure I understand you correctly: You want me to remove the modification made to usb_composite_probe() and instead add: static struct usb_gadget_driver composite_driver = { +#ifdef CONFIG_USB_GADGET_SUPERSPEED + .speed = USB_SPEE_SUPER, +#else .speed = USB_SPEED_HIGH, +#endif .unbind = composite_unbind, And then you'll be ok with change? Or is there anything else? If this is it then I'm relieved :) and of course will update the code. Best regards, Tanya Brokhman Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum