From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: "Vladimir Zapolskiy" <vladimir.zapolskiy@linaro.org>,
"Barnabás Czémán" <barnabas.czeman@mainlining.org>,
"Robert Foss" <rfoss@kernel.org>,
"Todor Tomov" <todor.too@gmail.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Yassine Oudjana <y.oudjana@protonmail.com>
Subject: Re: [PATCH v2] media: qcom: camss: fix VFE pm domain off
Date: Fri, 29 Nov 2024 11:23:30 +0000 [thread overview]
Message-ID: <02029a14-3cc0-453e-b1ea-ec7dd30dbb33@linaro.org> (raw)
In-Reply-To: <d3a8d38c-9129-4fbd-8bd6-c91131d950ad@linaro.org>
On 29/11/2024 11:20, Vladimir Zapolskiy wrote:
> There should be no room for suppositions, the source code is open.
>
> If the described by you case is true, and vfe_pm_domain_on() fails,
> then vfe_pm_domain_off() shall not be called, otherwise that's the
> real problem and it shall be fixed instead of being veiled by the
> proposed change.
Maybe, maybe not I'd like to hear more from Barnabás on that, who is in
a position to replicate this bug.
---
bod
next prev parent reply other threads:[~2024-11-29 11:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 19:39 [PATCH v2] media: qcom: camss: fix VFE pm domain off Barnabás Czémán
2024-11-29 8:48 ` Vladimir Zapolskiy
2024-11-29 11:06 ` Bryan O'Donoghue
2024-11-29 11:20 ` Vladimir Zapolskiy
2024-11-29 11:23 ` Bryan O'Donoghue [this message]
2024-11-29 11:44 ` barnabas.czeman
2024-11-29 12:25 ` Bryan O'Donoghue
2024-11-29 13:46 ` barnabas.czeman
2024-11-29 22:08 ` Bryan O'Donoghue
2024-11-29 22:45 ` barnabas.czeman
2024-11-29 23:07 ` Bryan O'Donoghue
2024-11-29 23:52 ` barnabas.czeman
2024-11-30 21:48 ` Bryan O'Donoghue
2024-11-30 22:58 ` barnabas.czeman
2024-12-02 23:10 ` Bryan O'Donoghue
2024-12-03 1:02 ` barnabas.czeman
2024-12-03 16:49 ` Bryan O'Donoghue
2024-12-03 21:41 ` barnabas.czeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02029a14-3cc0-453e-b1ea-ec7dd30dbb33@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=barnabas.czeman@mainlining.org \
--cc=hverkuil@xs4all.nl \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox