From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB00E38DE1 for ; Tue, 30 Sep 2025 02:12:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759198359; cv=none; b=ZOErqcpJN1f6q8gZpcD7W7ZddgdkLahBNNuX/lL7bS11pgMy7rJWYCwTIV9nA+RKoKObR+a1bPkpGoEXISDCYfWZo6sV8Ui+gq9yYeV+eWZ5+YgO+dcahGGBtW6g7ufidpHl5zZSsOduBWm62/q9t+sebkT3rak75cvUuRHugT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759198359; c=relaxed/simple; bh=eLkWUXoCaCSYOJVRWYPyfUfBZa/KowRnoSnZfDqdakc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V58GQKfAd0T1EaJSce1pnTWcugyVyIoxN2+23zybksSDybGwpshFseS7lpUjH+pXihheivr/+JNQ00x2nW1Jbw/7qrmngBZulmzSlytwNf1KBDp8MLxoAvWQQassKEa+OVMDdT5vIosbSuq8LgLJSThpaXi7j0boOzI7o2hGy9w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DlOC+0+Q; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DlOC+0+Q" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58THZsvF007658 for ; Tue, 30 Sep 2025 02:12:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A6GRfmUtqPqpB2FJ5uC5Ju/FfBquJOIH9/NAMhzKqDU=; b=DlOC+0+QCke00+oo Z1y6h7KK6u+PDJaNyR5MpRq/fqM9eRTB1rXzISGmvMnUJQe2ttA5B1iwyxi10Hs1 i52EHXlbpMA5yrcgCMu43uy5jFCnEL/Sh+elyrslkSql0Th3xBPXrEs8iU+XCii6 zNe/o2I5/NvBvQLDUDYAcDADriObpVEaHjVGJddy75SjRDoiqNDahJKOoqf+BE+B Urs63IawyMritwOomk6NbdQOp5e7FqToIp7+MWmv2fSnmKzDl0VMiqRdnPx4LTd4 r1mVAlk25ihjsMos9tTZePjch3gHzKggxpsC0yPFvMseBFtvFypQlbJc4tIfzp/c kQU+DQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49e80tqd9s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 30 Sep 2025 02:12:36 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2681642efd9so41558815ad.2 for ; Mon, 29 Sep 2025 19:12:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759198355; x=1759803155; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A6GRfmUtqPqpB2FJ5uC5Ju/FfBquJOIH9/NAMhzKqDU=; b=aCGSjHmDcClLnKLqlwHbKB2DAEBEmcc24Y6OircuNljSO4E4meZXw0I1doso3xlf9k NVZ2k85WkRzFVX4XZ+QNUZpvpjQrlwB4dhVcGKsyfxHuPcMLVXGkB5r+YAc+arZp7MRu qfLo22TySlN7nJHmHl5yvyKRX5atN92GyEU7oPQeBgZpUbSkZC+o5Va2ja9Pqy2vXuj7 LfcIeQMIJL2Ze4gbbxthC9PLy8IeEz/ukkBg1XrGJg2dHhSZnTcigtXpkDJS8J4MS6r8 d7uvLxyw2EWAnFx5UBZYoGT5vHJOsh7ep3begafO/3pkrvSJLezQ55pBWXjWepAQmQIm MOfg== X-Forwarded-Encrypted: i=1; AJvYcCV0eSBZXSVozANxQJSFKubWRreuHxTzh48NEuWj3vT1limXD3CqoZ0w4Q2wkIavvlqBkys7q/xfVKKuGB6x@vger.kernel.org X-Gm-Message-State: AOJu0YypVuAYC6CfP4+kwKRA6DYvt0W4vZwtuCBg6+uaoOdAGYxbUV+n yoLlBDm/Xv+slsdROGXnS+LEWTFaJZvW/0ZmGmBd3oOoznuvpn/P7jMzkyetO65LcNgVpfHfnzy 7H3KbMaWFZJl0nKQr/D1OsLVdfgrcdKPL+jhhcZJv2z8yRD6lbHvNHU2F31QoCLOFr0T+ X-Gm-Gg: ASbGncs12PS0vVM4iNpGgSdY+5mNssJGgDRDmqp4Flu4aMLZH9iPO5aEexsmKhDbkdv iRgz/QlitDdCd3EHzv9gaOoZqKWgQMjH2YyZLatq3NC/fgvjd+BRHS1+f1/+QpxXmfQq3Tu+r/q Ywy2m+IHxDBPAIeuYfaZTLHbMmkVMRrkJG9XZufOJPbCiK3JMe9nYNoJTKcFthrZJ/H4+Vgpep6 2491bDxryzCypZL0Pga9ahw/nn3mmqp4xZKWxSLx03EXjYSimNxMXyZW+xQ2TcqZC0wyI8z4upi SXScyCJPw29o+q6cOmVYAmtqjlEX0xEyjGW2KWFsucpKiOF8+sIH/QqfHrNo5nC3h9VetyjclAH FHpz8viMIknlSzFinkw7cUaCBbPzKxQGlgh92MJh4 X-Received: by 2002:a17:903:41cf:b0:266:3098:666 with SMTP id d9443c01a7336-27ed4a2d5bamr204898305ad.32.1759198355470; Mon, 29 Sep 2025 19:12:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+ZBdJe/uUt5YHPNRGt3iXlQ4rJR0AJ3N2YKDWJWwd3GJoVy+Kj5yMLslYVxmL6MZwLGY4fw== X-Received: by 2002:a17:903:41cf:b0:266:3098:666 with SMTP id d9443c01a7336-27ed4a2d5bamr204897885ad.32.1759198354886; Mon, 29 Sep 2025 19:12:34 -0700 (PDT) Received: from [10.133.33.234] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-27ed6ac9ae0sm144096465ad.140.2025.09.29.19.12.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Sep 2025 19:12:34 -0700 (PDT) Message-ID: <0209a062-2763-4e50-adfa-3cbdbb35eaef@oss.qualcomm.com> Date: Tue, 30 Sep 2025 10:12:27 +0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali ADSP To: Dmitry Baryshkov Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com References: <20250924-knp-remoteproc-v1-0-611bf7be8329@oss.qualcomm.com> <20250924-knp-remoteproc-v1-1-611bf7be8329@oss.qualcomm.com> <4a25e085-39f8-49dc-85c6-7a4267689dd1@oss.qualcomm.com> Content-Language: en-US From: Jingyi Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI3MDAyOSBTYWx0ZWRfX4n4jEN5ufAdB Pok7P/NweXvpahWZecA5c6Iqs64KNWnjNTJMEySrkPmoQHDrqlLyb8BIFu4bfCJf5U/1zU205It VtbdcpP88RkKv1O5IQmmc+4WLWdZUUxWADFuT+5vu4NhsfOSw5rTP04UYZc4RnztF43+rGYAn+h Bhsyab1hEDpwcsz9BibapXbPvFuGKAClK3ZmqWqFi0Q2rhrbZaxRdi2xgzV58WkT+3LZG5QFJtK fyHiFkWjbaJB4g61JxiAAE8GfyJ2JXZXhN5CZamlOnZDVCRIkRIzgJyW/T6TBbb3GNTwi500Z3d s6K6kPcuxStgfWRItrfetYREBvd4MBuHXWIcY1MJd/DS4zQlVVuWlb4aqopxib1w3HDHxvcIyJ2 e94o4stlMsYGj2SjZeVleTDz0pnhwA== X-Proofpoint-GUID: dzxTs6YNaXCIMxd8szsygg0Zf0kvCfmq X-Authority-Analysis: v=2.4 cv=OMkqHCaB c=1 sm=1 tr=0 ts=68db3c94 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=vrGrQp32DgmUd1UqvcUA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: dzxTs6YNaXCIMxd8szsygg0Zf0kvCfmq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-29_08,2025-09-29_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509270029 On 9/29/2025 8:22 PM, Dmitry Baryshkov wrote: > On Mon, Sep 29, 2025 at 06:11:23PM +0800, Jingyi Wang wrote: >> >> >> On 9/29/2025 5:39 PM, Dmitry Baryshkov wrote: >>> On Mon, Sep 29, 2025 at 02:06:11PM +0800, Jingyi Wang wrote: >>>> >>>> >>>> On 9/25/2025 10:19 AM, Dmitry Baryshkov wrote: >>>>> On Wed, Sep 24, 2025 at 04:37:22PM -0700, Jingyi Wang wrote: >>>>>> Document compatible for Qualcomm Kaanapali SoC ADSP PAS which looks fully >>>>>> compatible with SM8750, which can fallback to SM8550 except for one more >>>>>> interrupt ("shutdown-ack"). >>>>>> >>>>>> Signed-off-by: Jingyi Wang >>>>>> --- >>>>>> Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 6 +++++- >>>>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>>> index 2dd479cf4821..be9e2a0bc060 100644 >>>>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>>> @@ -28,7 +28,9 @@ properties: >>>>>> - qcom,x1e80100-adsp-pas >>>>>> - qcom,x1e80100-cdsp-pas >>>>>> - items: >>>>>> - - const: qcom,sm8750-adsp-pas >>>>>> + - enum: >>>>>> + - qcom,kaanapali-adsp-pas >>>>>> + - qcom,sm8750-adsp-pas >>>>>> - const: qcom,sm8550-adsp-pas >>>>>> - items: >>>>>> - const: qcom,sm8750-cdsp-pas >>>>>> @@ -95,6 +97,7 @@ allOf: >>>>>> compatible: >>>>>> contains: >>>>>> enum: >>>>>> + - qcom,kaanapali-adsp-pas >>>>> >>>>> This one and the next entry are redundant. Do you see why? >>>>> >>>> >>>> This one describe the interrupt: >>>> >>>> - if: >>>> properties: >>>> compatible: >>>> contains: >>> >>>> enum: >>>> - qcom,kaanapali-adsp-pas >>>> - qcom,sm8750-adsp-pas >>> >>> It's still redundant. Don't you see it? >>> >> >> sorry I didn't get your point here, could you explain more? > > For you device you have two compat strings, kaanapali and sm8750. This > schema block is covered by 'if compat contains sm8750', so you don't > need to add kaanapali to the if-case. You already hit this check thanks > to the fallback compat. > Hi Dimitry, our device contains sm8550, not sm8750. Thanks, Jingyi >> >>>> then: >>>> properties: >>>> interrupts: >>>> maxItems: 6 >>>> interrupt-names: >>>> maxItems: 6 >>>> memory-region: >>>> maxItems: 2 >>>> >>>> >>>>>> - qcom,sm8750-adsp-pas >>>>>> then: >>>>>> properties: >>>>>> @@ -185,6 +188,7 @@ allOf: >>>>>> compatible: >>>>>> contains: >>>>>> enum: >>>>>> + - qcom,kaanapali-adsp-pas >>>> >>>> This one describe the power domain >>>> >>>> - if: >>>> properties: >>>> compatible: >>>> contains: >>>> enum: >>>> - qcom,kaanapali-adsp-pas >>>> - qcom,sm8550-adsp-pas >>>> - qcom,sm8650-adsp-pas >>>> - qcom,sm8750-adsp-pas >>>> - qcom,x1e80100-adsp-pas >>> >>> Likewise >>> >> >> indeed, here is redundant as "qcom,sm8550-adsp-pas" is added in >> the dts. I will remove this. >> >> Thanks, >> Jingyi >> >>>> then: >>>> properties: >>>> power-domains: >>>> items: >>>> - description: LCX power domain >>>> - description: LMX power domain >>>> power-domain-names: >>>> items: >>>> - const: lcx >>>> - const: lmx >>>> >>>> >>>>>> - qcom,sm8550-adsp-pas >>>>>> - qcom,sm8650-adsp-pas >>>>>> - qcom,sm8750-adsp-pas >>>>>> >>>>>> -- >>>>>> 2.25.1 >>>>>> >>>>> >>>> >>>> Thanks, >>>> Jingyi >>> >> >