From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E718C7EE23 for ; Thu, 11 May 2023 04:32:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231621AbjEKEcC (ORCPT ); Thu, 11 May 2023 00:32:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230472AbjEKEcB (ORCPT ); Thu, 11 May 2023 00:32:01 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DB234C28 for ; Wed, 10 May 2023 21:31:59 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4ec8133c59eso9203694e87.0 for ; Wed, 10 May 2023 21:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683779517; x=1686371517; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Yz+/Gk20g+rLGD9WBqQz3JvVt45c9RNumBRgkU0bdyw=; b=QG0MOifFqnsIjneoBrIWYEkB/2nJXDTSBP0cl0o54BtRJh+yizHmWQVzo+qwf9UzEg nQABeUsEPpv+lm5vUi3uuUOd+v1r6sw/zK1XbWLPXz30Wn4+XZVZg0mYfQsTwmc3LuCl rXt7nidzgJyhK0MdyS4mIE2+niy/1gRpmOx0I5quBIqYtU65u6h/SoRRu9ryeSQ1ZpQL +FdgYPG4ADtjRdRFxhxdDtkBiHYXhe05BGagFK3Faz3qM7LBn6tD2poemcIbaQBEu1wO mpvkzTxY6Z9rMBY586BaHcV48NBkRpuNaxkUbpa0FcZmMUchPQxd7lDRiQpoKxQBltzX VCVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683779517; x=1686371517; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yz+/Gk20g+rLGD9WBqQz3JvVt45c9RNumBRgkU0bdyw=; b=VWZC7Kg0azeqTI9aQDnjHNI4v1ouKXepVljdoaoiOMumYxnf+jzT5qf1hTz5mYbUJb GuziFWMA8yt7amktGrI4m0HrpeCELkKYTF99u9hlnCmeQiYBvPd5XfY3o6bR7K6+n6HY qJqWKwoo83GnIo7t2ag8O1Vt8j41O+5vicTH/Su+p71JZuUacT0drDfNRPtkQy19o2hy 7Xzy2eEFdOqHYl7SpCsBLt4V/KYjfUqGRGH/4ul8l3Sd4G1Q1topKMybrUw/O8n22jHL sdUt3fn7yFtcl3jkYj8G9kxb0RV4buPqYxhm0YY9GH/9dqmF3PqMJVvV1RofnEO4zfG+ X+pg== X-Gm-Message-State: AC+VfDxnHq8uCh0K7NqdZEWbN0BM8VGWLoArNSUpgEZSaN+YiY99tNU/ VEpLAWb1jDcxiBRjBANOMMYhSQ== X-Google-Smtp-Source: ACHHUZ7gmShjR3g56HV3TeLijQNuVXEg1vd+aF/vlRc2UFIDY5gqky/Jpf/uNjU1oWK+JIQC0IB9Mg== X-Received: by 2002:ac2:54a8:0:b0:4ed:b842:3a99 with SMTP id w8-20020ac254a8000000b004edb8423a99mr2683287lfk.59.1683779513330; Wed, 10 May 2023 21:31:53 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id m25-20020ac24259000000b004f13ca69dc8sm962020lfl.72.2023.05.10.21.31.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 21:31:52 -0700 (PDT) Message-ID: <02797bdd-a292-5891-ce73-8a174d62ac7d@linaro.org> Date: Thu, 11 May 2023 07:31:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v6 3/8] drm/msm/dpu: test DPU_PINGPONG_DSC bit before assign DSC ops to PINGPONG Content-Language: en-GB To: Kuogee Hsieh , dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, dianders@chromium.org, vkoul@kernel.org, daniel@ffwll.ch, airlied@gmail.com, agross@kernel.org, andersson@kernel.org Cc: quic_abhinavk@quicinc.com, quic_jesszhan@quicinc.com, quic_sbillaka@quicinc.com, marijn.suijten@somainline.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1683756453-22050-1-git-send-email-quic_khsieh@quicinc.com> <1683756453-22050-4-git-send-email-quic_khsieh@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <1683756453-22050-4-git-send-email-quic_khsieh@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 11/05/2023 01:07, Kuogee Hsieh wrote: > DPU < 7.0.0 has DPU_PINGPONG_DSC feature bit set to indicate it requires > both dpu_hw_pp_setup_dsc() and dpu_hw_pp_dsc_{enable,disable}() to be > executed to complete DSC configuration if DSC hardware block is present. > Hence test DPU_PINGPONG_DSC feature bit and assign DSC related functions > to the ops of PINGPONG block accordingly if DPU_PINGPONG_DSC bit is set. > > changes in v6: > -- split patches and keep the function file handles DPU_PINGPONG_DSC bit at this patch Please correct me if I'm wrong, the overall suggestion was to have actual catalog changes before this patch. However I do not see this feature bit being enabled at all! > > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c > index 79e4576..e7f47a4 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c > @@ -295,6 +295,12 @@ static void _setup_pingpong_ops(struct dpu_hw_pingpong *c, > c->ops.enable_dsc = dpu_hw_pp_dsc_enable; > c->ops.disable_dsc = dpu_hw_pp_dsc_disable; > > + if (test_bit(DPU_PINGPONG_DSC, &features)) { > + c->ops.setup_dsc = dpu_hw_pp_setup_dsc; > + c->ops.enable_dsc = dpu_hw_pp_dsc_enable; > + c->ops.disable_dsc = dpu_hw_pp_dsc_disable; > + } > + > if (test_bit(DPU_PINGPONG_DITHER, &features)) > c->ops.setup_dither = dpu_hw_pp_setup_dither; > }; -- With best wishes Dmitry