From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Georgi Djakov <djakov@kernel.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 01/25] interconnect: qcom: icc-rpmh: convert link_nodes to dynamic array
Date: Mon, 3 Nov 2025 10:47:14 +0100 [thread overview]
Message-ID: <02cc6e0c-5145-49d2-abea-fe4a951ff518@oss.qualcomm.com> (raw)
In-Reply-To: <20251031-rework-icc-v3-1-0575304c9624@oss.qualcomm.com>
On 10/31/25 3:45 PM, Dmitry Baryshkov wrote:
> Declaring link_nodes as a double-pointer results in a syntax sugar in
> the interconnect driver to typecast the array. Change the type of
> link_nodes field to the array to remove the need for the extra typecast.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
[...]
> static struct qcom_icc_bcm bcm_acv = {
> diff --git a/drivers/interconnect/qcom/icc-rpmh.h b/drivers/interconnect/qcom/icc-rpmh.h
> index 307f48412563690049e944907bd80500f263f738..b72939cceba38e92154f6af5a93149337fa13479 100644
> --- a/drivers/interconnect/qcom/icc-rpmh.h
> +++ b/drivers/interconnect/qcom/icc-rpmh.h
> @@ -98,7 +98,6 @@ struct qcom_icc_node {
> const char *name;
> u16 links[MAX_LINKS];
> u16 id;
> - struct qcom_icc_node **link_nodes;
> struct icc_node *node;
> u16 num_links;
> u16 channels;
> @@ -108,6 +107,7 @@ struct qcom_icc_node {
> struct qcom_icc_bcm *bcms[MAX_BCM_PER_NODE];
> size_t num_bcms;
> const struct qcom_icc_qosbox *qosbox;
> + struct qcom_icc_node *link_nodes[];
__counted_by(num_links);
Konrad
next prev parent reply other threads:[~2025-11-03 9:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 14:45 [PATCH v3 00/25] interconnect: qcom: icc-rpmh: drop static IDs Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 01/25] interconnect: qcom: icc-rpmh: convert link_nodes to dynamic array Dmitry Baryshkov
2025-11-03 9:47 ` Konrad Dybcio [this message]
2025-10-31 14:45 ` [PATCH v3 02/25] interconnect: qcom: sc7280: convert to dynamic IDs Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 03/25] interconnect: qcom: sc8180x: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 04/25] interconnect: qcom: sc8280xp: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 05/25] interconnect: qcom: sdm845: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 06/25] interconnect: qcom: sm8250: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 07/25] interconnect: qcom: x1e80100: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 08/25] interconnect: qcom: qcs615: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 09/25] interconnect: qcom: qcs8300: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 10/25] interconnect: qcom: qdu1000: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 11/25] interconnect: qcom: sar2130p: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 12/25] interconnect: qcom: sc7180: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 13/25] interconnect: qcom: sdm670: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 14/25] interconnect: qcom: sdx55: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 15/25] interconnect: qcom: sdx65: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 16/25] interconnect: qcom: sdx75: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 17/25] interconnect: qcom: sm6350: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 18/25] interconnect: qcom: sm7150: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 19/25] interconnect: qcom: sm8150: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 20/25] interconnect: qcom: sm8350: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 21/25] interconnect: qcom: sm8450: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 22/25] interconnect: qcom: sm8550: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 23/25] interconnect: qcom: sm8650: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 24/25] interconnect: qcom: sm8750: " Dmitry Baryshkov
2025-10-31 14:45 ` [PATCH v3 25/25] interconnect: qcom: icc-rpmh: drop support for non-dynamic IDS Dmitry Baryshkov
2025-11-03 9:52 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02cc6e0c-5145-49d2-abea-fe4a951ff518@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox