From: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
To: Stephen Boyd <swboyd@chromium.org>, <agross@kernel.org>,
<alsa-devel@alsa-project.org>, <bgoswami@codeaurora.org>,
<bjorn.andersson@linaro.org>, <broonie@kernel.org>,
<devicetree@vger.kernel.org>, <judyhsiao@chromium.org>,
<lgirdwood@gmail.com>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <perex@perex.cz>,
<quic_plai@quicinc.com>, <robh+dt@kernel.org>,
<rohitkr@codeaurora.org>, <srinivas.kandagatla@linaro.org>,
<tiwai@suse.com>
Cc: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Subject: Re: [RESEND v13 03/10] ASoC: qcom: lpass: Add dma fields for codec dma lpass interface
Date: Wed, 16 Feb 2022 10:28:08 +0530 [thread overview]
Message-ID: <0311446c-d7da-a701-b63d-08ca02d9c5d5@quicinc.com> (raw)
In-Reply-To: <CAE-0n53dXfwsJ=mh7cNH6Lq0Um+h+oTJDvqsXALh8L=wfONLjw@mail.gmail.com>
On 2/15/2022 6:35 AM, Stephen Boyd wrote:
Thanks for your time Stephen!!!
> Quoting Srinivasa Rao Mandadapu (2022-02-14 06:58:21)
>> Add lpass interface memebers to support audio path over codec dma.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> sound/soc/qcom/lpass.h | 116 +++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 116 insertions(+)
>>
>> diff --git a/sound/soc/qcom/lpass.h b/sound/soc/qcom/lpass.h
>> index f0d21cd..7cc3763 100644
>> --- a/sound/soc/qcom/lpass.h
>> +++ b/sound/soc/qcom/lpass.h
>> @@ -234,12 +294,66 @@ struct lpass_variant {
>> struct reg_field wrdma_enable;
>> struct reg_field wrdma_dyncclk;
>>
>> + /*CDC RXTX RD_DMA */
> Please add space after /*
Okay. Will change it.
>
>> + struct reg_field rxtx_rdma_intf;
>> + struct reg_field rxtx_rdma_bursten;
>> + struct reg_field rxtx_rdma_wpscnt;
>> + struct reg_field rxtx_rdma_fifowm;
>> + struct reg_field rxtx_rdma_enable;
>> + struct reg_field rxtx_rdma_dyncclk;
>> + struct reg_field rxtx_rdma_burst8;
>> + struct reg_field rxtx_rdma_burst16;
>> + struct reg_field rxtx_rdma_dynburst;
>> + struct reg_field rxtx_rdma_codec_enable;
>> + struct reg_field rxtx_rdma_codec_pack;
>> + struct reg_field rxtx_rdma_codec_intf;
>> + struct reg_field rxtx_rdma_codec_fs_sel;
>> + struct reg_field rxtx_rdma_codec_ch;
>> + struct reg_field rxtx_rdma_codec_fs_delay;
>> +
>> + /*CDC RXTX WR_DMA */
> Same
Okay.
>
>> + struct reg_field rxtx_wrdma_intf;
>> + struct reg_field rxtx_wrdma_bursten;
>> + struct reg_field rxtx_wrdma_wpscnt;
>> + struct reg_field rxtx_wrdma_fifowm;
>> + struct reg_field rxtx_wrdma_enable;
>> + struct reg_field rxtx_wrdma_dyncclk;
>> + struct reg_field rxtx_wrdma_burst8;
>> + struct reg_field rxtx_wrdma_burst16;
>> + struct reg_field rxtx_wrdma_dynburst;
>> + struct reg_field rxtx_wrdma_codec_enable;
>> + struct reg_field rxtx_wrdma_codec_pack;
>> + struct reg_field rxtx_wrdma_codec_intf;
>> + struct reg_field rxtx_wrdma_codec_fs_sel;
>> + struct reg_field rxtx_wrdma_codec_ch;
>> + struct reg_field rxtx_wrdma_codec_fs_delay;
>> +
>> + /*CDC VA WR_DMA */
>> + struct reg_field va_wrdma_intf;
>> + struct reg_field va_wrdma_bursten;
>> + struct reg_field va_wrdma_wpscnt;
>> + struct reg_field va_wrdma_fifowm;
>> + struct reg_field va_wrdma_enable;
>> + struct reg_field va_wrdma_dyncclk;
>> + struct reg_field va_wrdma_burst8;
>> + struct reg_field va_wrdma_burst16;
>> + struct reg_field va_wrdma_dynburst;
>> + struct reg_field va_wrdma_codec_enable;
>> + struct reg_field va_wrdma_codec_pack;
>> + struct reg_field va_wrdma_codec_intf;
>> + struct reg_field va_wrdma_codec_fs_sel;
>> + struct reg_field va_wrdma_codec_ch;
>> + struct reg_field va_wrdma_codec_fs_delay;
>> +
>> /**
> This shouldn't have two stars as it isn't kerneldoc
Actually this not part of this patch.
>
>> * on SOCs like APQ8016 the channel control bits start
>> * at different offset to ipq806x
>> **/
>> u32 dmactl_audif_start;
>> u32 wrdma_channel_start;
>> + u32 rxtx_wrdma_channel_start;
>> + u32 va_wrdma_channel_start;
>> +
>> /* SOC specific initialization like clocks */
>> int (*init)(struct platform_device *pdev);
>> int (*exit)(struct platform_device *pdev);
>> @@ -251,10 +365,12 @@ struct lpass_variant {
>> int num_dai;
>> const char * const *dai_osr_clk_names;
>> const char * const *dai_bit_clk_names;
>> + const char * const *cdc_dma_clk_names;
>>
>> /* SOC specific clocks configuration */
>> const char **clk_name;
>> int num_clks;
>> + int cdc_dma_num_clks;
> Why not size_t? Negative numbers are useful here?
Okay. As negative numbers are not useful here, will change to size_t.
next prev parent reply other threads:[~2022-02-16 4:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 14:58 [RESEND v13 00/10] Add support for audio on SC7280 based targets Srinivasa Rao Mandadapu
2022-02-14 14:58 ` [RESEND v13 01/10] ASoC: qcom: SC7280: Update config for building codec dma drivers Srinivasa Rao Mandadapu
2022-02-14 14:58 ` [RESEND v13 02/10] ASoC: qcom: Move lpass_pcm_data structure to lpass header Srinivasa Rao Mandadapu
2022-02-14 14:58 ` [RESEND v13 03/10] ASoC: qcom: lpass: Add dma fields for codec dma lpass interface Srinivasa Rao Mandadapu
2022-02-15 1:05 ` Stephen Boyd
2022-02-16 4:58 ` Srinivasa Rao Mandadapu [this message]
2022-02-14 14:58 ` [RESEND v13 04/10] ASoC: qcom: Add helper function to get dma control and lpaif handle Srinivasa Rao Mandadapu
2022-02-15 1:10 ` Stephen Boyd
2022-02-16 5:11 ` Srinivasa Rao Mandadapu
2022-02-17 19:41 ` Stephen Boyd
2022-02-19 18:45 ` Srinivasa Rao Mandadapu (Temp)
2022-02-14 14:58 ` [RESEND v13 05/10] ASoC: qcom: Add register definition for codec rddma and wrdma Srinivasa Rao Mandadapu
2022-02-15 1:12 ` Stephen Boyd
2022-02-16 5:14 ` Srinivasa Rao Mandadapu
2022-02-14 14:58 ` [RESEND v13 06/10] ASoC: qcom: Add regmap config support for codec dma driver Srinivasa Rao Mandadapu
2022-02-14 14:58 ` [RESEND v13 07/10] ASoC: qcom: Add " Srinivasa Rao Mandadapu
2022-02-15 1:27 ` Stephen Boyd
2022-02-16 6:53 ` Srinivasa Rao Mandadapu
2022-02-17 19:50 ` Stephen Boyd
2022-02-16 6:42 ` kernel test robot
2022-02-17 13:14 ` Dan Carpenter
2022-02-14 14:58 ` [RESEND v13 08/10] ASoC: qcom: Add lpass CPU driver for codec dma control Srinivasa Rao Mandadapu
2022-02-15 1:33 ` Stephen Boyd
2022-02-16 9:42 ` Srinivasa Rao Mandadapu
2022-02-17 19:53 ` Stephen Boyd
2022-02-19 18:56 ` Srinivasa Rao Mandadapu (Temp)
2022-02-14 14:58 ` [RESEND v13 09/10] ASoC: dt-bindings: Add SC7280 lpass cpu bindings Srinivasa Rao Mandadapu
2022-02-14 14:58 ` [RESEND v13 10/10] ASoC: qcom: lpass-sc7280: Add platform driver for lpass audio Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0311446c-d7da-a701-b63d-08ca02d9c5d5@quicinc.com \
--to=quic_srivasam@quicinc.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_plai@quicinc.com \
--cc=quic_potturu@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox