From: Steev Klimaszewski <steev@kali.org>
To: "Christian König" <christian.koenig@amd.com>,
"Amit Pundir" <amit.pundir@linaro.org>,
"Rob Clark" <robdclark@gmail.com>
Cc: dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm@vger.kernel.org, Rob Clark <robdclark@chromium.org>,
Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies harder
Date: Wed, 17 Nov 2021 19:23:17 -0600 [thread overview]
Message-ID: <0336e09d-59c4-3155-434a-0b04fda15bb6@kali.org> (raw)
In-Reply-To: <c7741be3-43ec-307b-f5bd-3d19725df76c@amd.com>
On 11/17/21 1:27 AM, Christian König wrote:
> Am 16.11.21 um 19:30 schrieb Amit Pundir:
>> On Tue, 16 Nov 2021 at 21:21, Rob Clark <robdclark@gmail.com> wrote:
>>> From: Rob Clark <robdclark@chromium.org>
>>>
>>> drm_sched_job_add_dependency() could drop the last ref, so we need
>>> to do
>>> the dma_fence_get() first.
>>>
>> It fixed the splats I saw on RB5 (sm8250 | A650). Thanks.
>>
>> Tested-by: Amit Pundir <amit.pundir@linaro.org>
>
> I've added my rb, pushed this with the original fix to drm-misc-fixes
> and cleaned up the obvious fallout between drm-misc-fixes and
> drm-misc-next in drm-tip.
>
> Thanks for the help and sorry for the noise,
> Christian.
>
I've run into this splat on the Lenovo Yoga C630 on 5.16-rc1 - are these
2 patches (which fix it) going to be heading to 5.16 or were they
targeted at 5.17?
-- steev
next prev parent reply other threads:[~2021-11-18 1:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 15:55 [PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies harder Rob Clark
2021-11-16 18:30 ` Amit Pundir
2021-11-17 7:27 ` Christian König
2021-11-18 1:23 ` Steev Klimaszewski [this message]
2021-11-18 3:09 ` Rob Clark
2021-11-18 6:59 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0336e09d-59c4-3155-434a-0b04fda15bb6@kali.org \
--to=steev@kali.org \
--cc=airlied@linux.ie \
--cc=amit.pundir@linaro.org \
--cc=andrey.grodzovsky@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox