From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A05C02882DB for ; Thu, 8 May 2025 18:01:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746727310; cv=none; b=j3jDivd/WQVhwcJhDCWZi5WOB+986F6nnoMNHEY/334zof0XFF85phL9CkNBAw12DlZoWwPBTZ+gL7AsL2HSDJgkgWEIIGB64ZFcJKyzqGsjR4lRFbYBiXq1K6zwGMJiP2qhUSxx+DYQiLWgZcKnMyu5wH+Z+xjOptk7OYSg5Qs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746727310; c=relaxed/simple; bh=tf0e69QEXx1KRcqDH6MbYOhTdYNkdEfOzBuSMhRr9+M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nwsVaWSM5PWjBGLfDSBdE7gGzIEgMIQpD+H3ThBXrOw9TqPKoeUCc+zeV8/8sXrLiW16XeSGSOkfYhSHBUWN2giQ26RonAQ2TzVxejjkhTO441gXApn7xAU6RMoiewYm55Rs3NoEu9eft5AoJrvBSYZbkWxMrMVXZ+/pstSus08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h/fVgsjr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h/fVgsjr" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 548DIOrA002148 for ; Thu, 8 May 2025 18:01:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= faYKMx3ZAB8PhnJu8Fjo1te3lAGIdH6dTqFWB5Uw6zU=; b=h/fVgsjrXVOin7in MRmmMVj8wmE4+Zp8Inpda4d1nGqGh3x2jM/45AFIWVajwYRE7dppj5Bcmz0rGLtB 2QSJNrF7a6F0q31t3lRVMpML4/9BJpgtFSakHKTrKhRg5sknEZuZqrkt2uR393VY O+EqHocY5Eu/fQERR0hSnN1ytLRTMGodRuwsjDgeoWdf9zZpwmjw/cdqsdDWcyQy csAqBDAXwRE2IjeNDsYVD0q+a+p6mv/1CrvdT80SZMa+wGUIbSZGNE9EAwOcBOTs bHj+QoiadZE0uxOFot0dhWmR8hLzuRxPkExa2KpUEBQkzNSYEnAcj9kQxkeUP5VX 7tZU/g== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46gnp5a5hx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 08 May 2025 18:01:47 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4768b27fef3so2920271cf.2 for ; Thu, 08 May 2025 11:01:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746727306; x=1747332106; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=faYKMx3ZAB8PhnJu8Fjo1te3lAGIdH6dTqFWB5Uw6zU=; b=HRo2k8vG2mxCRCHX2OMD2EhV36rLlUGrIHDR2Mwt7Q4kV8KLaZCBDqh03mHx/GYfgO ozGXvr9/XpnvmwUgvItFpUj1Hk/36qN6KZHkdZjdP69ZIxWmsaV33SBjPSX731ZFIoTm rKpLcifrSv1FO8bXpT6UL5g5IU8rcdCgqQbGj1cKeIHNwKHagHaaIymrZdYlDqJbRZ7E gn2g7rVx8f4MJqT+YV1XybLaiNKox2AOGRq81u1KZhkjTSS1Xn4fckc/MjsPgVrEyCMk UkENIAeIrh22cDs5mkehNbYtrTj6wasA86JJju+5Nf2kmPIoB3N+vFzWcpXgYDUoTOPY qd4A== X-Forwarded-Encrypted: i=1; AJvYcCU+jOFzXtGnTUPZ4a7Up98y7bJZW38Y8R8ox3Piv8uiDs0aEjlk7S/GWxijCV/aofKDs9mgkfjiYnCBD8UF@vger.kernel.org X-Gm-Message-State: AOJu0Yx/4//MSA7aIBu/I2fMbuunIQVyLsMMLJ1PV+X5TyFYTTCLDtEb VwSBCmoAIC0pGc+M19tN47sB2QJurmC8P06qAzFr16SKd1zaa1mlNSAoI+yboZi+PaBAxcQ/S1f +g3PAaJgd1hZ3S/hKyP/BnllOzZBguCuR03ksnvRm831d6RKeQzOvEVZslccCDZ6T X-Gm-Gg: ASbGnctgNEkeO1fVuFeEn/Vt44jhp/EJ6952Q9ZvzvB99QwljjoCkXkIY9RXh5EnFpq YOF/Wnxy6wt3dQ/SyEkgPBdVq5m6iLVbUAPLx+r31Q8vB9XEAryRaD6uzNmqDMcpRQls0hY9QHN aWHVI+nArBFzQjlosV/8aEDsroCHt7rTzaPe0r/q2qd14vTqs1U5vUtwwk7+l3ELhBhPrI+nB33 XrQVvZyiIUoWIHk1b4MeLLHbc7mX7b5wA3Rc0gr1YYyzGOo62M3PIqODPlewo/SpvGVwcNDRMji 5DEi9ip2LjTkkzOF+O7A/3ZFCro2HYLVN7S6u4YvR4I6/BlWEQas0pgpoPPdO5afte4= X-Received: by 2002:ac8:7f89:0:b0:476:66fb:4df4 with SMTP id d75a77b69052e-4945261e5c8mr2116551cf.0.1746727306372; Thu, 08 May 2025 11:01:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH0RfkAw4JpFJ9hanOqIpMrENgKJ7h2yQpbIeU9EmRylaW6/4y4JTXRps/+PPWzcOvYGMLL6g== X-Received: by 2002:ac8:7f89:0:b0:476:66fb:4df4 with SMTP id d75a77b69052e-4945261e5c8mr2116291cf.0.1746727305834; Thu, 08 May 2025 11:01:45 -0700 (PDT) Received: from [192.168.65.105] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad2197468eesm19194866b.110.2025.05.08.11.01.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 May 2025 11:01:45 -0700 (PDT) Message-ID: <03409f08-9612-40be-b8b2-6cebd5acd0a4@oss.qualcomm.com> Date: Thu, 8 May 2025 20:01:44 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] soc: qcom: socinfo: Add support for new fields in revision 21 To: Mukesh Ojha , Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250425135946.1087065-1-mukesh.ojha@oss.qualcomm.com> <20250425135946.1087065-2-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=XL0wSRhE c=1 sm=1 tr=0 ts=681cf18b cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=EUspDBNiAAAA:8 a=o0mhMSQjO9SjGwgmQLoA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: Sqj9wqSnPbUVYbcT4QIUhcYm-w1bIVjM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA4MDE1OCBTYWx0ZWRfX7fVLUF/3nOgh Onm3R1whftdVYA7T3Xtrj9WxR+3TEwWHItYAbGtxprIjsKB2+UTxNia+BWiYkw4NEchX9E7rIuG NDw62qY6gLWM7aFs5rPylykvL08ZC6ZlKH2GKB3z/iJnEuxRvcKEuAmieRqaqPX+yALFQ5RIfxJ ISSziIVerYnzUGhcubKPX1ZbBlBRVf50aEvT+kXAMBJ7PZp94qjvGF8Afre4J3gc0y3xCwI/c9H 3eYm1KFDre7T2cRJ6bWlYcDlVDAmEzwVViC4pYzpYMxeMoLlCh8IZfs73PZvm0kfkCJWhQKAcnA u66L+MI9hqtdpyVw0r0LhDR3VyUhnmNSrqvrmvwfSUi9LAWfyg+qx7jo80cKFxHlwSZJxXWhZXE rUzUWvnZTyVHyOxsMqpRrKt+2/tE+7868RMRrlIb9in1nEb9eq3ciTpRCGq9gXC8LZeSq3IO X-Proofpoint-ORIG-GUID: Sqj9wqSnPbUVYbcT4QIUhcYm-w1bIVjM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-08_05,2025-05-08_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 spamscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505080158 On 5/8/25 6:48 PM, Mukesh Ojha wrote: > On Thu, May 08, 2025 at 06:56:47PM +0300, Dmitry Baryshkov wrote: >> On Thu, May 08, 2025 at 09:07:03PM +0530, Mukesh Ojha wrote: >>> On Fri, Apr 25, 2025 at 08:28:51PM +0300, Dmitry Baryshkov wrote: >>>> On Fri, Apr 25, 2025 at 07:29:45PM +0530, Mukesh Ojha wrote: >>>>> Add the subpartfeature offset field to the socinfo structure >>>>> which came for version 21 of socinfo structure. >>>>> >>>>> Subpart_feat_offset is subpart like camera, display, etc., >>>>> and its internal feature available on a bin. >>>>> >>>>> Signed-off-by: Mukesh Ojha >>>>> --- >>>>> Changes in v2: >>>>> - Added debugfs entry and described more about the field in commit. >>>>> >>>>> drivers/soc/qcom/socinfo.c | 6 ++++++ >>>>> include/linux/soc/qcom/socinfo.h | 2 ++ >>>>> 2 files changed, 8 insertions(+) >>>>> >>>>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c >>>>> index 5800ebf9ceea..bac1485f1b27 100644 >>>>> --- a/drivers/soc/qcom/socinfo.c >>>>> +++ b/drivers/soc/qcom/socinfo.c >>>>> @@ -154,6 +154,7 @@ struct socinfo_params { >>>>> u32 boot_cluster; >>>>> u32 boot_core; >>>>> u32 raw_package_type; >>>>> + u32 nsubpart_feat_array_offset; >>>>> }; >>>>> >>>>> struct smem_image_version { >>>>> @@ -608,6 +609,11 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo, >>>>> &qcom_socinfo->info.fmt); >>>>> >>>>> switch (qcom_socinfo->info.fmt) { >>>>> + case SOCINFO_VERSION(0, 21): >>>>> + qcom_socinfo->info.nsubpart_feat_array_offset = >>>>> + __le32_to_cpu(info->nsubpart_feat_array_offset); >>>>> + debugfs_create_u32("nsubpart_feat_array_offset", 0444, qcom_socinfo->dbg_root, >>>>> + &qcom_socinfo->info.nsubpart_feat_array_offset); >>>> >>>> An offset into what? If this provides additional data, then the data >>>> should be visible in the debugfs. Not sure, what's the point in dumping >>>> the offset here. >>> >>> offset into info(struct socinfo) object. >>> >>> I agree to you and I said the same in first version this is just offset >>> and does not provide any debug info we would look from userspace. For >>> parity with other fields I did it for all newly added fields. >>> I have dropped it in latest patch. >> >> I'd rather see the decoded structure that is being pointed by this >> offset. > > You mean info + info->nsubpart_feat_array_offset ? > > There is more to it which I don't want to mention as they are not > upstreamed yet and unrelated to this change. > > data = info + (offset + (part * sizeof(u32))); > > e.g., Here, part is a enum represents camera, display etc., and data > represents their feature presents. Since, part is not upstream yet I > don't feel we should expose this information to debugfs. We could always > add them in debugfs when such things are standardized and upstreamed. That's what Dmitry's saying - just add support for them Konrad