From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5DBF22370F for ; Fri, 25 Apr 2025 20:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745614326; cv=none; b=PTtaCXzGIN7IOszPX16jK+JaZL7vHWR7HBsGPjjnXYc3In3NVFug4GC92Uv68gB4Dt7m92T4HDlZaivfa8bRJHvze04xop/eTygePth/o11srNGTlXl+iDkaELe4Y+wg1v6KehsnbSV5QE3r/uKOVa42juZkfgp2ZRJkjsJTLpo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745614326; c=relaxed/simple; bh=kAToM2XUXvvC5laIERANy/QDIAazwPQuoIadpAVkohQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LptaqAO8ylKanqSC9DhNgWWZOnk26TeE0MDayIoh/d70aPSV8JEPqaFAc46LsCjqDFCBecDKuXuoJLSTOPC6HXvdViLp00DxkImNB5I0IuUcNfoCwsV2Ix2cRSLFDLOpVJJPjZV9j7D3XXyjo+clWZnGAK0fSz8/I0Xq4yaL4bI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TNgYJy8Y; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TNgYJy8Y" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53PGJrP3011043 for ; Fri, 25 Apr 2025 20:52:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= khW+OjIu3QFmUYnH4/qhhaS7xRKHn2LSxx6Dexoku1Q=; b=TNgYJy8YLl6+dENP 8ww9i+7XwieZ6kWucsJqjvRHXJPliQhHagU1H74m1RGdoSQLbLJEYkt50EA0s7aq lgubZPZe5PrKt0qvh7h/G8wwL/zJUa0WIJmcdug5dD6Bg+saz/f1Og2LngVJV0Nu iFTCvk/YFMcMSobQcsyYapjWNXkf2Xw547VIyCxTFicSeLbjIKF2pZQWfyBCZkO7 32poQt/HJQIhLJnkMer/vUfno0zw4cUno0vCP904TTBHVErCSwr2AbwRaOxQLXs5 +fw4MRlxchyg1ZGPbrmoEDsiVDU6uT4iLWqnSQDEigF8OYiW9oRRg+BPAOaouPb1 ZDU6DA== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 466jh0jeay-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 25 Apr 2025 20:52:03 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6e8fb83e15fso6515516d6.0 for ; Fri, 25 Apr 2025 13:52:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745614322; x=1746219122; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=khW+OjIu3QFmUYnH4/qhhaS7xRKHn2LSxx6Dexoku1Q=; b=Nvra+slKbmf6wX10pF4cvqKqptPI+uSlZAzGD8bOBjMrk/e67NpBxp/4za78ZzYWKb yX8c5tNMZ4OyChbC+BMZ0sCfQKT8jGAm5Ual9JeBdME6XHY8HdRjbrTQfDWfu5w0bz76 /rAByWvQEdIRWPWP8nW3/wM9ppmdTAJuZwd2l3xWXeQtL7bnufAWOH+8gYOQhuHr4Kb9 kI10kQc9MoR5cuJ6m1Twbti0+zH9LOhTflc6HI9NZw3YcEz9FiyGSS9K9RJabCBQRxPc wKmoCBSeKg3YltQqgiGzFVg4nsTE+WyOSdp/gMEJxOi0G0AyokeBTMrwRjhSqv3EPLkk PrKg== X-Gm-Message-State: AOJu0YwibIRefggH4aEz1+Y3qV1DvYy1LZfJdKFBzMG4h+s33MtlyAQ4 1nHW9SzrWh50pLbskIsBtSDRVqk49lCQU4cIxwMMHUx++skMGBC7G6QFQh4+cuFpYSXHFNQOAYE 9DbwO8QUK5rbXtkFYfhWIfLzHE2oNSa5uyifVs9eblFF1yUC+G4KrZi23/vKyqJ9w0sxGCWwI X-Gm-Gg: ASbGnct91vtYxAGHDvztluQ0nlsNsI/WQHQAIyhmPKsCJKg3+OTXhxx0zJIAue9/Ddz abe0hop0ORFjwVMrARlnk3N0AplCypndYMDlSqgDpKq6vu86j06YlyxYuKkyG1/TdVSnYpMGnyu b+cpOQP09QDsQlnYbum3YT7Ypf3X1rruFRHrs1gkvY8I3i72DEcia9wDj2NUsOllUWehR8cptDC J/oBNnJOmiWgKlfLgCCxyGH33SSWSR2BuRwmbBo0AHGgv770CnOomiwf2zgk46KcuVOmy3tEN37 sKiUI9lVG4VAG2S9le9iXplnvCOEYVVyG/lox57udvJIv1TqWJKFOse9WKdmSx4fD8E= X-Received: by 2002:a05:620a:1a04:b0:7c3:d3a0:578d with SMTP id af79cd13be357-7c9607ce29bmr234167585a.14.1745614322375; Fri, 25 Apr 2025 13:52:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELNiJdwRrt+X3+ZmBmj8ToCx5SguQhymg571V2ufzv8cclkQ1COqWoTRaO72k8xjo3W2vT0Q== X-Received: by 2002:a05:620a:1a04:b0:7c3:d3a0:578d with SMTP id af79cd13be357-7c9607ce29bmr234165185a.14.1745614321971; Fri, 25 Apr 2025 13:52:01 -0700 (PDT) Received: from [192.168.65.156] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace6ecfa354sm185152266b.120.2025.04.25.13.51.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Apr 2025 13:52:01 -0700 (PDT) Message-ID: <04201672-3d7c-4994-bdbd-959ec7a697a2@oss.qualcomm.com> Date: Fri, 25 Apr 2025 22:51:58 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/2] arm64: dts: qcom: ipq5018: Add PCIe related nodes To: george.moussalem@outlook.com, Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nitheesh Sekar , Varadarajan Narayanan , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Andersson , Konrad Dybcio , Praveenkumar I Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, 20250317100029.881286-1-quic_varada@quicinc.com, 20250317100029.881286-2-quic_varada@quicinc.com, Sricharan R , Dmitry Baryshkov References: <20250425-ipq5018-pcie-v8-0-03ee75c776dc@outlook.com> <20250425-ipq5018-pcie-v8-1-03ee75c776dc@outlook.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250425-ipq5018-pcie-v8-1-03ee75c776dc@outlook.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: rArC8JJocjbtKRmUCuGppcs9uHAADS8l X-Proofpoint-ORIG-GUID: rArC8JJocjbtKRmUCuGppcs9uHAADS8l X-Authority-Analysis: v=2.4 cv=Fv0F/3rq c=1 sm=1 tr=0 ts=680bf5f3 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=UqCG9HQmAAAA:8 a=g69xjaZfg-qW7mxf-08A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=TjNXssC_j7lpFel5tvFf:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI1MDE1MCBTYWx0ZWRfX/soL6Lv4UjN+ rHqin5brMDNTezioI6KSZ40mSP73heWcfFArD+lchyJw7w3vIlhihNuzrGPB87+T5VMn2DrMU7D oY4tFcQ5MYY3q8iTmgOzupGIodR7t0DVtJwdVeWwzLrJxzG+kasD9ES56YEGis24BJT+QMnghP5 b19P8XcAV72Z53a0ZF/P/nwyq883j2xW/zPW4YHgEJgqJcue4HTdvnAj1IsbwJJBSEOlQ8fvmRw 5n5aa+e+q0JVBJlVgPHmzJrh9H2KGtyNKPA0eDaYWO9a8GupwGgNGxETF+UWVPiEtHSoUNqdGeP NoaG8dnrFXRpo12OZwL0DwhbP7+BiHW7L6H7SYzCTbNTSQZ04GQ+WDdjfxMaFeH9vs47B4rFJSC H1a5oRYrUT+HStZVsj+h1RIW/TDlt0KfPV7XDBjnbhFR/6NjVw5eAw1vIFLsrJcyWllOABkE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-25_06,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 malwarescore=0 mlxlogscore=736 priorityscore=1501 suspectscore=0 adultscore=0 bulkscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504250150 On 4/25/25 2:00 PM, George Moussalem via B4 Relay wrote: > From: Nitheesh Sekar > > Add phy and controller nodes for a 2-lane Gen2 and > a 1-lane Gen2 PCIe bus. IPQ5018 has 8 MSI SPI interrupts and > one global interrupt. > > NOTE: the PCIe controller supports gen3, yet the phy is limited to gen2. > > Signed-off-by: Nitheesh Sekar > Signed-off-by: Sricharan R > Reviewed-by: Manivannan Sadhasivam > Reviewed-by: Dmitry Baryshkov > Signed-off-by: George Moussalem > --- > arch/arm64/boot/dts/qcom/ipq5018.dtsi | 246 +++++++++++++++++++++++++++++++++- > 1 file changed, 244 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > index 8914f2ef0bc47fda243b19174f77ce73fc10757d..917c6eb7c227e405e9216125cff15551f57839a5 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > @@ -147,6 +147,40 @@ usbphy0: phy@5b000 { > status = "disabled"; > }; > > + pcie1_phy: phy@7e000{ "@7e000 {" [...] > + pcie0_phy: phy@86000{ ditto [...] > + > + /* > + * While the PCIe controller supports gen3, > + * the phy is limited to gen2. Hence, limit > + * the link speed to gen2. > + */ /* The controller supports Gen3, but the connected PHY is only Gen2-capable */ and it nicely fits into 1 line! With that: Reviewed-by: Konrad Dybcio Konrad