From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB740C433E7 for ; Wed, 14 Oct 2020 16:09:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87A4C21D7F for ; Wed, 14 Oct 2020 16:09:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730757AbgJNQJ1 (ORCPT ); Wed, 14 Oct 2020 12:09:27 -0400 Received: from foss.arm.com ([217.140.110.172]:52620 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728144AbgJNQJ1 (ORCPT ); Wed, 14 Oct 2020 12:09:27 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C1E55D6E; Wed, 14 Oct 2020 09:09:26 -0700 (PDT) Received: from [10.57.48.76] (unknown [10.57.48.76]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0A0BF3F71F; Wed, 14 Oct 2020 09:09:18 -0700 (PDT) Subject: Re: [PATCH] media: venus: core: Drop local dma_parms To: Sai Prakash Ranjan , Stephen Boyd Cc: Stanimir Varbanov , mchehab@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org References: <7dacfcb3d8cb7e99e348f00ee15f917a@codeaurora.org> <160194617664.310579.9927356526425343212@swboyd.mtv.corp.google.com> <91296fbd4feea193ccefa5e511af57f1@codeaurora.org> From: Robin Murphy Message-ID: <042cd5da-ad6e-084b-2352-c74174046ab5@arm.com> Date: Wed, 14 Oct 2020 17:09:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <91296fbd4feea193ccefa5e511af57f1@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2020-10-06 06:23, Sai Prakash Ranjan wrote: > On 2020-10-06 06:32, Stephen Boyd wrote: >> Quoting Sai Prakash Ranjan (2020-10-02 05:45:03) >>> On 2020-10-02 16:57, Stanimir Varbanov wrote: >>> > On 10/2/20 11:06 AM, Sai Prakash Ranjan wrote: >>> >> On 2020-09-04 02:44, Robin Murphy wrote: >>> >>> Since commit 9495b7e92f71 ("driver core: platform: Initialize >>> >>> dma_parms >>> >>> for platform devices"), struct platform_device already provides a >>> >>> dma_parms structure, so we can save allocating another one. >>> >> >>> > >>> > Do you have the mentioned above commit when you see this warning ? >>> >>> +Stephen reported this, this was recently backported to 5.4 kernel >>> where playing youtube with dma api debug enabled would throw this >>> warning and I am almost 100% certain this is the commit which caused >>> the warning to appear again. >>> >> >> We don't have commit 9495b7e92f71 though so I guess we need that one >> if we take this patch. > > Oh so Stan was referring to that commit, oops my bad. I thought > he was referring to this patch. So I suppose everything is good > if we backport both patches. Right, this patch is just some trivial housekeeping which certainly doesn't deserve backporting in its own right. However if it's because you're doing something like backporting an entire chunk of the media tree as a unit, then yeah, you'll need to track down all the functional dependencies, especially any that *weren't* helpfully called out in commit messages ;) Robin.