From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D07EC388F9 for ; Mon, 23 Nov 2020 21:13:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B763C206F9 for ; Mon, 23 Nov 2020 21:13:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="ooR8nBaF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730414AbgKWVNg (ORCPT ); Mon, 23 Nov 2020 16:13:36 -0500 Received: from z5.mailgun.us ([104.130.96.5]:29451 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729590AbgKWVNg (ORCPT ); Mon, 23 Nov 2020 16:13:36 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1606166015; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=MpPyix18w9A/YIkD3A/ihCcjBzXbm8kBCQdGFP27g6U=; b=ooR8nBaFD56aMaTnj8UKL4VGg8NNgwptISqlxmuSifewVKumEgFL4hvGKNSlIUo1p8IFvHeh pyhIJSIwxt3g/azjeEzb1Mzwchb4Z0KkwePHvFgBsvAfUg5zgCA81u0Vmv8SFF6mAeIwm3UC XvUSmJYAv69s81zBlkhcRovghEo= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n09.prod.us-east-1.postgun.com with SMTP id 5fbc25ff7f0cfa6a1666a91d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 23 Nov 2020 21:13:35 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A0DACC433ED; Mon, 23 Nov 2020 21:13:34 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7901AC43462; Mon, 23 Nov 2020 21:13:33 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 23 Nov 2020 13:13:33 -0800 From: abhinavk@codeaurora.org To: Lee Jones Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Clark , Daniel Vetter , Drew Davenport , Sean Paul Subject: Re: [Freedreno] [PATCH 31/40] drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply 'global_state' description In-Reply-To: <20201123111919.233376-32-lee.jones@linaro.org> References: <20201123111919.233376-1-lee.jones@linaro.org> <20201123111919.233376-32-lee.jones@linaro.org> Message-ID: <04c43a8bf76d7d44fb21add18697f470@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2020-11-23 03:19, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:247: warning: Excess function > parameter 'Return' description in '_dpu_rm_check_lm_peer' > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:283: warning: Function > parameter or member 'global_state' not described in > '_dpu_rm_check_lm_and_get_connected_blks' > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:283: warning: Excess function > parameter 'Return' description in > '_dpu_rm_check_lm_and_get_connected_blks' > > Cc: Rob Clark > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Drew Davenport > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Lee Jones Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > index 0ae8a36ffcff3..fd2d104f0a91d 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > @@ -239,7 +239,7 @@ static bool _dpu_rm_needs_split_display(const > struct msm_display_topology *top) > * @rm: dpu resource manager handle > * @primary_idx: index of primary mixer in rm->mixer_blks[] > * @peer_idx: index of other mixer in rm->mixer_blks[] > - * @Return: true if rm->mixer_blks[peer_idx] is a peer of > + * Return: true if rm->mixer_blks[peer_idx] is a peer of > * rm->mixer_blks[primary_idx] > */ > static bool _dpu_rm_check_lm_peer(struct dpu_rm *rm, int primary_idx, > @@ -264,6 +264,7 @@ static bool _dpu_rm_check_lm_peer(struct dpu_rm > *rm, int primary_idx, > * proposed use case requirements, incl. hardwired dependent blocks > like > * pingpong > * @rm: dpu resource manager handle > + * @global_state: resources shared across multiple kms objects > * @enc_id: encoder id requesting for allocation > * @lm_idx: index of proposed layer mixer in rm->mixer_blks[], > function checks > * if lm, and all other hardwired blocks connected to the lm (pp) > is > @@ -274,7 +275,7 @@ static bool _dpu_rm_check_lm_peer(struct dpu_rm > *rm, int primary_idx, > * mixer in rm->dspp_blks[]. > * @reqs: input parameter, rm requirements for HW blocks needed in the > * datapath. > - * @Return: true if lm matches all requirements, false otherwise > + * Return: true if lm matches all requirements, false otherwise > */ > static bool _dpu_rm_check_lm_and_get_connected_blks(struct dpu_rm *rm, > struct dpu_global_state *global_state,