From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C53EC43334 for ; Tue, 14 Jun 2022 22:13:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229969AbiFNWNN (ORCPT ); Tue, 14 Jun 2022 18:13:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238934AbiFNWNM (ORCPT ); Tue, 14 Jun 2022 18:13:12 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D86C243EEB; Tue, 14 Jun 2022 15:13:10 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AC0701763; Tue, 14 Jun 2022 15:13:10 -0700 (PDT) Received: from [10.57.84.206] (unknown [10.57.84.206]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C5993F73B; Tue, 14 Jun 2022 15:13:07 -0700 (PDT) Message-ID: <05636dcb-91bd-a1a4-911b-6cdc7e359a5c@arm.com> Date: Tue, 14 Jun 2022 23:13:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v10 06/10] docs: sysfs: coresight: Add sysfs ABI documentation for TPDM To: Mao Jinlong , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach Cc: Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org, Bjorn Andersson References: <20220611004331.7343-1-quic_jinlmao@quicinc.com> <20220611004331.7343-7-quic_jinlmao@quicinc.com> From: Suzuki K Poulose In-Reply-To: <20220611004331.7343-7-quic_jinlmao@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 11/06/2022 01:43, Mao Jinlong wrote: > Add API usage document for sysfs API in TPDM driver. > > Reviewed-by: Mike Leach > Signed-off-by: Mao Jinlong > --- > .../ABI/testing/sysfs-bus-coresight-devices-tpdm | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > > diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > new file mode 100644 > index 000000000000..92bc09fbb69b > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > @@ -0,0 +1,13 @@ > +What: /sys/bus/coresight/devices//integration_test > +Date: June 2022 > +KernelVersion 5.18 We have gone past this release. Please make this 5.20. Also, please merge this patch with the previous patch. > +Contact: Jinlong Mao (QUIC) , Tao Zhang (QUIC) > +Description: > + (Write) Run integration test for tpdm. Integration test > + will generate test data for tpdm. It can help to make > + sure that the trace path is enabled and the link configurations > + are fine. > + > + value to this sysfs node: This is not entirely clear to me/reader. Could we say : Accepts only one of the 2 values - 1 or 2. > + 1 : Generate 64 bits data > + 2 : Generate 32 bits data Suzuki