Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, sibi.sankar@oss.qualcomm.com,
	rajendra.nayak@oss.qualcomm.com
Subject: Re: [PATCH] arm64: dts: qcom: Move board nodes to common DTSI
Date: Fri, 15 May 2026 14:44:53 +0530	[thread overview]
Message-ID: <05c377ab-33ef-44e7-8708-575647de088e@oss.qualcomm.com> (raw)
In-Reply-To: <hc3bkodsdzq3to4aaax7vaeahhlrisk3iytuaxu46bjm37p75w@4e7c4a3gh3lb>

On 3/29/2026 4:27 PM, Dmitry Baryshkov wrote:
> On Fri, Mar 27, 2026 at 06:16:59PM +0530, Gopikrishna Garmidi wrote:
>>
>>
>> On 3/26/2026 7:55 PM, Krzysztof Kozlowski wrote:
>>> On 26/03/2026 15:21, Gopikrishna Garmidi wrote:
>>>> The display, peripherals (touchpad/touchscreen/keypad), usb and their
>>>> dependent device nodes are common to both Glymur and Mahua CRDs,
>>>> so move them from glymur-crd.dts to glymur-crd.dtsi to enable code
>>>> reuse.
>>>>
>>>
>>> Same questions as for earlier tries (why this has to be repeated?), e.g.
>>> x1-crd: Please describe here what is the actual common hardware. In
>>> terms of physical hardware, not what you want to share.
>>>
>>
>> Hi krzysztof,
>>
>> Thanks for the review,
>>
>> Will update the commit message in the next re-spin.
> 
> Before you respin, you can actually respond to the question. Do Glymur
> and Mahua CRD actually share those devices (in case of USB that would
> mean having the same baseboard with different SoCs being wired) or is it
> just "oh, this looks similar enough, let's create a common file".
> 

Hello,
Yes we've verified across glymur crd and mahua crd schematics, the regulator supply 
and data lines are common across both targets for the nodes in the patch

Thanks,
Pankaj


  reply	other threads:[~2026-05-15  9:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 14:21 [PATCH] arm64: dts: qcom: Move board nodes to common DTSI Gopikrishna Garmidi
2026-03-26 14:25 ` Krzysztof Kozlowski
2026-03-26 16:55   ` Sibi Sankar
2026-03-27  6:45     ` Krzysztof Kozlowski
2026-03-27 12:46   ` Gopikrishna Garmidi
2026-03-29 10:57     ` Dmitry Baryshkov
2026-05-15  9:14       ` Pankaj Patil [this message]
2026-04-02  3:30 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05c377ab-33ef-44e7-8708-575647de088e@oss.qualcomm.com \
    --to=pankaj.patil@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=gopikrishna.garmidi@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rajendra.nayak@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sibi.sankar@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox