From: Tao Zhang <quic_taozha@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Konrad Dybcio <konradybcio@gmail.com>,
Mike Leach <mike.leach@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Jinlong Mao <quic_jinlmao@quicinc.com>,
Leo Yan <leo.yan@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
<coresight@lists.linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
Hao Zhang <quic_hazha@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 1/9] dt-bindings: arm: Add support for DSB element
Date: Tue, 13 Sep 2022 15:00:51 +0800 [thread overview]
Message-ID: <05c64748-6a3b-fb0b-e6b7-3715f77de14f@quicinc.com> (raw)
In-Reply-To: <e015754f-2f33-ab7d-4f18-e1bef39a8390@linaro.org>
在 9/8/2022 6:54 PM, Krzysztof Kozlowski 写道:
> On 08/09/2022 10:44, Tao Zhang wrote:
>> Add property "qcom,dsb-elem-size" to support DSB element for TPDA.
>> Specifies the DSB element size supported by each monitor connected
>> to the aggregator on each port. Should be specified in pairs (port,
>> dsb element size).
>>
>> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
>> index eb9bfc5..1bb3fdf 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
>> @@ -40,6 +40,13 @@ properties:
>> minItems: 1
>> maxItems: 2
>>
>> + qcom,dsb-elem-size:
>> + description: |
>> + Specifies the DSB element size supported by each monitor
>> + connected to the aggregator on each port. Should be specified
>> + in pairs (port, dsb element size).
>> + $ref: /schemas/types.yaml#/definitions/uint32-array
> So it is rather uint32-matrix (need to describe the items subschema).
> What about maxItems?
>
> Best regards,
> Krzysztof
Yes, indeed it should be uint32-matrix here. I will update in the next
release.
The "maxItems" cannot be known explicitly because it depends on how many
DSB subunit TPDMs are connected to the TPDA input ports.
Usually the number of the items is 1 to several, but there is no limit
to its maximum value.
Best regards,
Tao
next prev parent reply other threads:[~2022-09-13 7:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 8:44 [PATCH 0/9] Add support to configure TPDM DSB subunit Tao Zhang
2022-09-08 8:44 ` [PATCH 1/9] dt-bindings: arm: Add support for DSB element Tao Zhang
2022-09-08 10:54 ` Krzysztof Kozlowski
2022-09-13 7:00 ` Tao Zhang [this message]
2022-09-13 9:14 ` Krzysztof Kozlowski
2022-09-13 0:48 ` Rob Herring
2022-09-13 7:56 ` Tao Zhang
2022-09-08 8:44 ` [PATCH 2/9] coresight-tpda: Add DSB dataset support Tao Zhang
2022-09-15 10:14 ` Suzuki K Poulose
2022-09-20 13:40 ` Tao Zhang
2022-09-08 8:44 ` [PATCH 3/9] coresight-tpdm: Initialize DSB subunit configuration Tao Zhang
2022-10-24 10:02 ` Suzuki K Poulose
[not found] ` <72af1fa4-fa64-7f23-4000-db6d6a9f7f22@quicinc.com>
2022-10-26 14:18 ` Suzuki K Poulose
2022-09-08 8:45 ` [PATCH 4/9] coresight-tpdm: Add reset node to TPDM node Tao Zhang
2022-10-24 10:10 ` Suzuki K Poulose
2022-10-27 6:52 ` Tao Zhang
2022-09-08 8:45 ` [PATCH 5/9] coresight-tpdm: Add nodes to set trigger timestamp and type Tao Zhang
2022-10-24 10:32 ` Suzuki K Poulose
2022-10-27 6:53 ` Tao Zhang
2022-09-08 8:45 ` [PATCH 6/9] coresight-tpdm: Add node to set dsb programming mode Tao Zhang
2022-10-24 14:49 ` Suzuki K Poulose
2022-10-27 6:55 ` Tao Zhang
2022-09-08 8:45 ` [PATCH 7/9] coresight-tpdm: Add nodes for dsb element creation Tao Zhang
2022-10-24 15:47 ` Suzuki K Poulose
2022-09-08 8:45 ` [PATCH 8/9] coresight-tpdm: Add nodes to configure pattern match output Tao Zhang
2022-10-24 15:51 ` Suzuki K Poulose
2022-09-08 8:45 ` [PATCH 9/9] coresight-tpdm: Add nodes for timestamp request Tao Zhang
2022-10-25 10:00 ` Suzuki K Poulose
2022-10-27 14:46 ` Tao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05c64748-6a3b-fb0b-e6b7-3715f77de14f@quicinc.com \
--to=quic_taozha@quicinc.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_hazha@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox