From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: kernel@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] coresight: add coresight Trace Network On Chip driver
Date: Wed, 7 May 2025 09:52:02 +0100 [thread overview]
Message-ID: <069e920c-7023-4a6d-b1c6-dc87ac9d2360@arm.com> (raw)
In-Reply-To: <4a6a8bad-e5d9-4613-a839-5a21491ef7c4@quicinc.com>
On 07/05/2025 05:26, Yuanfang Zhang wrote:
>
>
> On 5/6/2025 7:20 PM, Suzuki K Poulose wrote:
>> On 14/04/2025 10:16, Yuanfang Zhang wrote:
>>>
>>>
>>> On 4/11/2025 5:59 PM, Suzuki K Poulose wrote:
>>>> On 11/04/2025 09:57, Yuanfang Zhang wrote:
>>>>> Add a driver to support Coresight device Trace Network On Chip (TNOC),
>>>>> which is an integration hierarchy integrating functionalities of TPDA
>>>>> and funnels. It aggregates the trace and transports to coresight trace
>>>>> bus.
>>>>>
>>>>> Compared to current configuration, it has the following advantages:
>>>>> 1. Reduce wires between subsystems.
>>>>> 2. Continue cleaning the infrastructure.
>>>>> 3. Reduce Data overhead by transporting raw data from source to target.
>>>>>
>>>>> +------------------------+ +-------------------------+
>>>>> | Video Subsystem | |Video Subsystem |
>>>>> | +-------------+ | | +------------+ |
>>>>> | | Video TPDM | | | | Video TPDM | |
>>>>> | +-------------+ | | +------------+ |
>>>>> | | | | | |
>>>>> | v | | v |
>>>>> | +---------------+ | | +-----------+ |
>>>>> | | Video funnel | | | |Video TNOC | |
>>>>> | +---------------+ | | +-----------+ |
>>>>> +------------|-----------+ +------------|------------+
>>>>> | |
>>>>> v-----+ |
>>>>> +--------------------|---------+ |
>>>>> | Multimedia v | |
>>>>> | Subsystem +--------+ | |
>>>>> | | TPDA | | v
>>>>> | +----|---+ | +---------------------+
>>>>> | | | | Aggregator TNOC |
>>>>> | | | +----------|----------+
>>>>> | +-- | |
>>>>> | | | |
>>>>> | | | |
>>>>> | +------v-----+ | |
>>>>> | | Funnel | | |
>>>>> | +------------+ | |
>>>>> +----------------|-------------+ |
>>>>> | |
>>>>> v v
>>>>> +--------------------+ +------------------+
>>>>> | Coresight Sink | | Coresight Sink |
>>>>> +--------------------+ +------------------+
>>>>
>>>> If each NOC has TraceID, how do you reliably decode the trace ?
>>>> Is there a single NOC/TPDA in the path from Source to sink ?
>>>
>>> Not each TNOC has TraceID, there is only one TNOC has TraceID for one path
>>> from Source to sink. In the example, only the aggregator TNOC has traceID.
>>> Decode trace relying on TraceID + Inport number.
>>> It can has mutiple TNOC/TPDA in one path.
>>
>> So do we only describe the TNOCs that need traceId in the DT ? (e.g., Aggregator TNOC above ?) How about Video TNOC ? Don't we allocate a
>> trace id for it by default, when it is described ?
>>
>> Suzuki
>>
> yes, now only describe the TNOCs which need traceID, Video TNOC is another type, it is interconnect TNOC which collects trace from subsystems
> and transfers Aggr TNOC, it doesn't have ATID. Its driver is different from this patch, I want to describe it when upstream its driver.
Thanks! Please could you make sure to describe all of this when sending
out a patch in the cover letter ?
Cheers
Suzuki
>
> Yuanfang
>
>
>
>
>
>
next prev parent reply other threads:[~2025-05-07 8:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 8:57 [PATCH v3 0/2] coresight: Add Coresight Trace Network On Chip driver Yuanfang Zhang
2025-04-11 8:57 ` [PATCH v3 1/2] dt-bindings: arm: Add device Trace Network On Chip definition Yuanfang Zhang
2025-04-11 10:23 ` Rob Herring (Arm)
2025-04-11 13:46 ` Rob Herring
2025-04-11 8:57 ` [PATCH v3 2/2] coresight: add coresight Trace Network On Chip driver Yuanfang Zhang
2025-04-11 9:59 ` Suzuki K Poulose
2025-04-14 9:16 ` Yuanfang Zhang
2025-05-06 11:20 ` Suzuki K Poulose
2025-05-07 4:26 ` Yuanfang Zhang
2025-05-07 8:52 ` Suzuki K Poulose [this message]
2025-05-07 11:59 ` Suzuki K Poulose
2025-05-08 5:37 ` Yuanfang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=069e920c-7023-4a6d-b1c6-dc87ac9d2360@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=kernel@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=quic_yuanfang@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox