Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Gaurav Kohli <gkohli@codeaurora.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: gregkh@linuxfoundation.org, maxime.ripard@bootlin.com,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nvmem: core: add NVMEM_SYSFS Kconfig
Date: Tue, 16 Apr 2019 16:45:54 +0530	[thread overview]
Message-ID: <06b77a2d-a675-965d-224f-14ad8d9df106@codeaurora.org> (raw)
In-Reply-To: <20190416110144.GS2654@lahna.fi.intel.com>

Hi ,

I have reviewed and tested for both enabled and disabled and working as 
expected.

Please feel free to add:

Reviewed-by: Gaurav Kohli <gkohli@codeaurora.org>
Tested-by: Gaurav Kohli <gkohli@codeaurora.org>

Regards
Gaurav
On 4/16/2019 4:31 PM, Mika Westerberg wrote:
> On Tue, Apr 16, 2019 at 10:59:24AM +0100, Srinivas Kandagatla wrote:
>> Many nvmem providers are not very keen on having default sysfs
>> nvmem entry, as most of the usecases for them are inside kernel
>> itself. And in some cases read/writes to some areas in nvmem are
>> restricted and trapped at secure monitor level, so accessing them
>> from userspace would result in board reboots.
>>
>> This patch adds new NVMEM_SYSFS Kconfig to make binary sysfs entry
>> an optional one. This provision will give more flexibility to users.
>> This patch also moves existing sysfs code to a new file so that its
>> not compiled in when its not really required.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> 

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

  parent reply	other threads:[~2019-04-16 11:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16  9:59 [PATCH v2] nvmem: core: add NVMEM_SYSFS Kconfig Srinivas Kandagatla
2019-04-16  9:59 ` Srinivas Kandagatla
2019-04-16 11:01 ` Mika Westerberg
2019-04-16 11:01   ` Mika Westerberg
2019-04-16 11:15   ` Gaurav Kohli [this message]
2019-04-16 11:15     ` Gaurav Kohli
2019-04-24  5:19     ` Gaurav Kohli
2019-04-24  5:19       ` Gaurav Kohli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06b77a2d-a675-965d-224f-14ad8d9df106@codeaurora.org \
    --to=gkohli@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox