From: Vikash Garodia <quic_vgarodia@quicinc.com>
To: Ricardo Ribalda <ribalda@chromium.org>,
Michael Tretter <m.tretter@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Michal Simek <michal.simek@amd.com>,
Andy Walls <awalls@md.metrocast.net>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH v3 18/18] media: venus: Refactor hfi_buffer_alloc_mode_supported
Date: Tue, 18 Jun 2024 18:01:11 +0530 [thread overview]
Message-ID: <0832ee9a-dec3-9ed2-2386-d870495728cb@quicinc.com> (raw)
In-Reply-To: <20240527-cocci-flexarray-v3-18-cda09c535816@chromium.org>
On 5/28/2024 2:39 AM, Ricardo Ribalda wrote:
> Replace the old style single element array at the end of the struct with
> a flex array.
>
> The code does not allocate this structure, so the size change should not
> be a problem.
>
> This fixes the following cocci warning:
> drivers/media/platform/qcom/venus/hfi_helper.h:1233:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> drivers/media/platform/qcom/venus/hfi_helper.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media/platform/qcom/venus/hfi_helper.h
> index dee439ea4d2e..9545c964a428 100644
> --- a/drivers/media/platform/qcom/venus/hfi_helper.h
> +++ b/drivers/media/platform/qcom/venus/hfi_helper.h
> @@ -1230,7 +1230,7 @@ struct hfi_interlace_format_supported {
> struct hfi_buffer_alloc_mode_supported {
> u32 buffer_type;
> u32 num_entries;
> - u32 data[1];
> + u32 data[];
> };
>
> struct hfi_metadata_pass_through {
>
Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com>
next prev parent reply other threads:[~2024-06-18 12:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 21:08 [PATCH v3 00/18] media: Fix the last set of coccinelle warnings Ricardo Ribalda
2024-05-27 21:08 ` [PATCH v3 01/18] media: allegro: nal-hevc: Replace array[1] with arrray[N] Ricardo Ribalda
2024-05-28 13:52 ` Michael Tretter
2024-05-27 21:08 ` [PATCH v3 02/18] media: xilinx: Refactor struct xvip_dma Ricardo Ribalda
2024-05-28 14:00 ` Laurent Pinchart
2024-05-27 21:08 ` [PATCH v3 03/18] media: dvb-frontend/mxl5xx: Refactor struct MBIN_FILE_T Ricardo Ribalda
2024-05-30 12:33 ` Hans Verkuil
2024-05-30 12:59 ` Ricardo Ribalda
2024-05-27 21:08 ` [PATCH v3 04/18] media: dvb-frontend/mxl5xx: Use flex array for MBIN_SEGMENT_T Ricardo Ribalda
2024-05-30 12:35 ` Hans Verkuil
2024-05-27 21:08 ` [PATCH v3 05/18] media: pci: cx18: Use flex arrays for struct cx18_scb Ricardo Ribalda
2024-05-27 21:08 ` [PATCH v3 06/18] media: siano: Refactor struct sms_msg_data Ricardo Ribalda
2024-05-27 21:08 ` [PATCH v3 07/18] media: siano: Remove unused structures Ricardo Ribalda
2024-05-27 21:08 ` [PATCH v3 08/18] media: siano: Use flex arrays for sms_firmware Ricardo Ribalda
2024-05-27 21:08 ` [PATCH v3 09/18] media: venus: Remove unused structs Ricardo Ribalda
2024-06-18 11:31 ` Vikash Garodia
2024-05-27 21:09 ` [PATCH v3 10/18] media: venus: Use flex array for hfi_session_release_buffer_pkt Ricardo Ribalda
2024-06-18 11:49 ` Vikash Garodia
2024-05-27 21:09 ` [PATCH v3 11/18] media: venus: Refactor struct hfi_uncompressed_plane_info Ricardo Ribalda
2024-06-18 12:00 ` Vikash Garodia
2024-05-27 21:09 ` [PATCH v3 12/18] media: venus: Refactor struct hfi_session_get_property_pkt Ricardo Ribalda
2024-06-18 12:05 ` Vikash Garodia
2024-06-18 12:18 ` Vikash Garodia
2024-05-27 21:09 ` [PATCH v3 13/18] media: venus: Refactor struct hfi_uncompressed_format_supported Ricardo Ribalda
2024-06-18 12:15 ` Vikash Garodia
2024-05-27 21:09 ` [PATCH v3 14/18] media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt Ricardo Ribalda
2024-06-18 12:21 ` Vikash Garodia
2024-05-27 21:09 ` [PATCH v3 15/18] media: venus: Refactor hfi_session_empty_buffer_compressed_pkt Ricardo Ribalda
2024-06-18 12:22 ` Vikash Garodia
2024-05-27 21:09 ` [PATCH v3 16/18] media: venus: Refactor hfi_sys_get_property_pkt Ricardo Ribalda
2024-06-18 12:26 ` Vikash Garodia
2024-05-27 21:09 ` [PATCH v3 17/18] media: venus: Refactor hfi_session_fill_buffer_pkt Ricardo Ribalda
2024-06-18 12:28 ` Vikash Garodia
2024-05-27 21:09 ` [PATCH v3 18/18] media: venus: Refactor hfi_buffer_alloc_mode_supported Ricardo Ribalda
2024-06-18 12:31 ` Vikash Garodia [this message]
2024-06-18 12:34 ` [PATCH v3 00/18] media: Fix the last set of coccinelle warnings Vikash Garodia
2024-06-18 12:36 ` Ricardo Ribalda
2024-06-18 18:53 ` Vikash Garodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0832ee9a-dec3-9ed2-2386-d870495728cb@quicinc.com \
--to=quic_vgarodia@quicinc.com \
--cc=andersson@kernel.org \
--cc=awalls@md.metrocast.net \
--cc=bryan.odonoghue@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=mchehab@kernel.org \
--cc=michal.simek@amd.com \
--cc=ribalda@chromium.org \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox