From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajendra Nayak Subject: Re: [PATCH] regulator: qcom_spmi: Add support for pmi8994 Date: Fri, 3 Nov 2017 08:03:38 +0530 Message-ID: <08b1d1ba-c80c-620c-af40-0c2cb155c033@codeaurora.org> References: <1509614640-7291-1-git-send-email-rnayak@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:56202 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964918AbdKCCdn (ORCPT ); Thu, 2 Nov 2017 22:33:43 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd , broonie@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-arm@lists.infradead.org On 11/02/2017 11:28 PM, Stephen Boyd wrote: > On 11/02/2017 02:24 AM, Rajendra Nayak wrote: >> Document the regulators available on pmi8994 and add support for >> this PMIC to the SPMI PMIC regulator driver. >> >> Signed-off-by: Rajendra Nayak > > Reviewed-by: Stephen Boyd > Tested-by: Stephen Boyd thanks > >> diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c >> index 16c5f84..9f8eb5d 100644 >> --- a/drivers/regulator/qcom_spmi-regulator.c >> +++ b/drivers/regulator/qcom_spmi-regulator.c >> @@ -1619,11 +1619,20 @@ static int spmi_regulator_of_parse(struct device_node *node, >> { } >> }; >> >> +static const struct spmi_regulator_data pmi8994_regulators[] = { >> + { "s1", 0x1400, "vdd_s1", }, >> + { "s2", 0x1700, "vdd_s2", }, >> + { "s3", 0x1a00, "vdd_s3", }, >> + { "l1", 0x4000, "vdd_l1", }, >> + { } > > Should be a tab instead of spaces? Oops, looks like Mark already applied this :/ > >> +}; > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation