Re: [PATCH] drm/msm: Fix possible uninitialized access in fbdev

[Thomas Zimmermann <tzimmermann@suse.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1002 bytes --]

Hi

Am 22.02.23 um 13:37 schrieb Dmitry Baryshkov:
> On 22/02/2023 14:37, Thomas Zimmermann wrote:
>> Do not run drm_fb_helper_unprepare() if fbdev allocation fails. Avoids
>> access to an uninitialized pointer. Original bug report is at [1].
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Fixes: 3fb1f62f80a1 ("drm/fb-helper: Remove drm_fb_helper_unprepare() 
>> from drm_fb_helper_fini()")
>> Link: 
>> https://lore.kernel.org/oe-kbuild-all/202302220810.9dymwCQ8-lkp@intel.com/ # 1
>> ---
>>   drivers/gpu/drm/msm/msm_fbdev.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 

Impressive response time. Thanks a lot.

Best regards
Thomas

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]