From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
"Lee Jones" <lee@kernel.org>,
"Daniel Thompson" <danielt@kernel.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Pavel Machek" <pavel@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Kiran Gunda" <quic_kgunda@quicinc.com>,
"Helge Deller" <deller@gmx.de>, "Luca Weiss" <luca@lucaweiss.eu>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Eugene Lepshy" <fekz115@gmail.com>,
"Gianluca Boiano" <morf3089@gmail.com>,
"Alejandro Tafalla" <atafalla@dnyon.com>
Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Thompson <daniel.thompson@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 3/5] arm64: dts: qcom: msm8953-xiaomi-vince: correct wled ovp value
Date: Wed, 7 Jan 2026 15:08:04 +0100 [thread overview]
Message-ID: <09a4642a-3552-44e7-97bd-b26e6937ad8b@oss.qualcomm.com> (raw)
In-Reply-To: <20260107-pmi8950-wled-v1-3-5e52f5caa39c@mainlining.org>
On 1/7/26 2:31 PM, Barnabás Czémán wrote:
> Correct wled ovp value from 29600 to 29500.
This tells us what the fix is, but not why the fix needs to be made.
We can infer the former from the patch contents, but it's really
important that the next reader, perhaps in 5 years, can find out the
reason it was made.
How about:
"""
PMI8950 doesn't actually support setting an OVP threshold value of
29.6 V. The closest allowed value is 29.5 V. Set that instead.
"""
With this or similar commit message:
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-01-07 14:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 13:31 [PATCH 0/5] Fix PMI8950 WLED ovp values and more Barnabás Czémán
2026-01-07 13:31 ` [PATCH 1/5] dt-bindings: backlight: qcom-wled: Document ovp values for PMI8950 Barnabás Czémán
2026-01-07 14:03 ` Konrad Dybcio
2026-01-08 2:42 ` barnabas.czeman
2026-01-07 14:11 ` Krzysztof Kozlowski
2026-01-07 13:31 ` [PATCH 2/5] backlight: qcom-wled: Support " Barnabás Czémán
2026-01-07 14:05 ` Konrad Dybcio
2026-01-07 13:31 ` [PATCH 3/5] arm64: dts: qcom: msm8953-xiaomi-vince: correct wled ovp value Barnabás Czémán
2026-01-07 14:08 ` Konrad Dybcio [this message]
2026-01-07 13:31 ` [PATCH 4/5] arm64: dts: qcom: msm8937-xiaomi-land: " Barnabás Czémán
2026-01-07 13:31 ` [PATCH 5/5] arm64: dts: qcom: msm8953-xiaomi-daisy: fix backlight Barnabás Czémán
2026-01-07 14:13 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09a4642a-3552-44e7-97bd-b26e6937ad8b@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=atafalla@dnyon.com \
--cc=barnabas.czeman@mainlining.org \
--cc=conor+dt@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fekz115@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=luca@lucaweiss.eu \
--cc=morf3089@gmail.com \
--cc=pavel@kernel.org \
--cc=quic_kgunda@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox