From: Krzysztof Kozlowski <krzk@kernel.org>
To: Krishna Kurapati PSSNV <krishna.kurapati@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v6] arm64: dts: qcom: lemans-evk: Add OTG support for primary USB controller
Date: Fri, 28 Nov 2025 10:09:45 +0100 [thread overview]
Message-ID: <09ce56eb-2527-4f96-9417-82cbd75f722f@kernel.org> (raw)
In-Reply-To: <d57b71b0-f0b0-4dd5-91a6-53d570d9d060@oss.qualcomm.com>
On 27/11/2025 19:00, Krishna Kurapati PSSNV wrote:
>
>>> +&i2c11 {
>>> + status = "okay";
>>> +
>>> + hd3ss3220@67 {
>>
>
>
> Hi Krzysztof,
>
> Thanks for the review.
>
>> Node names should be generic. See also an explanation and list of
>> examples (not exhaustive) in DT specification:
>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>> If you cannot find a name matching your device, please check in kernel
>> sources for similar cases or you can grow the spec (via pull request to
>> DT spec repo).
>>
>
> I see the following used in some freescale DTs:
> usb-typec@47
> usb_typec: usb-typec@67
> usb-mux@47
>
> In Renesas DTs I see the following used:
> hd3ss3220@47
>
> Can I use "usb-typec" and rename the node ?
Yes, usb-typec feels right.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-11-28 9:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 7:35 [PATCH v6] arm64: dts: qcom: lemans-evk: Add OTG support for primary USB controller Krishna Kurapati
2025-11-27 8:19 ` Krzysztof Kozlowski
2025-11-27 18:00 ` Krishna Kurapati PSSNV
2025-11-28 9:09 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09ce56eb-2527-4f96-9417-82cbd75f722f@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox