From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00C1EC74A5B for ; Wed, 29 Mar 2023 11:19:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229750AbjC2LTG (ORCPT ); Wed, 29 Mar 2023 07:19:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229782AbjC2LTC (ORCPT ); Wed, 29 Mar 2023 07:19:02 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0F56448A for ; Wed, 29 Mar 2023 04:18:49 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id o20so12736930ljp.3 for ; Wed, 29 Mar 2023 04:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680088728; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aumpSLpdIfLau4SMf/sV4ChK4mZM2lEguzptioMGQ4U=; b=uFwVrsI6SSC2d9PykTW4cU7uDFJl43V+qNoP5Mu9QsCHu21y6cgb5yiaCUIA8gcaE6 jjUixrJNaWA1Cj+Nmuvxm26mz/COosJGIcydHRU5IXxvq7hB8lFlte0K+AiRc89sH5vZ R7KEWf9G/LC/tLe122uw/eB1mbeS+uaBQFi1yCdDM+apYT2Z7ca2ENnNyIBDDQIAE8JV +lxiLDOGiQZqygnP33zQAp+4hlaecddzfea4juzVcxvG1X54WucAwLCDvYYRKgoa7K3N 3ZTvWzmgYW5m9I2iOHEy8Qy6GVl9d2U3LtxcOGI8AlkIeKPyeVHUmiJA2pj46nT0rvPP jrTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680088728; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aumpSLpdIfLau4SMf/sV4ChK4mZM2lEguzptioMGQ4U=; b=dhfQdMcmf0ahMkA31zBcjlqTpZRJ6RamD6MUjGmJlz8Ci7tlboGGKkwFS4JmroltF/ 65t7nFIM9xJ52MYkM6cZBBhaUmKtJl6v6VCB9CZbZrmhNVnZ4dZpUyEyhVXZxOrXLCrA ChvNKgSghVfWsfvORC4MNOMOjKTDROiIiVoobDe5XKIjDZbpEzfIUl7CV2L9alEdgcKJ Hj1apAJKYliv00G8NvWsgTv1fhgShXd8rXWxp4FMUSi56g2INjJFiv52wiW1hbsltxbS hY7yj19gJq2KG9zZqYdZcctLvI0aDHPBK9nRvPlz7nK8iA0XJekxKFimFkpPWTJcCCel m7Tw== X-Gm-Message-State: AAQBX9c9fQEcmfGkmyLuB0wERX3DdtQY+NgiDymOTrkb8VPp2t7Gn6ub od+5TZn3PTqukGsB4+T2ozV6OQ== X-Google-Smtp-Source: AKy350Y+FUEY3T5G6lVTIZU60xd7NyIE28Cebhu9hQFEyNetn4hH5Q2gpXeT36vTCVqan1zZiOD9Tw== X-Received: by 2002:a2e:3011:0:b0:298:b338:f5db with SMTP id w17-20020a2e3011000000b00298b338f5dbmr5451392ljw.52.1680088728062; Wed, 29 Mar 2023 04:18:48 -0700 (PDT) Received: from [192.168.1.101] (abxj225.neoplus.adsl.tpnet.pl. [83.9.3.225]) by smtp.gmail.com with ESMTPSA id u9-20020a2e8449000000b00293534d9760sm5490627ljh.127.2023.03.29.04.18.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Mar 2023 04:18:47 -0700 (PDT) Message-ID: <09f50ca6-3480-0c8d-9494-35893393d205@linaro.org> Date: Wed, 29 Mar 2023 13:18:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/2] dt-bindings: interrupt-controller: mpm: Allow passing reg through phandle Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Shawn Guo Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20230328-topic-msgram_mpm-v1-0-1b788a5f5a33@linaro.org> <20230328-topic-msgram_mpm-v1-1-1b788a5f5a33@linaro.org> <863d5a85-3399-5a43-b755-1316e3adcfec@linaro.org> From: Konrad Dybcio In-Reply-To: <863d5a85-3399-5a43-b755-1316e3adcfec@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 29.03.2023 10:27, Krzysztof Kozlowski wrote: > On 28/03/2023 12:02, Konrad Dybcio wrote: >> Due to the wild nature of the Qualcomm RPM Message RAM, we can't really >> use 'reg' to point to the MPM's slice of Message RAM without cutting into >> an already-defined RPM MSG RAM node used for GLINK and SMEM. >> >> Document passing the register space as a slice of SRAM through the >> qcom,rpm-msg-ram property. This also makes 'reg' no longer required. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >> index 509d20c091af..77fe5e0b378f 100644 >> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >> @@ -30,6 +30,11 @@ properties: >> description: >> Specifies the base address and size of vMPM registers in RPM MSG RAM. >> >> + qcom,rpm-msg-ram: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + Phandle to the APSS MPM slice of the RPM Message RAM >> + >> interrupts: >> maxItems: 1 >> description: >> @@ -64,7 +69,6 @@ properties: >> >> required: >> - compatible >> - - reg > > Either: > 1. make reg deprecated and require qcom,rpm-msg-ram > or > 2. you need oneOf:required for reg and qcom,rpm-msg-ram Right, let's go with 1. Konrad > >> - interrupts >> - mboxes >> - interrupt-controller >> > > Best regards, > Krzysztof >