From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ED0412D74F for ; Tue, 30 Apr 2024 11:15:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714475747; cv=none; b=eM2kJ3qDy42T+kfn6Pt5q4SRo/ylGzPWxs+OM4UQE4+yG/9XNUZAFRE8v5LZ8smIujiwq35gx3QmpIC8MZ+f26Gf+SOU1F8pobaXhTc7LlkRyPR/mfmmMMlWntIVbIm6XGFGJoNIJmSpff/6F3W2M28ktFQ3rTAd6nrJlT57EDw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714475747; c=relaxed/simple; bh=QqYTK9YTfNjwsAqsh2I4pBktmmQMA6Z0sfpg5SrkUqg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eDYR5dKdO/rSBJ2qBGyLtNsjxa4H3xONB4VwuxNkFLVzM6mhwCbTx3CRHhUupPA8K5sc/9aGqHqCC0B6BgE8cseRVzEWVAg/iOEqxoqE5ssNmVVL7UEkKoihwJbEaZRFFFxZoamh+NcCU2fk7FVtxMWxW5ob7ni25C+Ng7FPmHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr; spf=pass smtp.mailfrom=freebox.fr; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b=Sbg5ZNGr; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=freebox.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b="Sbg5ZNGr" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-346b96f1483so3029279f8f.1 for ; Tue, 30 Apr 2024 04:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebox-fr.20230601.gappssmtp.com; s=20230601; t=1714475743; x=1715080543; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fmDNtKNAUj+EAe14afk12YEoJlqoF5/CO+cJg8bHSIE=; b=Sbg5ZNGrT7EgCbv25Y44+zLzPP/zQUkveCJXgMYZ6hLbN5swvAIvs+usTBcnpl1Bv6 Nv7HI13Vuhj6QAusSZu0j8+OP58y1l0F2S+pcfYTJBysZiqrigt7gQLKnNKgEDOaMdJm SDtGiyF0K2Bb3u4zSgiwWxZ6UcNyqirSojbdQFqK9UW2CTwqS1aMQ73GfbmYuLB1uDL0 wwKO8WWdXPH6zQVne3UJUuMF9MU+8IYo/qOqdcc2XN0pGQOU+ywu+AmUzYIbthHp9h7r M5AwMs0R0nhyXMaMhKiXC1D32w3iP39zSzi7aI0rv5CmAO8DC6fgQbiEPUCH4lM4veeA 5fhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714475743; x=1715080543; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fmDNtKNAUj+EAe14afk12YEoJlqoF5/CO+cJg8bHSIE=; b=eYR4L5ps5I//W2EJWD48bfdNLwqiMx9t+lR4ARi3ZsiHzkVnVQuZc0GFNnMcYFjotW Fy/n3pLb2Cw/msjzFvFDkof7tTil5giAUMx5k7qT42dNmDCGdJfrtdUSlFippxYIf8O/ tUSlroYE12CZP8nwFAy2Bq5mOlcGLqsnEatNSPTHNM+SaNv3ZuuDHoUvKxGBWHdQX2MD 6XnmDHglviCtEIJLOp+goLEy5qXQ4G5e6ApYkWLVIuVeB5Vu0yydAtoE7Z1+l0BwhEZY m1SDWqEkHfae7LqxLLb5kkLABcX22yroHbnUaI5zJQiUpK21epS5Q2EHlBRS+QwY+jRV TiqA== X-Forwarded-Encrypted: i=1; AJvYcCU1KfEhSRP8pzV1seTPVHHljNufgkzAKfQEUng15Ykut8QdSMKLBoWnx7xbWEQChaYNcWXSaGlpKhKCJqHzPaNuGtjXczrC1pjErXzHeA== X-Gm-Message-State: AOJu0YzORUKkFX79InsqH6dEZQ3iiuA7e+WB4pV+AyhnEtK4ioSqBC6r 2UPJ6DTXJQo6p6jgRxaUGt49oiMHmf2PZBKFAL/SX4pBGQnUb3Ll6fH120Kj3AY= X-Google-Smtp-Source: AGHT+IHEFMtXAH/YKrNwQKlXxkPWH5Zf/6vTdgXFkM/G+vP1WzEEk5r/knMRdxIagzjU3f1WjQovVA== X-Received: by 2002:adf:a792:0:b0:349:bb17:6e60 with SMTP id j18-20020adfa792000000b00349bb176e60mr1941881wrc.2.1714475743585; Tue, 30 Apr 2024 04:15:43 -0700 (PDT) Received: from [192.168.108.81] (freebox.vlq16.iliad.fr. [213.36.7.13]) by smtp.gmail.com with ESMTPSA id u4-20020a5d6ac4000000b0034c3d1e1391sm11786111wrw.42.2024.04.30.04.15.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 04:15:43 -0700 (PDT) Message-ID: <0a242bc1-fe8a-439b-96cb-bebdf2ada7d7@freebox.fr> Date: Tue, 30 Apr 2024 13:15:42 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] wifi: ath10k: do not always wait for MSA_READY indicator To: Kalle Valo , Bjorn Andersson Cc: Jeff Johnson , ath10k , wireless , DT , MSM , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pierre-Hugues Husson , Arnaud Vrac , Bjorn Andersson , Konrad Dybcio , Jami Kettunen , Jeffrey Hugo , Dmitry Baryshkov , Alexey Minnekhanov References: <23540303-5816-45d5-a1af-5f09d645a73b@freebox.fr> Content-Language: en-US From: Marc Gonzalez In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/04/2024 04:24, Bjorn Andersson wrote: > On Mon, Apr 29, 2024 at 04:06:29PM +0200, Marc Gonzalez wrote: > >> The ath10k driver waits for an "MSA_READY" indicator >> to complete initialization. If the indicator is not >> received, then the device remains unusable. >> >> Several msm8998-based devices are affected by this issue. >> Oddly, it seems safe to NOT wait for the indicator, and >> proceed immediately when QMI_EVENT_SERVER_ARRIVE. >> >> fw_version 0x100204b2 >> fw_build_timestamp 2019-09-04 03:01 >> fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.1.0-01202-QCAHLSWMTPLZ-1.221523.2 >> >> Jeff Johnson wrote: >> >> The feedback I received was "it might be ok to change all ath10k qmi >> to skip waiting for msa_ready", and it was pointed out that ath11k >> (and ath12k) do not wait for it. >> >> However with so many deployed devices, "might be ok" isn't a strong >> argument for changing the default behavior. >> >> Signed-off-by: Pierre-Hugues Husson >> Signed-off-by: Marc Gonzalez > > As with patch 1, please address the s-o-b and accept my: > > Reviewed-by: Bjorn Andersson As with patch 1, I typed this patch all by myself with my grubby little paws. You can drop PH's S-o-b. Regards