From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A03C77B78 for ; Wed, 3 May 2023 07:45:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229491AbjECHpF (ORCPT ); Wed, 3 May 2023 03:45:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbjECHpC (ORCPT ); Wed, 3 May 2023 03:45:02 -0400 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A4CB1BEB for ; Wed, 3 May 2023 00:44:57 -0700 (PDT) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-55a2691637bso50916037b3.0 for ; Wed, 03 May 2023 00:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683099896; x=1685691896; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=az3ZjZw5c+oMwn1F0ZqH0yI5AWLiLyNI1BlVOd3ymQ8=; b=zir+QTa2OoYRyEL82qbdMjPM4PdjHMEJZY1MWJvAskJCX9GmJP35sQw11Pz/ae8iZI LK1uvUO9Yb09slOZ0h2VU2o6LxBLLXBPAn0lM+i23XeI31IBGAMn9LDnPf85h3nXEu7W /7lcfLKxWlWg80qPzKTTHQsA0tK94v1RQFJwLfXKFdbVSjKVvWS8G1q1Aq1g8CdRJW2P RiYMX4qkZDTKuTpQoq4xXiIT9r7zG3ZeWzZP8UBf959kQlWLRLqWHI1EskALyQJ+giZY SyglIN3PcF7IDp3j0DC8O9D2GxfaD5oD/I+04S+wsp9y3Rb4KP/PdyCj9ym1yV+JaqP9 sf6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683099896; x=1685691896; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=az3ZjZw5c+oMwn1F0ZqH0yI5AWLiLyNI1BlVOd3ymQ8=; b=VEF92hCM0LhTwQ3SOdKe7YlIoyTNn3IPgxWym8/4BLufjxfXjbbl4k34loiKoyO+Sm V7xol8qgDpMiorAjjRZtWaGpnuEGaR9I+U13efT0g6xS4CYt7ShC0ZGAEoTvPQicwzas a7m9KwUBoXBUTHKr6Smuu7ik40vWxSrcJsc+nFsefLXRkmDARavy9EPTSNgJULJ0NWZg 6f0bZQ1rF9Hc0ewmWi1luRole2GQbNuQbnaJEKAhP1psrjR4msCrTBxn+FHlYC05SYjR 0nEzqx+do8lMZHrEeEqyCtKuuUc/XefNIzJkaw+xvSjStJYBrFyuU/oLVpjm5Mlk3qWB X98g== X-Gm-Message-State: AC+VfDyaPrd4vWb81LvmP7D3/3MjNLJhHYV2QtacM48YBDdv4fYCeBIw ZZTuwKRnLmqLPtp8OVMZpwRo1Q== X-Google-Smtp-Source: ACHHUZ6nzF9dKBpKYl4KrQ1B3kU7KyZBLmv5XILSEzR8eD10wsiU6RQ9szs3+zgoxeFB55g7Mr6CjQ== X-Received: by 2002:a0d:efc2:0:b0:556:ceb2:c462 with SMTP id y185-20020a0defc2000000b00556ceb2c462mr17663236ywe.2.1683099896640; Wed, 03 May 2023 00:44:56 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id k63-20020a0dc842000000b00555ca01b112sm3283263ywd.105.2023.05.03.00.44.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 May 2023 00:44:56 -0700 (PDT) Message-ID: <0a7caa8d-289a-d76a-d57b-611b178fdc34@linaro.org> Date: Wed, 3 May 2023 10:44:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v1 4/4] arm64: dts: qcom: ipq9574: add thermal zone nodes Content-Language: en-GB To: Varadarajan Narayanan , amitk@kernel.org, thara.gopinath@gmail.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Praveenkumar I References: <65d05b81201a8d24c14f0d7564e708348a368068.1683027347.git.quic_varada@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <65d05b81201a8d24c14f0d7564e708348a368068.1683027347.git.quic_varada@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 03/05/2023 07:46, Varadarajan Narayanan wrote: > This patch adds thermal zone nodes for the various > sensors present in IPQ9574 > > Co-developed-by: Praveenkumar I > Signed-off-by: Praveenkumar I > Signed-off-by: Varadarajan Narayanan Reviewed-by: Dmitry Baryshkov one nit below. > --- > [v1]: > Fix node names > --- > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 208 ++++++++++++++++++++++++++++++++++ > 1 file changed, 208 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > index b22b999..bc4d061 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > @@ -1067,6 +1067,214 @@ > }; > }; > > + thermal-zones { > + nss-top-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens 3>; > + > + trips { > + nss-top-critical { > + temperature = <125000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + ubi-0-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens 4>; > + > + trips { > + ubi_0-critical { > + temperature = <125000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + ubi-1-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens 5>; > + > + trips { > + ubi_1-critical { > + temperature = <125000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + ubi-2-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens 6>; > + > + trips { > + ubi_2-critical { > + temperature = <125000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + ubi-3-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens 7>; > + > + trips { > + ubi_3-critical { > + temperature = <125000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + cluster0-thermal { I think we were usually using cpussN instead of clusterN, but this is really a minor issue, we don't have that standardized. > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens 8>; > + > + trips { > + cpu-critical { > + temperature = <125000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + cluster1-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens 9>; > + > + trips { > + cpu-critical { > + temperature = <125000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + cpu0-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens 10>; > + > + trips { > + cpu-critical { > + temperature = <120000>; > + hysteresis = <10000>; > + type = "critical"; > + }; > + > + cpu-passive { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "passive"; > + }; > + }; > + }; > + > + cpu1-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens 11>; > + > + trips { > + cpu-critical { > + temperature = <120000>; > + hysteresis = <10000>; > + type = "critical"; > + }; > + > + cpu-passive { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "passive"; > + }; > + }; > + }; > + > + cpu2-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens 12>; > + > + trips { > + cpu-critical { > + temperature = <120000>; > + hysteresis = <10000>; > + type = "critical"; > + }; > + > + cpu-passive { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "passive"; > + }; > + }; > + }; > + > + cpu3-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens 13>; > + > + trips { > + cpu-critical { > + temperature = <120000>; > + hysteresis = <10000>; > + type = "critical"; > + }; > + > + cpu-passive { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "passive"; > + }; > + }; > + }; > + > + wcss-phyb-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens 14>; > + > + trips { > + wcss_phyb-critical { > + temperature = <125000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + top-glue-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens 15>; > + > + trips { > + top_glue-critical { > + temperature = <125000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + }; > + > timer { > compatible = "arm,armv8-timer"; > interrupts = , -- With best wishes Dmitry